[INFO] updating cached repository ChariotEngine/jasc-and-gpl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ChariotEngine/jasc-and-gpl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ChariotEngine/jasc-and-gpl" "work/ex/clippy-test-run/sources/stable/gh/ChariotEngine/jasc-and-gpl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ChariotEngine/jasc-and-gpl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ChariotEngine/jasc-and-gpl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChariotEngine/jasc-and-gpl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChariotEngine/jasc-and-gpl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7dd9916f5ef7b3eccaba7b7c573f22dd3700b1f3 [INFO] sha for GitHub repo ChariotEngine/jasc-and-gpl: 7dd9916f5ef7b3eccaba7b7c573f22dd3700b1f3 [INFO] validating manifest of ChariotEngine/jasc-and-gpl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ChariotEngine/jasc-and-gpl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ChariotEngine/jasc-and-gpl [INFO] finished frobbing ChariotEngine/jasc-and-gpl [INFO] frobbed toml for ChariotEngine/jasc-and-gpl written to work/ex/clippy-test-run/sources/stable/gh/ChariotEngine/jasc-and-gpl/Cargo.toml [INFO] started frobbing ChariotEngine/jasc-and-gpl [INFO] finished frobbing ChariotEngine/jasc-and-gpl [INFO] frobbed toml for ChariotEngine/jasc-and-gpl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ChariotEngine/jasc-and-gpl/Cargo.toml [INFO] crate ChariotEngine/jasc-and-gpl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ChariotEngine/jasc-and-gpl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ChariotEngine/jasc-and-gpl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 890ce3844d65a41cd46d28b5eca40d233bf2aa9410820d01257b32c7df61d8f3 [INFO] running `"docker" "start" "-a" "890ce3844d65a41cd46d28b5eca40d233bf2aa9410820d01257b32c7df61d8f3"` [INFO] [stderr] Checking gimp_palette v0.1.1 [INFO] [stderr] Checking chariot_palette v0.1.1 [INFO] [stderr] Checking jasc-and-gpl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `jasc_path` [INFO] [stderr] --> src/main.rs:66:65 [INFO] [stderr] | [INFO] [stderr] 66 | fn gpl_to_jasc + std::fmt::Display>(gpl_path: P, jasc_path: P) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_jasc_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gpl_to_jasc` [INFO] [stderr] --> src/main.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | fn gpl_to_jasc + std::fmt::Display>(gpl_path: P, jasc_path: P) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | let jasc_file = File::open(&jasc_path).expect(&format!("Failed to open {}", jasc_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", jasc_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:54:51 [INFO] [stderr] | [INFO] [stderr] 54 | jasc_palette::read_from(&mut jasc_reader).expect(&format!("Failed to load a JASC palette from {}", jasc_path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to load a JASC palette from {}", jasc_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | Err(_) => panic!("Failed to create a GIMP palette in-memory"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | gpl_pal.write_to_file(&gpl_path).expect(&format!("Failed to write GIMP palette to {}", gpl_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to write GIMP palette to {}", gpl_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | Err(_) => panic!("Failed to read GIMP palette from {}", gpl_path) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: unused variable: `jasc_path` [INFO] [stderr] --> src/main.rs:66:65 [INFO] [stderr] | [INFO] [stderr] 66 | fn gpl_to_jasc + std::fmt::Display>(gpl_path: P, jasc_path: P) { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_jasc_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `gpl_to_jasc` [INFO] [stderr] --> src/main.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | fn gpl_to_jasc + std::fmt::Display>(gpl_path: P, jasc_path: P) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | let jasc_file = File::open(&jasc_path).expect(&format!("Failed to open {}", jasc_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to open {}", jasc_path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:54:51 [INFO] [stderr] | [INFO] [stderr] 54 | jasc_palette::read_from(&mut jasc_reader).expect(&format!("Failed to load a JASC palette from {}", jasc_path)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to load a JASC palette from {}", jasc_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | Err(_) => panic!("Failed to create a GIMP palette in-memory"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | gpl_pal.write_to_file(&gpl_path).expect(&format!("Failed to write GIMP palette to {}", gpl_path)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to write GIMP palette to {}", gpl_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | Err(_) => panic!("Failed to read GIMP palette from {}", gpl_path) [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.00s [INFO] running `"docker" "inspect" "890ce3844d65a41cd46d28b5eca40d233bf2aa9410820d01257b32c7df61d8f3"` [INFO] running `"docker" "rm" "-f" "890ce3844d65a41cd46d28b5eca40d233bf2aa9410820d01257b32c7df61d8f3"` [INFO] [stdout] 890ce3844d65a41cd46d28b5eca40d233bf2aa9410820d01257b32c7df61d8f3