[INFO] updating cached repository Centril/consensusbot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Centril/consensusbot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Centril/consensusbot" "work/ex/clippy-test-run/sources/stable/gh/Centril/consensusbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Centril/consensusbot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Centril/consensusbot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Centril/consensusbot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Centril/consensusbot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 18dbb644e044f0562de9158ded1a555b492c0671 [INFO] sha for GitHub repo Centril/consensusbot: 18dbb644e044f0562de9158ded1a555b492c0671 [INFO] validating manifest of Centril/consensusbot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Centril/consensusbot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Centril/consensusbot [INFO] finished frobbing Centril/consensusbot [INFO] frobbed toml for Centril/consensusbot written to work/ex/clippy-test-run/sources/stable/gh/Centril/consensusbot/Cargo.toml [INFO] started frobbing Centril/consensusbot [INFO] finished frobbing Centril/consensusbot [INFO] frobbed toml for Centril/consensusbot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Centril/consensusbot/Cargo.toml [INFO] crate Centril/consensusbot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Centril/consensusbot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Centril/consensusbot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 266653a67acb609b1aaf26466e49ae8062a6c9a7050245d5fa381f40f6e8a0e5 [INFO] running `"docker" "start" "-a" "266653a67acb609b1aaf26466e49ae8062a6c9a7050245d5fa381f40f6e8a0e5"` [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking combine v3.5.1 [INFO] [stderr] Checking rusty-fork v0.2.1 [INFO] [stderr] Checking proptest v0.8.6 [INFO] [stderr] Checking rfcbot-lib v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: method is never used: `activation_phrase` [INFO] [stderr] --> src/teams.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn activation_phrase(&self) -> ActivationPhrase<'_> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `team_labels` [INFO] [stderr] --> src/teams.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn team_labels(&self) -> impl Iterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `teams` [INFO] [stderr] --> src/teams.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn teams(&self) -> impl Iterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `should_ffcp_auto_close` [INFO] [stderr] --> src/teams.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn should_ffcp_auto_close(&self, repo: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `should_ffcp_auto_postpone` [INFO] [stderr] --> src/teams.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn should_ffcp_auto_postpone(&self, repo: &str) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ping` [INFO] [stderr] --> src/teams.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn ping(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `member_logins` [INFO] [stderr] --> src/teams.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | pub fn member_logins(&self) -> impl Iterator { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_rfcbot_cfg` [INFO] [stderr] --> src/teams.rs:79:1 [INFO] [stderr] | [INFO] [stderr] 79 | fn read_rfcbot_cfg() -> RfcbotConfig { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `read_rfcbot_cfg_from` [INFO] [stderr] --> src/teams.rs:84:1 [INFO] [stderr] | [INFO] [stderr] 84 | fn read_rfcbot_cfg_from(input: &str) -> RfcbotConfig { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `ping` [INFO] [stderr] --> src/teams.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn ping(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/teams.rs:152:52 [INFO] [stderr] | [INFO] [stderr] 152 | cfg.teams().map(|(k, v)| (k.0.clone(), v.clone())).collect(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 152 | cfg.teams().map(|(k, v)| (k.0.clone(), &(*v).clone())).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 152 | cfg.teams().map(|(k, v)| (k.0.clone(), &teams::Team::clone(v))).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/teams.rs:154:24 [INFO] [stderr] | [INFO] [stderr] 154 | let avengers = map.get("T-avengers").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["T-avengers"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/teams.rs:161:19 [INFO] [stderr] | [INFO] [stderr] 161 | let jsa = map.get("justice-league").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map["justice-league"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rfcbot-lib`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "266653a67acb609b1aaf26466e49ae8062a6c9a7050245d5fa381f40f6e8a0e5"` [INFO] running `"docker" "rm" "-f" "266653a67acb609b1aaf26466e49ae8062a6c9a7050245d5fa381f40f6e8a0e5"` [INFO] [stdout] 266653a67acb609b1aaf26466e49ae8062a6c9a7050245d5fa381f40f6e8a0e5