[INFO] updating cached repository Censkh/Maxwell [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Censkh/Maxwell [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Censkh/Maxwell" "work/ex/clippy-test-run/sources/stable/gh/Censkh/Maxwell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Censkh/Maxwell'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Censkh/Maxwell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Censkh/Maxwell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Censkh/Maxwell'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 347f9ebf1d50028287b675bf059c75da2af3e44c [INFO] sha for GitHub repo Censkh/Maxwell: 347f9ebf1d50028287b675bf059c75da2af3e44c [INFO] validating manifest of Censkh/Maxwell on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Censkh/Maxwell on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Censkh/Maxwell [INFO] finished frobbing Censkh/Maxwell [INFO] frobbed toml for Censkh/Maxwell written to work/ex/clippy-test-run/sources/stable/gh/Censkh/Maxwell/Cargo.toml [INFO] started frobbing Censkh/Maxwell [INFO] finished frobbing Censkh/Maxwell [INFO] frobbed toml for Censkh/Maxwell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Censkh/Maxwell/Cargo.toml [INFO] crate Censkh/Maxwell has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Censkh/Maxwell against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Censkh/Maxwell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 03424b8db35de976b891f64501106a402409d9ba9fa69ec00ad8bc7deec11619 [INFO] running `"docker" "start" "-a" "03424b8db35de976b891f64501106a402409d9ba9fa69ec00ad8bc7deec11619"` [INFO] [stderr] Checking json v0.11.9 [INFO] [stderr] Checking maxwell v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return TokenizerError { description: description.to_owned() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TokenizerError { description: description.to_owned() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return &self.description; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Tokenizer {}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Tokenizer {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | return Ok(Token::Operator(operator)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Operator(operator))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(Token::BracketOpen); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BracketOpen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(Token::BracketClose); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BracketClose)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(Token::BraceOpen); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BraceOpen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | return Ok(Token::BraceClose); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BraceClose)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | return Ok(Token::Semicolon); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Semicolon)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | return Ok(Token::Colon); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Colon)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | return Ok(token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(token)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return Ok(Token::Comma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Comma)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | return Ok(Token::Literal(Literal::Number(self.read_number(chunk, start).to_owned()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Literal(Literal::Number(self.read_number(chunk, start).to_owned())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | / return match label { [INFO] [stderr] 157 | | "if" => Ok(Token::Keyword(Keyword::If)), [INFO] [stderr] 158 | | "function" => Ok(Token::Keyword(Keyword::Function)), [INFO] [stderr] 159 | | "return" => Ok(Token::Keyword(Keyword::Return)), [INFO] [stderr] ... | [INFO] [stderr] 193 | | value => Ok(Token::Identifier(value.to_owned())) [INFO] [stderr] 194 | | }; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 156 | match label { [INFO] [stderr] 157 | "if" => Ok(Token::Keyword(Keyword::If)), [INFO] [stderr] 158 | "function" => Ok(Token::Keyword(Keyword::Function)), [INFO] [stderr] 159 | "return" => Ok(Token::Keyword(Keyword::Return)), [INFO] [stderr] 160 | "while" => Ok(Token::Keyword(Keyword::While)), [INFO] [stderr] 161 | "switch" => Ok(Token::Keyword(Keyword::Switch)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | return Err(TokenizerError::new("Invalid token.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TokenizerError::new("Invalid token."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | return Token::Literal(Literal::String(value,quote)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Literal(Literal::String(value,quote))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | return chunk.slice(start, chunk.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunk.slice(start, chunk.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | return (token, string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(token, string)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | return (token, string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(token, string)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return Ok(ChunkLocation { path }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ChunkLocation { path })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(ChunkLocation { path }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ChunkLocation { path })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return hasher.finish(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hasher.finish()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / return Chunk { [INFO] [stderr] 59 | | name, [INFO] [stderr] 60 | | loaded:false, [INFO] [stderr] 61 | | location, [INFO] [stderr] ... | [INFO] [stderr] 65 | | dependencies: Dependencies::new() [INFO] [stderr] 66 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Chunk { [INFO] [stderr] 59 | name, [INFO] [stderr] 60 | loaded:false, [INFO] [stderr] 61 | location, [INFO] [stderr] 62 | source: String::new(), [INFO] [stderr] 63 | index: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return self.location.generate_id(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.location.generate_id()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return Ok(&self.source); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(&self.source)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return self.char_at(self.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.char_at(self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return self.source.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.source.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return self.index >= self.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.index >= self.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | return self.source.slice_unchecked(start, self.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.source.slice_unchecked(start, self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | return self.source.slice_unchecked(start, end); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.source.slice_unchecked(start, end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return self.index; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return self.source.chars().nth(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.source.chars().nth(index).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/lexicon.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return ident_lookup::TABLE[char as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ident_lookup::TABLE[char as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/token.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return str; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/literal.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return match *self { [INFO] [stderr] 21 | | QuoteKind::Apostrophe => "'", [INFO] [stderr] 22 | | QuoteKind::SpeechMark => "\"", [INFO] [stderr] 23 | | }.to_owned(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | match *self { [INFO] [stderr] 21 | QuoteKind::Apostrophe => "'", [INFO] [stderr] 22 | QuoteKind::SpeechMark => "\"", [INFO] [stderr] 23 | }.to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/literal.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return str; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/keyword.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return string; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/operator.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return str.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `str.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/generator.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | return node.generate(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.generate()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/compiler/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | mod compiler; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/compiler/compiler.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/compiler/compiler.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / return Compiler { [INFO] [stderr] 42 | | resolver: Resolver {}, [INFO] [stderr] 43 | | chunk_map: HashMap::new(), [INFO] [stderr] 44 | | options: None, [INFO] [stderr] 45 | | parser: Box::new(JsParser::new()) [INFO] [stderr] 46 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 41 | Compiler { [INFO] [stderr] 42 | resolver: Resolver {}, [INFO] [stderr] 43 | chunk_map: HashMap::new(), [INFO] [stderr] 44 | options: None, [INFO] [stderr] 45 | parser: Box::new(JsParser::new()) [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return match self.emit(&options) { [INFO] [stderr] 86 | | Ok(result) => { [INFO] [stderr] 87 | | Ok(CompileResult { [INFO] [stderr] 88 | | overall_duration: start.elapsed(), [INFO] [stderr] ... | [INFO] [stderr] 94 | | Err(err) => Err(err) [INFO] [stderr] 95 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | match self.emit(&options) { [INFO] [stderr] 86 | Ok(result) => { [INFO] [stderr] 87 | Ok(CompileResult { [INFO] [stderr] 88 | overall_duration: start.elapsed(), [INFO] [stderr] 89 | parse_duration, [INFO] [stderr] 90 | emit_duration: result.duration, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / return match parse_result { [INFO] [stderr] 112 | | Ok(result) => { [INFO] [stderr] 113 | | let required_chunks = self.resolver.resolve(&mut chunk, &result.requires).unwrap(); [INFO] [stderr] 114 | | chunk.syntax_tree = Some(result.syntax_tree.clone()); [INFO] [stderr] ... | [INFO] [stderr] 130 | | Err(err) => Err(err), [INFO] [stderr] 131 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 111 | match parse_result { [INFO] [stderr] 112 | Ok(result) => { [INFO] [stderr] 113 | let required_chunks = self.resolver.resolve(&mut chunk, &result.requires).unwrap(); [INFO] [stderr] 114 | chunk.syntax_tree = Some(result.syntax_tree.clone()); [INFO] [stderr] 115 | [INFO] [stderr] 116 | for required_location in &required_chunks { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return Ok(EmitResult { count, duration: start.elapsed() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(EmitResult { count, duration: start.elapsed() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return out_path; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `out_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/options.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return Ok(options); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(options)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/options.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/options.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / return match json::parse(&contents) { [INFO] [stderr] 119 | | Ok(config) => Ok(config), [INFO] [stderr] 120 | | Err(_) => Err(ConfigError::JsonInvalid) [INFO] [stderr] 121 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 118 | match json::parse(&contents) { [INFO] [stderr] 119 | Ok(config) => Ok(config), [INFO] [stderr] 120 | Err(_) => Err(ConfigError::JsonInvalid) [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/transform/plugin.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return self.get_name().eq(other.get_name()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_name().eq(other.get_name())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/transform/plugin_manager.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / return PluginManager { [INFO] [stderr] 11 | | plugins: Vec::new(), [INFO] [stderr] 12 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | PluginManager { [INFO] [stderr] 11 | plugins: Vec::new(), [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/source_location.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return SourceLocation { start, end }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SourceLocation { start, end }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/source_location.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return SourceLocation::new(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SourceLocation::new(0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/node.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return NodeTrivia { prefix: String::new(), suffix: String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeTrivia { prefix: String::new(), suffix: String::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/syntax_tree.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return SyntaxTree { base_node: Box::new(base_node) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SyntaxTree { base_node: Box::new(base_node) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/syntax_tree.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return self.base_node.generate(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.base_node.generate()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Expression` [INFO] [stderr] --> src/compiler/ast/statement.rs:1:41 [INFO] [stderr] | [INFO] [stderr] 1 | use super::expression::{ExpressionNode, Expression}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/statement.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / return ImportTrivia { [INFO] [stderr] 19 | | declaration_prefix: String::new(), [INFO] [stderr] 20 | | as_prefix: String::new(), [INFO] [stderr] 21 | | from_prefix: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 24 | | quote_kind: QuoteKind::Apostrophe, [INFO] [stderr] 25 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | ImportTrivia { [INFO] [stderr] 19 | declaration_prefix: String::new(), [INFO] [stderr] 20 | as_prefix: String::new(), [INFO] [stderr] 21 | from_prefix: String::new(), [INFO] [stderr] 22 | alias_prefix: String::new(), [INFO] [stderr] 23 | source_prefix: String::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/statement.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / return StatementNode { [INFO] [stderr] 75 | | statement, [INFO] [stderr] 76 | | location: SourceLocation { start: 0, end: 0 }, [INFO] [stderr] 77 | | trivia, [INFO] [stderr] 78 | | terminator, [INFO] [stderr] 79 | | requires: Vec::new(), [INFO] [stderr] 80 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 74 | StatementNode { [INFO] [stderr] 75 | statement, [INFO] [stderr] 76 | location: SourceLocation { start: 0, end: 0 }, [INFO] [stderr] 77 | trivia, [INFO] [stderr] 78 | terminator, [INFO] [stderr] 79 | requires: Vec::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/expression.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return FunctionTrivia { [INFO] [stderr] 22 | | body_suffix: String::new(), [INFO] [stderr] 23 | | identifier_gap: String::new(), [INFO] [stderr] 24 | | parameters_gap: String::new(), [INFO] [stderr] 25 | | body_gap: String::new(), [INFO] [stderr] 26 | | parameters_padding: String::new() [INFO] [stderr] 27 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | FunctionTrivia { [INFO] [stderr] 22 | body_suffix: String::new(), [INFO] [stderr] 23 | identifier_gap: String::new(), [INFO] [stderr] 24 | parameters_gap: String::new(), [INFO] [stderr] 25 | body_gap: String::new(), [INFO] [stderr] 26 | parameters_padding: String::new() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/expression.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / return ArrowFunctionTrivia { [INFO] [stderr] 43 | | body_suffix: String::new(), [INFO] [stderr] 44 | | arrow_gap: String::new(), [INFO] [stderr] 45 | | parameters_gap: String::new(), [INFO] [stderr] 46 | | body_gap: String::new(), [INFO] [stderr] 47 | | parameters_padding: String::new() [INFO] [stderr] 48 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | ArrowFunctionTrivia { [INFO] [stderr] 43 | body_suffix: String::new(), [INFO] [stderr] 44 | arrow_gap: String::new(), [INFO] [stderr] 45 | parameters_gap: String::new(), [INFO] [stderr] 46 | body_gap: String::new(), [INFO] [stderr] 47 | parameters_padding: String::new() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/expression.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / return ExpressionNode { [INFO] [stderr] 88 | | expression, [INFO] [stderr] 89 | | location: SourceLocation { start: 0, end: 0 }, [INFO] [stderr] 90 | | trivia [INFO] [stderr] 91 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 87 | ExpressionNode { [INFO] [stderr] 88 | expression, [INFO] [stderr] 89 | location: SourceLocation { start: 0, end: 0 }, [INFO] [stderr] 90 | trivia [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/declaration.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return DeclarationTrivia { assign_prefix: String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeclarationTrivia { assign_prefix: String::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/declaration.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return DeclarationNode { name, expression, trivia }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeclarationNode { name, expression, trivia }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/declaration.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / return match self { [INFO] [stderr] 54 | | &Const => "const", [INFO] [stderr] 55 | | &Let => "let", [INFO] [stderr] 56 | | &Var => "var", [INFO] [stderr] 57 | | }.to_owned(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | match self { [INFO] [stderr] 54 | &Const => "const", [INFO] [stderr] 55 | &Let => "let", [INFO] [stderr] 56 | &Var => "var", [INFO] [stderr] 57 | }.to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/body.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / return BodyNode { [INFO] [stderr] 13 | | content [INFO] [stderr] 14 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 12 | BodyNode { [INFO] [stderr] 13 | content [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/body.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return string; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/module/dependencies.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / return Dependencies { [INFO] [stderr] 12 | | requires: Vec::new(), [INFO] [stderr] 13 | | used_by: Vec::new() [INFO] [stderr] 14 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | Dependencies { [INFO] [stderr] 12 | requires: Vec::new(), [INFO] [stderr] 13 | used_by: Vec::new() [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/module/resolver.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return Ok(new_chunks); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(new_chunks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/compiler/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/parser.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return ParserOptions { chunk, plugin_manager }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParserOptions { chunk, plugin_manager }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return ParserResult { syntax_tree,requires, duration }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParserResult { syntax_tree,requires, duration }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return Ok(ParserResult::new(tree, requires, start.elapsed())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParserResult::new(tree, requires, start.elapsed()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / return JsParser { [INFO] [stderr] 49 | | tokenizer: Tokenizer::new(), [INFO] [stderr] 50 | | requires: Vec::new(), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | JsParser { [INFO] [stderr] 49 | tokenizer: Tokenizer::new(), [INFO] [stderr] 50 | requires: Vec::new(), [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / return Ok((Expression::Function { [INFO] [stderr] 137 | | name: identifier, [INFO] [stderr] 138 | | parameters, [INFO] [stderr] 139 | | body: BodyNode::new(body), [INFO] [stderr] 140 | | trivia [INFO] [stderr] 141 | | }, Some(StatementTerminator::Block))); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 136 | Ok((Expression::Function { [INFO] [stderr] 137 | name: identifier, [INFO] [stderr] 138 | parameters, [INFO] [stderr] 139 | body: BodyNode::new(body), [INFO] [stderr] 140 | trivia [INFO] [stderr] 141 | }, Some(StatementTerminator::Block))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | return Err(ParserError::new(ParserErrorKind::Syntax, String::from("ASDasd"), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParserError::new(ParserErrorKind::Syntax, String::from("ASDasd"), SourceLocation::default()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | return Ok(Expression::Bracketed { expression: Box::new(expression) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Expression::Bracketed { expression: Box::new(expression) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | return Ok((node, terminator_option)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((node, terminator_option))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | return Ok((Expression::Call { identifier, parameters }, None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Expression::Call { identifier, parameters }, None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | return Ok((Statement::Declaration { kind: kind.clone(), declarations }, None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Statement::Declaration { kind: kind.clone(), declarations }, None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:334:9 [INFO] [stderr] | [INFO] [stderr] 334 | return Ok((Statement::Return { expression: expression_option }, terminator_option)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Statement::Return { expression: expression_option }, terminator_option))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | return Ok((Statement::Import { source: import, alias, declaration, trivia }, None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Statement::Import { source: import, alias, declaration, trivia }, None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | / return match keyword { [INFO] [stderr] 405 | | Return => { [INFO] [stderr] 406 | | self.tokenizer.pop_ignore_padding(options.chunk); [INFO] [stderr] 407 | | self.parse_return(options) [INFO] [stderr] ... | [INFO] [stderr] 417 | | _ => Err(ParserError::new(ParserErrorKind::Syntax, format!("Statement keyword '{:?}' not found.", keyword), SourceLocation::default())) [INFO] [stderr] 418 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 404 | match keyword { [INFO] [stderr] 405 | Return => { [INFO] [stderr] 406 | self.tokenizer.pop_ignore_padding(options.chunk); [INFO] [stderr] 407 | self.parse_return(options) [INFO] [stderr] 408 | } [INFO] [stderr] 409 | Declaration(kind) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:493:9 [INFO] [stderr] | [INFO] [stderr] 493 | return Ok(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/error.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return ParserError { kind, description, location }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParserError { kind, description, location }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plugins/minify_plugin.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return "internal.minify"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"internal.minify"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plugins/prettify_plugin.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return "internal.prettify"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"internal.prettify"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return TokenizerError { description: description.to_owned() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TokenizerError { description: description.to_owned() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return &self.description; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Tokenizer {}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Tokenizer {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | return Ok(Token::Operator(operator)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Operator(operator))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | return Ok(Token::BracketOpen); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BracketOpen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(Token::BracketClose); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BracketClose)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:117:17 [INFO] [stderr] | [INFO] [stderr] 117 | return Ok(Token::BraceOpen); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BraceOpen)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | return Ok(Token::BraceClose); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::BraceClose)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | return Ok(Token::Semicolon); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Semicolon)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:129:17 [INFO] [stderr] | [INFO] [stderr] 129 | return Ok(Token::Colon); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Colon)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | return Ok(token); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(token)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | return Ok(Token::Comma); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Comma)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | return Ok(Token::Literal(Literal::Number(self.read_number(chunk, start).to_owned()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Token::Literal(Literal::Number(self.read_number(chunk, start).to_owned())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:156:21 [INFO] [stderr] | [INFO] [stderr] 156 | / return match label { [INFO] [stderr] 157 | | "if" => Ok(Token::Keyword(Keyword::If)), [INFO] [stderr] 158 | | "function" => Ok(Token::Keyword(Keyword::Function)), [INFO] [stderr] 159 | | "return" => Ok(Token::Keyword(Keyword::Return)), [INFO] [stderr] ... | [INFO] [stderr] 193 | | value => Ok(Token::Identifier(value.to_owned())) [INFO] [stderr] 194 | | }; [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 156 | match label { [INFO] [stderr] 157 | "if" => Ok(Token::Keyword(Keyword::If)), [INFO] [stderr] 158 | "function" => Ok(Token::Keyword(Keyword::Function)), [INFO] [stderr] 159 | "return" => Ok(Token::Keyword(Keyword::Return)), [INFO] [stderr] 160 | "while" => Ok(Token::Keyword(Keyword::While)), [INFO] [stderr] 161 | "switch" => Ok(Token::Keyword(Keyword::Switch)), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:196:21 [INFO] [stderr] | [INFO] [stderr] 196 | return Err(TokenizerError::new("Invalid token.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TokenizerError::new("Invalid token."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | return Token::Literal(Literal::String(value,quote)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Literal(Literal::String(value,quote))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | return chunk.slice(start, chunk.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunk.slice(start, chunk.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | return (token, string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(token, string)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/tokenizer.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | return (token, string); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(token, string)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return Ok(ChunkLocation { path }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ChunkLocation { path })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | return Ok(ChunkLocation { path }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ChunkLocation { path })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return hasher.finish(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hasher.finish()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | / return Chunk { [INFO] [stderr] 59 | | name, [INFO] [stderr] 60 | | loaded:false, [INFO] [stderr] 61 | | location, [INFO] [stderr] ... | [INFO] [stderr] 65 | | dependencies: Dependencies::new() [INFO] [stderr] 66 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 58 | Chunk { [INFO] [stderr] 59 | name, [INFO] [stderr] 60 | loaded:false, [INFO] [stderr] 61 | location, [INFO] [stderr] 62 | source: String::new(), [INFO] [stderr] 63 | index: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return self.location.generate_id(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.location.generate_id()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return Ok(&self.source); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(&self.source)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | return self.char_at(self.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.char_at(self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:101:9 [INFO] [stderr] | [INFO] [stderr] 101 | return self.source.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.source.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | return self.index >= self.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.index >= self.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | return self.source.slice_unchecked(start, self.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.source.slice_unchecked(start, self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | return self.source.slice_unchecked(start, end); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.source.slice_unchecked(start, end)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return self.index; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/chunk.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return self.source.chars().nth(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.source.chars().nth(index).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/lexicon.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return ident_lookup::TABLE[char as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ident_lookup::TABLE[char as usize]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/token.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return str; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/literal.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return match *self { [INFO] [stderr] 21 | | QuoteKind::Apostrophe => "'", [INFO] [stderr] 22 | | QuoteKind::SpeechMark => "\"", [INFO] [stderr] 23 | | }.to_owned(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | match *self { [INFO] [stderr] 21 | QuoteKind::Apostrophe => "'", [INFO] [stderr] 22 | QuoteKind::SpeechMark => "\"", [INFO] [stderr] 23 | }.to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/literal.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return str; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/keyword.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return string; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/operator.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | return str.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `str.to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/generator.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | return node.generate(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `node.generate()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/compiler/mod.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | mod compiler; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude::*` [INFO] [stderr] --> src/compiler/compiler.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fs::File` [INFO] [stderr] --> src/compiler/compiler.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use std::fs::File; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / return Compiler { [INFO] [stderr] 42 | | resolver: Resolver {}, [INFO] [stderr] 43 | | chunk_map: HashMap::new(), [INFO] [stderr] 44 | | options: None, [INFO] [stderr] 45 | | parser: Box::new(JsParser::new()) [INFO] [stderr] 46 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 41 | Compiler { [INFO] [stderr] 42 | resolver: Resolver {}, [INFO] [stderr] 43 | chunk_map: HashMap::new(), [INFO] [stderr] 44 | options: None, [INFO] [stderr] 45 | parser: Box::new(JsParser::new()) [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / return match self.emit(&options) { [INFO] [stderr] 86 | | Ok(result) => { [INFO] [stderr] 87 | | Ok(CompileResult { [INFO] [stderr] 88 | | overall_duration: start.elapsed(), [INFO] [stderr] ... | [INFO] [stderr] 94 | | Err(err) => Err(err) [INFO] [stderr] 95 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 85 | match self.emit(&options) { [INFO] [stderr] 86 | Ok(result) => { [INFO] [stderr] 87 | Ok(CompileResult { [INFO] [stderr] 88 | overall_duration: start.elapsed(), [INFO] [stderr] 89 | parse_duration, [INFO] [stderr] 90 | emit_duration: result.duration, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | / return match parse_result { [INFO] [stderr] 112 | | Ok(result) => { [INFO] [stderr] 113 | | let required_chunks = self.resolver.resolve(&mut chunk, &result.requires).unwrap(); [INFO] [stderr] 114 | | chunk.syntax_tree = Some(result.syntax_tree.clone()); [INFO] [stderr] ... | [INFO] [stderr] 130 | | Err(err) => Err(err), [INFO] [stderr] 131 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 111 | match parse_result { [INFO] [stderr] 112 | Ok(result) => { [INFO] [stderr] 113 | let required_chunks = self.resolver.resolve(&mut chunk, &result.requires).unwrap(); [INFO] [stderr] 114 | chunk.syntax_tree = Some(result.syntax_tree.clone()); [INFO] [stderr] 115 | [INFO] [stderr] 116 | for required_location in &required_chunks { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | return Ok(EmitResult { count, duration: start.elapsed() }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(EmitResult { count, duration: start.elapsed() })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/compiler.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return out_path; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `out_path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/options.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return Ok(options); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(options)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/options.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/options.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | / return match json::parse(&contents) { [INFO] [stderr] 119 | | Ok(config) => Ok(config), [INFO] [stderr] 120 | | Err(_) => Err(ConfigError::JsonInvalid) [INFO] [stderr] 121 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 118 | match json::parse(&contents) { [INFO] [stderr] 119 | Ok(config) => Ok(config), [INFO] [stderr] 120 | Err(_) => Err(ConfigError::JsonInvalid) [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/transform/plugin.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return self.get_name().eq(other.get_name()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.get_name().eq(other.get_name())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/transform/plugin_manager.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | / return PluginManager { [INFO] [stderr] 11 | | plugins: Vec::new(), [INFO] [stderr] 12 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | PluginManager { [INFO] [stderr] 11 | plugins: Vec::new(), [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/source_location.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | return SourceLocation { start, end }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SourceLocation { start, end }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/source_location.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return SourceLocation::new(0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SourceLocation::new(0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/node.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return NodeTrivia { prefix: String::new(), suffix: String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `NodeTrivia { prefix: String::new(), suffix: String::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/syntax_tree.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return SyntaxTree { base_node: Box::new(base_node) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `SyntaxTree { base_node: Box::new(base_node) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/syntax_tree.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return self.base_node.generate(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.base_node.generate()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Expression` [INFO] [stderr] --> src/compiler/ast/statement.rs:1:41 [INFO] [stderr] | [INFO] [stderr] 1 | use super::expression::{ExpressionNode, Expression}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/statement.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / return ImportTrivia { [INFO] [stderr] 19 | | declaration_prefix: String::new(), [INFO] [stderr] 20 | | as_prefix: String::new(), [INFO] [stderr] 21 | | from_prefix: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 24 | | quote_kind: QuoteKind::Apostrophe, [INFO] [stderr] 25 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | ImportTrivia { [INFO] [stderr] 19 | declaration_prefix: String::new(), [INFO] [stderr] 20 | as_prefix: String::new(), [INFO] [stderr] 21 | from_prefix: String::new(), [INFO] [stderr] 22 | alias_prefix: String::new(), [INFO] [stderr] 23 | source_prefix: String::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/statement.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / return StatementNode { [INFO] [stderr] 75 | | statement, [INFO] [stderr] 76 | | location: SourceLocation { start: 0, end: 0 }, [INFO] [stderr] 77 | | trivia, [INFO] [stderr] 78 | | terminator, [INFO] [stderr] 79 | | requires: Vec::new(), [INFO] [stderr] 80 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 74 | StatementNode { [INFO] [stderr] 75 | statement, [INFO] [stderr] 76 | location: SourceLocation { start: 0, end: 0 }, [INFO] [stderr] 77 | trivia, [INFO] [stderr] 78 | terminator, [INFO] [stderr] 79 | requires: Vec::new(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/expression.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return FunctionTrivia { [INFO] [stderr] 22 | | body_suffix: String::new(), [INFO] [stderr] 23 | | identifier_gap: String::new(), [INFO] [stderr] 24 | | parameters_gap: String::new(), [INFO] [stderr] 25 | | body_gap: String::new(), [INFO] [stderr] 26 | | parameters_padding: String::new() [INFO] [stderr] 27 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | FunctionTrivia { [INFO] [stderr] 22 | body_suffix: String::new(), [INFO] [stderr] 23 | identifier_gap: String::new(), [INFO] [stderr] 24 | parameters_gap: String::new(), [INFO] [stderr] 25 | body_gap: String::new(), [INFO] [stderr] 26 | parameters_padding: String::new() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/expression.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / return ArrowFunctionTrivia { [INFO] [stderr] 43 | | body_suffix: String::new(), [INFO] [stderr] 44 | | arrow_gap: String::new(), [INFO] [stderr] 45 | | parameters_gap: String::new(), [INFO] [stderr] 46 | | body_gap: String::new(), [INFO] [stderr] 47 | | parameters_padding: String::new() [INFO] [stderr] 48 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | ArrowFunctionTrivia { [INFO] [stderr] 43 | body_suffix: String::new(), [INFO] [stderr] 44 | arrow_gap: String::new(), [INFO] [stderr] 45 | parameters_gap: String::new(), [INFO] [stderr] 46 | body_gap: String::new(), [INFO] [stderr] 47 | parameters_padding: String::new() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/expression.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / return ExpressionNode { [INFO] [stderr] 88 | | expression, [INFO] [stderr] 89 | | location: SourceLocation { start: 0, end: 0 }, [INFO] [stderr] 90 | | trivia [INFO] [stderr] 91 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 87 | ExpressionNode { [INFO] [stderr] 88 | expression, [INFO] [stderr] 89 | location: SourceLocation { start: 0, end: 0 }, [INFO] [stderr] 90 | trivia [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/declaration.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return DeclarationTrivia { assign_prefix: String::new() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeclarationTrivia { assign_prefix: String::new() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/declaration.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return DeclarationNode { name, expression, trivia }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `DeclarationNode { name, expression, trivia }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/declaration.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / return match self { [INFO] [stderr] 54 | | &Const => "const", [INFO] [stderr] 55 | | &Let => "let", [INFO] [stderr] 56 | | &Var => "var", [INFO] [stderr] 57 | | }.to_owned(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | match self { [INFO] [stderr] 54 | &Const => "const", [INFO] [stderr] 55 | &Let => "let", [INFO] [stderr] 56 | &Var => "var", [INFO] [stderr] 57 | }.to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/body.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / return BodyNode { [INFO] [stderr] 13 | | content [INFO] [stderr] 14 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 12 | BodyNode { [INFO] [stderr] 13 | content [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/ast/body.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return string; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/module/dependencies.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | / return Dependencies { [INFO] [stderr] 12 | | requires: Vec::new(), [INFO] [stderr] 13 | | used_by: Vec::new() [INFO] [stderr] 14 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 11 | Dependencies { [INFO] [stderr] 12 | requires: Vec::new(), [INFO] [stderr] 13 | used_by: Vec::new() [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/module/resolver.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | return Ok(new_chunks); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(new_chunks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/compiler/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | mod parser; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/parser.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return ParserOptions { chunk, plugin_manager }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParserOptions { chunk, plugin_manager }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return ParserResult { syntax_tree,requires, duration }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParserResult { syntax_tree,requires, duration }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return Ok(ParserResult::new(tree, requires, start.elapsed())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(ParserResult::new(tree, requires, start.elapsed()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / return JsParser { [INFO] [stderr] 49 | | tokenizer: Tokenizer::new(), [INFO] [stderr] 50 | | requires: Vec::new(), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | JsParser { [INFO] [stderr] 49 | tokenizer: Tokenizer::new(), [INFO] [stderr] 50 | requires: Vec::new(), [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / return Ok((Expression::Function { [INFO] [stderr] 137 | | name: identifier, [INFO] [stderr] 138 | | parameters, [INFO] [stderr] 139 | | body: BodyNode::new(body), [INFO] [stderr] 140 | | trivia [INFO] [stderr] 141 | | }, Some(StatementTerminator::Block))); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 136 | Ok((Expression::Function { [INFO] [stderr] 137 | name: identifier, [INFO] [stderr] 138 | parameters, [INFO] [stderr] 139 | body: BodyNode::new(body), [INFO] [stderr] 140 | trivia [INFO] [stderr] 141 | }, Some(StatementTerminator::Block))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | return Err(ParserError::new(ParserErrorKind::Syntax, String::from("ASDasd"), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParserError::new(ParserErrorKind::Syntax, String::from("ASDasd"), SourceLocation::default()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | return Ok(Expression::Bracketed { expression: Box::new(expression) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Expression::Bracketed { expression: Box::new(expression) })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:247:9 [INFO] [stderr] | [INFO] [stderr] 247 | return Ok((node, terminator_option)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((node, terminator_option))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:272:9 [INFO] [stderr] | [INFO] [stderr] 272 | return Ok((Expression::Call { identifier, parameters }, None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Expression::Call { identifier, parameters }, None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:320:9 [INFO] [stderr] | [INFO] [stderr] 320 | return Ok((Statement::Declaration { kind: kind.clone(), declarations }, None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Statement::Declaration { kind: kind.clone(), declarations }, None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:334:9 [INFO] [stderr] | [INFO] [stderr] 334 | return Ok((Statement::Return { expression: expression_option }, terminator_option)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Statement::Return { expression: expression_option }, terminator_option))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:398:9 [INFO] [stderr] | [INFO] [stderr] 398 | return Ok((Statement::Import { source: import, alias, declaration, trivia }, None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((Statement::Import { source: import, alias, declaration, trivia }, None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | / return match keyword { [INFO] [stderr] 405 | | Return => { [INFO] [stderr] 406 | | self.tokenizer.pop_ignore_padding(options.chunk); [INFO] [stderr] 407 | | self.parse_return(options) [INFO] [stderr] ... | [INFO] [stderr] 417 | | _ => Err(ParserError::new(ParserErrorKind::Syntax, format!("Statement keyword '{:?}' not found.", keyword), SourceLocation::default())) [INFO] [stderr] 418 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 404 | match keyword { [INFO] [stderr] 405 | Return => { [INFO] [stderr] 406 | self.tokenizer.pop_ignore_padding(options.chunk); [INFO] [stderr] 407 | self.parse_return(options) [INFO] [stderr] 408 | } [INFO] [stderr] 409 | Declaration(kind) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/js_parser.rs:493:9 [INFO] [stderr] | [INFO] [stderr] 493 | return Ok(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/compiler/parser/error.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return ParserError { kind, description, location }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParserError { kind, description, location }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plugins/minify_plugin.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return "internal.minify"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"internal.minify"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plugins/prettify_plugin.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return "internal.prettify"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"internal.prettify"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/compiler/chunk.rs:123:32 [INFO] [stderr] | [INFO] [stderr] 123 | return self.source.slice_unchecked(start, self.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/compiler/chunk.rs:129:32 [INFO] [stderr] | [INFO] [stderr] 129 | return self.source.slice_unchecked(start, end); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/compiler/chunk.rs:123:32 [INFO] [stderr] | [INFO] [stderr] 123 | return self.source.slice_unchecked(start, self.index); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'core::str::::slice_unchecked': use `get_unchecked(begin..end)` instead [INFO] [stderr] --> src/compiler/chunk.rs:129:32 [INFO] [stderr] | [INFO] [stderr] 129 | return self.source.slice_unchecked(start, end); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::rayon::prelude` [INFO] [stderr] --> src/compiler/compiler.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use self::rayon::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/compiler/tokenizer.rs:281:28 [INFO] [stderr] | [INFO] [stderr] 281 | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/compiler/tokenizer.rs:326:28 [INFO] [stderr] | [INFO] [stderr] 326 | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/compiler/compiler.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | Err(err) => {}, [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `prefix` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | let (token, prefix) = self.tokenizer.peek_ignore_padding(options.chunk); [INFO] [stderr] | ^^^^^^ help: consider using `_prefix` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arrow_prefix` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | let (possible_fat_arrow, arrow_prefix) = self.tokenizer.peek_ignore_padding(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_arrow_prefix` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `identifier_prefix` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:281:36 [INFO] [stderr] | [INFO] [stderr] 281 | let (identifier_token, identifier_prefix) = self.tokenizer.peek_ignore_whitespace(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_identifier_prefix` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pad` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:467:49 [INFO] [stderr] | [INFO] [stderr] 467 | let (next_proper_token, pad) = self.tokenizer.peek_ignore_whitespace(options.chunk); [INFO] [stderr] | ^^^ help: consider using `_pad` instead [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::rayon::prelude` [INFO] [stderr] --> src/compiler/compiler.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use self::rayon::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/compiler/ast/statement.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut string = match self.statement { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/compiler/tokenizer.rs:281:28 [INFO] [stderr] | [INFO] [stderr] 281 | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/compiler/tokenizer.rs:326:28 [INFO] [stderr] | [INFO] [stderr] 326 | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `err` [INFO] [stderr] --> src/compiler/compiler.rs:157:29 [INFO] [stderr] | [INFO] [stderr] 157 | Err(err) => {}, [INFO] [stderr] | ^^^ help: consider using `_err` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `prefix` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | let (token, prefix) = self.tokenizer.peek_ignore_padding(options.chunk); [INFO] [stderr] | ^^^^^^ help: consider using `_prefix` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `arrow_prefix` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | let (possible_fat_arrow, arrow_prefix) = self.tokenizer.peek_ignore_padding(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider using `_arrow_prefix` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `identifier_prefix` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:281:36 [INFO] [stderr] | [INFO] [stderr] 281 | let (identifier_token, identifier_prefix) = self.tokenizer.peek_ignore_whitespace(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using `_identifier_prefix` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pad` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:467:49 [INFO] [stderr] | [INFO] [stderr] 467 | let (next_proper_token, pad) = self.tokenizer.peek_ignore_whitespace(options.chunk); [INFO] [stderr] | ^^^ help: consider using `_pad` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_syntax_tree` [INFO] [stderr] --> src/compiler/chunk.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn update_syntax_tree(&mut self, tree : SyntaxTree) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Binary` [INFO] [stderr] --> src/compiler/literal.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Binary(u64), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Default` [INFO] [stderr] --> src/compiler/keyword.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Default, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Finally` [INFO] [stderr] --> src/compiler/keyword.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Finally, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `With` [INFO] [stderr] --> src/compiler/keyword.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | With, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `As` [INFO] [stderr] --> src/compiler/keyword.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | As, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `New` [INFO] [stderr] --> src/compiler/operator.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | New, // new … [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Increment` [INFO] [stderr] --> src/compiler/operator.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Increment, // ++ … | … ++ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Decrement` [INFO] [stderr] --> src/compiler/operator.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Decrement, // -- … | … -- [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LogicalNot` [INFO] [stderr] --> src/compiler/operator.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | LogicalNot, // ! … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitwiseNot` [INFO] [stderr] --> src/compiler/operator.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | BitwiseNot, // ~ … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Typeof` [INFO] [stderr] --> src/compiler/operator.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Typeof, // typeof … [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Void` [INFO] [stderr] --> src/compiler/operator.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Void, // void … [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Delete` [INFO] [stderr] --> src/compiler/operator.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Delete, // delete … [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Multiplication` [INFO] [stderr] --> src/compiler/operator.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Multiplication, // … * … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Division` [INFO] [stderr] --> src/compiler/operator.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Division, // … / … [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Remainder` [INFO] [stderr] --> src/compiler/operator.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Remainder, // … % … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Exponent` [INFO] [stderr] --> src/compiler/operator.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Exponent, // … ** … [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Addition` [INFO] [stderr] --> src/compiler/operator.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Addition, // … + … | + … [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Subtraction` [INFO] [stderr] --> src/compiler/operator.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Subtraction, // … - … | - … [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitShiftLeft` [INFO] [stderr] --> src/compiler/operator.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | BitShiftLeft, // … << … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitShiftRight` [INFO] [stderr] --> src/compiler/operator.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | BitShiftRight, // … >> … [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UBitShiftRight` [INFO] [stderr] --> src/compiler/operator.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | UBitShiftRight, // … >>> … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lesser` [INFO] [stderr] --> src/compiler/operator.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Lesser, // … < … [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LesserEquals` [INFO] [stderr] --> src/compiler/operator.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | LesserEquals, // … <= … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Greater` [INFO] [stderr] --> src/compiler/operator.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Greater, // … > … [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GreaterEquals` [INFO] [stderr] --> src/compiler/operator.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | GreaterEquals, // … >= … [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `InstanceOf` [INFO] [stderr] --> src/compiler/operator.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | InstanceOf, // … instanceof … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `In` [INFO] [stderr] --> src/compiler/operator.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | In, // … in … [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StrictInequality` [INFO] [stderr] --> src/compiler/operator.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | StrictInequality, // … !== … [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Inequality` [INFO] [stderr] --> src/compiler/operator.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | Inequality, // … != … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitwiseAnd` [INFO] [stderr] --> src/compiler/operator.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | BitwiseAnd, // … & … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitwiseXor` [INFO] [stderr] --> src/compiler/operator.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | BitwiseXor, // … ^ … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitwiseOr` [INFO] [stderr] --> src/compiler/operator.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | BitwiseOr, // … | … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LogicalAnd` [INFO] [stderr] --> src/compiler/operator.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | LogicalAnd, // … && … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LogicalOr` [INFO] [stderr] --> src/compiler/operator.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | LogicalOr, // … || … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Conditional` [INFO] [stderr] --> src/compiler/operator.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | Conditional, // … ? … : … [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AddAssign` [INFO] [stderr] --> src/compiler/operator.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | AddAssign, // … += … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SubtractAssign` [INFO] [stderr] --> src/compiler/operator.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | SubtractAssign, // … -= … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExponentAssign` [INFO] [stderr] --> src/compiler/operator.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | ExponentAssign, // … **= … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MultiplyAssign` [INFO] [stderr] --> src/compiler/operator.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | MultiplyAssign, // … *= … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DivideAssign` [INFO] [stderr] --> src/compiler/operator.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | DivideAssign, // … /= … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RemainderAssign` [INFO] [stderr] --> src/compiler/operator.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | RemainderAssign, // … %= … [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BSLAssign` [INFO] [stderr] --> src/compiler/operator.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | BSLAssign, // … <<= … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BSRAssign` [INFO] [stderr] --> src/compiler/operator.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | BSRAssign, // … >>= … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UBSRAssign` [INFO] [stderr] --> src/compiler/operator.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | UBSRAssign, // … >>>= … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitAndAssign` [INFO] [stderr] --> src/compiler/operator.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | BitAndAssign, // … &= … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitXorAssign` [INFO] [stderr] --> src/compiler/operator.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | BitXorAssign, // … ^= … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitOrAssign` [INFO] [stderr] --> src/compiler/operator.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | BitOrAssign, // … |= … [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Spread` [INFO] [stderr] --> src/compiler/operator.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | Spread, // ... … [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `options` [INFO] [stderr] --> src/compiler/compiler.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | options: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ParserError` [INFO] [stderr] --> src/compiler/error.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | ParserError(ParserError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EmitChunk` [INFO] [stderr] --> src/compiler/transform/plugin.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | EmitChunk(&'a mut Chunk), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_plugin` [INFO] [stderr] --> src/compiler/transform/plugin_manager.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn add_plugin(&mut self, plugin: T) where T: Plugin + 'static { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Multiple` [INFO] [stderr] --> src/compiler/ast/statement.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Multiple(Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/compiler/ast/expression.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn default() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Void` [INFO] [stderr] --> src/compiler/ast/expression.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | Void, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `This` [INFO] [stderr] --> src/compiler/ast/expression.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | This, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowFunction` [INFO] [stderr] --> src/compiler/ast/expression.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / ArrowFunction { [INFO] [stderr] 66 | | parameters: Vec, [INFO] [stderr] 67 | | body: BodyNode, [INFO] [stderr] 68 | | trivia: ArrowFunctionTrivia [INFO] [stderr] 69 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `MinifyPlugin` [INFO] [stderr] --> src/plugins/minify_plugin.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct MinifyPlugin {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `PrettifyPlugin` [INFO] [stderr] --> src/plugins/prettify_plugin.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct PrettifyPlugin {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:264:21 [INFO] [stderr] | [INFO] [stderr] 264 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/tokenizer.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | / loop { [INFO] [stderr] 280 | | match self.peek_token(chunk).unwrap() { [INFO] [stderr] 281 | | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] 282 | | _ => break, [INFO] [stderr] 283 | | }; [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________^ help: try: `while let Whitespace(count) = self.peek_token(chunk).unwrap() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | / match self.peek_token(chunk).unwrap() { [INFO] [stderr] 281 | | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] 282 | | _ => break, [INFO] [stderr] 283 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:304:21 [INFO] [stderr] | [INFO] [stderr] 304 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:308:21 [INFO] [stderr] | [INFO] [stderr] 308 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | / match self.peek_token(chunk).unwrap() { [INFO] [stderr] 326 | | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] 327 | | Newline => self.pop_token(chunk), [INFO] [stderr] 328 | | _ => break, [INFO] [stderr] 329 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/compiler/token.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | fn to_string<'a>(&self) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/compiler/ast/statement.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | let mut string = match self.statement { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compiler/compiler.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if options.entries.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `options.entries.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/compiler.rs:102:66 [INFO] [stderr] | [INFO] [stderr] 102 | return Err(ParserError::new(ParserErrorKind::Syntax, format!("Chunk already exists"), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Chunk already exists".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/compiler.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | chunk.load_source(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve` doesn't need a mutable reference [INFO] [stderr] --> src/compiler/compiler.rs:113:61 [INFO] [stderr] | [INFO] [stderr] 113 | let required_chunks = self.resolver.resolve(&mut chunk, &result.requires).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/compiler.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | self.compile_chunk(&required_location, plugin_manager); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compiler/compiler.rs:122:62 [INFO] [stderr] | [INFO] [stderr] 122 | required_chunk.dependencies.used_by.push(id.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compiler/compiler.rs:123:54 [INFO] [stderr] | [INFO] [stderr] 123 | chunk.dependencies.requires.push(required_id.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `required_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/compiler.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / match chunk.syntax_tree { [INFO] [stderr] 148 | | Some(ref node) => { [INFO] [stderr] 149 | | let src = generator.generate(node); [INFO] [stderr] 150 | | [INFO] [stderr] ... | [INFO] [stderr] 160 | | None => {} [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 147 | if let Some(ref node) = chunk.syntax_tree { [INFO] [stderr] 148 | let src = generator.generate(node); [INFO] [stderr] 149 | [INFO] [stderr] 150 | match fs::OpenOptions::new().create(true).write(true).open(out_path) { [INFO] [stderr] 151 | Ok(ref file) => { [INFO] [stderr] 152 | let mut buf = BufWriter::new(file); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/compiler.rs:154:29 [INFO] [stderr] | [INFO] [stderr] 154 | buf.write_all(src.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/compiler.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / loop { [INFO] [stderr] 179 | | match file_path.components().nth(i) { [INFO] [stderr] 180 | | Some(item) => { [INFO] [stderr] 181 | | out_path.push(item.as_os_str()); [INFO] [stderr] ... | [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(item) = file_path.components().nth(i) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/error.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &InvalidConfig(ref config_err) => match config_err { [INFO] [stderr] 19 | | &FileNotFound(ref path) => format!(" File not found at path {}", path), [INFO] [stderr] 20 | | &JsonInvalid => " Invalid json contents".to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | &NoEntries => format!("{}", " No entries defined") [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | InvalidConfig(ref config_err) => match config_err { [INFO] [stderr] 19 | &FileNotFound(ref path) => format!(" File not found at path {}", path), [INFO] [stderr] 20 | &JsonInvalid => " Invalid json contents".to_owned(), [INFO] [stderr] 21 | &FileContentsInvalid => " File contents are invalid".to_owned(), [INFO] [stderr] 22 | &InvalidConfigOption(ref option, ref reason) => format!(" Invalid config option '{}': {}", option, reason), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/error.rs:18:47 [INFO] [stderr] | [INFO] [stderr] 18 | &InvalidConfig(ref config_err) => match config_err { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 19 | | &FileNotFound(ref path) => format!(" File not found at path {}", path), [INFO] [stderr] 20 | | &JsonInvalid => " Invalid json contents".to_owned(), [INFO] [stderr] 21 | | &FileContentsInvalid => " File contents are invalid".to_owned(), [INFO] [stderr] 22 | | &InvalidConfigOption(ref option, ref reason) => format!(" Invalid config option '{}': {}", option, reason), [INFO] [stderr] 23 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | &InvalidConfig(ref config_err) => match *config_err { [INFO] [stderr] 19 | FileNotFound(ref path) => format!(" File not found at path {}", path), [INFO] [stderr] 20 | JsonInvalid => " Invalid json contents".to_owned(), [INFO] [stderr] 21 | FileContentsInvalid => " File contents are invalid".to_owned(), [INFO] [stderr] 22 | InvalidConfigOption(ref option, ref reason) => format!(" Invalid config option '{}': {}", option, reason), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/error.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | &NoEntries => format!("{}", " No entries defined") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" No entries defined".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/compiler/options.rs:81:57 [INFO] [stderr] | [INFO] [stderr] 81 | for item in out_element.as_str().unwrap().split("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/transform/plugin_manager.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | plugin.handle(&mut pass); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/compiler/ast/statement.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / Return { [INFO] [stderr] 46 | | expression: Option [INFO] [stderr] 47 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 46 | expression: Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `update_syntax_tree` [INFO] [stderr] --> src/compiler/chunk.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn update_syntax_tree(&mut self, tree : SyntaxTree) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Binary` [INFO] [stderr] --> src/compiler/literal.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Binary(u64), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Default` [INFO] [stderr] --> src/compiler/keyword.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Default, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Finally` [INFO] [stderr] --> src/compiler/keyword.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Finally, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `With` [INFO] [stderr] --> src/compiler/keyword.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | With, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `As` [INFO] [stderr] --> src/compiler/keyword.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | As, [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `New` [INFO] [stderr] --> src/compiler/operator.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | New, // new … [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Increment` [INFO] [stderr] --> src/compiler/operator.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Increment, // ++ … | … ++ [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Decrement` [INFO] [stderr] --> src/compiler/operator.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Decrement, // -- … | … -- [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LogicalNot` [INFO] [stderr] --> src/compiler/operator.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | LogicalNot, // ! … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `declarations` [INFO] [stderr] --> src/compiler/ast/statement.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0..declarations.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 91 | for (i, ) in declarations.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitwiseNot` [INFO] [stderr] --> src/compiler/operator.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | BitwiseNot, // ~ … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Typeof` [INFO] [stderr] --> src/compiler/operator.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Typeof, // typeof … [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Void` [INFO] [stderr] --> src/compiler/operator.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | Void, // void … [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Delete` [INFO] [stderr] --> src/compiler/operator.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | Delete, // delete … [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/ast/statement.rs:102:37 [INFO] [stderr] | [INFO] [stderr] 102 | format!("return{}", match expression { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 103 | | &Some(ref value) => value.generate(), [INFO] [stderr] 104 | | &None => "".to_owned() [INFO] [stderr] 105 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 102 | format!("return{}", match *expression { [INFO] [stderr] 103 | Some(ref value) => value.generate(), [INFO] [stderr] 104 | None => "".to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Multiplication` [INFO] [stderr] --> src/compiler/operator.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | Multiplication, // … * … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Division` [INFO] [stderr] --> src/compiler/operator.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | Division, // … / … [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/ast/statement.rs:108:42 [INFO] [stderr] | [INFO] [stderr] 108 | let declaration_string = match declaration { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 109 | | &ImportDeclaration::All => String::from("*"), [INFO] [stderr] 110 | | &ImportDeclaration::Single(ref name) => name.to_owned(), [INFO] [stderr] 111 | | &ImportDeclaration::Multiple(ref names) => names.join(",") [INFO] [stderr] 112 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 108 | let declaration_string = match *declaration { [INFO] [stderr] 109 | ImportDeclaration::All => String::from("*"), [INFO] [stderr] 110 | ImportDeclaration::Single(ref name) => name.to_owned(), [INFO] [stderr] 111 | ImportDeclaration::Multiple(ref names) => names.join(",") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/ast/statement.rs:113:36 [INFO] [stderr] | [INFO] [stderr] 113 | let alias_string = match alias { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 114 | | &Some(ref name) => { [INFO] [stderr] 115 | | format!("{}as{}{}", trivia.as_prefix, trivia.alias_prefix, name) [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | &None => String::new(), [INFO] [stderr] 118 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 113 | let alias_string = match *alias { [INFO] [stderr] 114 | Some(ref name) => { [INFO] [stderr] 115 | format!("{}as{}{}", trivia.as_prefix, trivia.alias_prefix, name) [INFO] [stderr] 116 | } [INFO] [stderr] 117 | None => String::new(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Remainder` [INFO] [stderr] --> src/compiler/operator.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Remainder, // … % … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Exponent` [INFO] [stderr] --> src/compiler/operator.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | Exponent, // … ** … [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Addition` [INFO] [stderr] --> src/compiler/operator.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | Addition, // … + … | + … [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Subtraction` [INFO] [stderr] --> src/compiler/operator.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Subtraction, // … - … | - … [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitShiftLeft` [INFO] [stderr] --> src/compiler/operator.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | BitShiftLeft, // … << … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitShiftRight` [INFO] [stderr] --> src/compiler/operator.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | BitShiftRight, // … >> … [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UBitShiftRight` [INFO] [stderr] --> src/compiler/operator.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | UBitShiftRight, // … >>> … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Lesser` [INFO] [stderr] --> src/compiler/operator.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Lesser, // … < … [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LesserEquals` [INFO] [stderr] --> src/compiler/operator.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | LesserEquals, // … <= … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Greater` [INFO] [stderr] --> src/compiler/operator.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | Greater, // … > … [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `GreaterEquals` [INFO] [stderr] --> src/compiler/operator.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | GreaterEquals, // … >= … [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `InstanceOf` [INFO] [stderr] --> src/compiler/operator.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | InstanceOf, // … instanceof … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `In` [INFO] [stderr] --> src/compiler/operator.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | In, // … in … [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StrictInequality` [INFO] [stderr] --> src/compiler/operator.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | StrictInequality, // … !== … [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Inequality` [INFO] [stderr] --> src/compiler/operator.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | Inequality, // … != … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitwiseAnd` [INFO] [stderr] --> src/compiler/operator.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | BitwiseAnd, // … & … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitwiseXor` [INFO] [stderr] --> src/compiler/operator.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | BitwiseXor, // … ^ … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitwiseOr` [INFO] [stderr] --> src/compiler/operator.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | BitwiseOr, // … | … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LogicalAnd` [INFO] [stderr] --> src/compiler/operator.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | LogicalAnd, // … && … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LogicalOr` [INFO] [stderr] --> src/compiler/operator.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | LogicalOr, // … || … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Conditional` [INFO] [stderr] --> src/compiler/operator.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | Conditional, // … ? … : … [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `AddAssign` [INFO] [stderr] --> src/compiler/operator.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | AddAssign, // … += … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SubtractAssign` [INFO] [stderr] --> src/compiler/operator.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | SubtractAssign, // … -= … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExponentAssign` [INFO] [stderr] --> src/compiler/operator.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | ExponentAssign, // … **= … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `MultiplyAssign` [INFO] [stderr] --> src/compiler/operator.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | MultiplyAssign, // … *= … [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `DivideAssign` [INFO] [stderr] --> src/compiler/operator.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | DivideAssign, // … /= … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RemainderAssign` [INFO] [stderr] --> src/compiler/operator.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | RemainderAssign, // … %= … [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BSLAssign` [INFO] [stderr] --> src/compiler/operator.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | BSLAssign, // … <<= … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BSRAssign` [INFO] [stderr] --> src/compiler/operator.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | BSRAssign, // … >>= … [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `UBSRAssign` [INFO] [stderr] --> src/compiler/operator.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | UBSRAssign, // … >>>= … [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitAndAssign` [INFO] [stderr] --> src/compiler/operator.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | BitAndAssign, // … &= … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitXorAssign` [INFO] [stderr] --> src/compiler/operator.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | BitXorAssign, // … ^= … [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BitOrAssign` [INFO] [stderr] --> src/compiler/operator.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | BitOrAssign, // … |= … [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Spread` [INFO] [stderr] --> src/compiler/operator.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | Spread, // ... … [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `options` [INFO] [stderr] --> src/compiler/compiler.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | options: Option, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ParserError` [INFO] [stderr] --> src/compiler/error.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | ParserError(ParserError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `EmitChunk` [INFO] [stderr] --> src/compiler/transform/plugin.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | EmitChunk(&'a mut Chunk), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `add_plugin` [INFO] [stderr] --> src/compiler/transform/plugin_manager.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn add_plugin(&mut self, plugin: T) where T: Plugin + 'static { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Multiple` [INFO] [stderr] --> src/compiler/ast/statement.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Multiple(Vec) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `default` [INFO] [stderr] --> src/compiler/ast/expression.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn default() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Void` [INFO] [stderr] --> src/compiler/ast/expression.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | Void, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `This` [INFO] [stderr] --> src/compiler/ast/expression.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | This, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ArrowFunction` [INFO] [stderr] --> src/compiler/ast/expression.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | / ArrowFunction { [INFO] [stderr] 66 | | parameters: Vec, [INFO] [stderr] 67 | | body: BodyNode, [INFO] [stderr] 68 | | trivia: ArrowFunctionTrivia [INFO] [stderr] 69 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `MinifyPlugin` [INFO] [stderr] --> src/plugins/minify_plugin.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct MinifyPlugin {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `PrettifyPlugin` [INFO] [stderr] --> src/plugins/prettify_plugin.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub struct PrettifyPlugin {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:264:21 [INFO] [stderr] | [INFO] [stderr] 264 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/tokenizer.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | / loop { [INFO] [stderr] 280 | | match self.peek_token(chunk).unwrap() { [INFO] [stderr] 281 | | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] 282 | | _ => break, [INFO] [stderr] 283 | | }; [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________^ help: try: `while let Whitespace(count) = self.peek_token(chunk).unwrap() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | / match self.peek_token(chunk).unwrap() { [INFO] [stderr] 281 | | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] 282 | | _ => break, [INFO] [stderr] 283 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:304:21 [INFO] [stderr] | [INFO] [stderr] 304 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:308:21 [INFO] [stderr] | [INFO] [stderr] 308 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | / match self.peek_token(chunk).unwrap() { [INFO] [stderr] 326 | | Whitespace(count) => self.pop_token(chunk), [INFO] [stderr] 327 | | Newline => self.pop_token(chunk), [INFO] [stderr] 328 | | _ => break, [INFO] [stderr] 329 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/tokenizer.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | self.pop_token(chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `parameters` [INFO] [stderr] --> src/compiler/ast/expression.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | for i in 0..parameters.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 103 | for (i, ) in parameters.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `parameters` [INFO] [stderr] --> src/compiler/ast/expression.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | for i in 0..parameters.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 117 | for (i, ) in parameters.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/ast/declaration.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match self.expression { [INFO] [stderr] 39 | | Some(ref expression_node) => { [INFO] [stderr] 40 | | expression += " ="; [INFO] [stderr] 41 | | expression += &expression_node.generate(); [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | None => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(ref expression_node) = self.expression { [INFO] [stderr] 39 | expression += " ="; [INFO] [stderr] 40 | expression += &expression_node.generate(); [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/ast/declaration.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 54 | | &Const => "const", [INFO] [stderr] 55 | | &Let => "let", [INFO] [stderr] 56 | | &Var => "var", [INFO] [stderr] 57 | | }.to_owned(); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | return match *self { [INFO] [stderr] 54 | Const => "const", [INFO] [stderr] 55 | Let => "let", [INFO] [stderr] 56 | Var => "var", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compiler/module/resolver.rs:13:52 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn resolve(&self, chunk: &Chunk, requires: &Vec) -> Result, ResolverError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/compiler/token.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | fn to_string<'a>(&self) -> String { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:72:71 [INFO] [stderr] | [INFO] [stderr] 72 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Function params must begin with bracket."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Function params must begin with bracket.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compiler/parser/js_parser.rs:82:24 [INFO] [stderr] | [INFO] [stderr] 82 | if parameters.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parameters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:86:74 [INFO] [stderr] | [INFO] [stderr] 86 | return Err(ParserError::new(ParserErrorKind::Syntax, format!("Unexpected end of params."), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unexpected end of params.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:101:83 [INFO] [stderr] | [INFO] [stderr] 101 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Function params contains invalid token."), SourceLocation::default())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Function params contains invalid token.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:104:75 [INFO] [stderr] | [INFO] [stderr] 104 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid function."), SourceLocation::default())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid function.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:111:66 [INFO] [stderr] | [INFO] [stderr] 111 | return Err(ParserError::new(ParserErrorKind::Syntax, format!("Function body must begin with brace."), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Function body must begin with brace.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compiler/compiler.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if options.entries.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `options.entries.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/compiler.rs:102:66 [INFO] [stderr] | [INFO] [stderr] 102 | return Err(ParserError::new(ParserErrorKind::Syntax, format!("Chunk already exists"), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Chunk already exists".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/compiler.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | chunk.load_source(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: The function/method `resolve` doesn't need a mutable reference [INFO] [stderr] --> src/compiler/compiler.rs:113:61 [INFO] [stderr] | [INFO] [stderr] 113 | let required_chunks = self.resolver.resolve(&mut chunk, &result.requires).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/compiler.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | self.compile_chunk(&required_location, plugin_manager); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compiler/compiler.rs:122:62 [INFO] [stderr] | [INFO] [stderr] 122 | required_chunk.dependencies.used_by.push(id.clone()); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/compiler/compiler.rs:123:54 [INFO] [stderr] | [INFO] [stderr] 123 | chunk.dependencies.requires.push(required_id.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `required_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/compiler.rs:147:13 [INFO] [stderr] | [INFO] [stderr] 147 | / match chunk.syntax_tree { [INFO] [stderr] 148 | | Some(ref node) => { [INFO] [stderr] 149 | | let src = generator.generate(node); [INFO] [stderr] 150 | | [INFO] [stderr] ... | [INFO] [stderr] 160 | | None => {} [INFO] [stderr] 161 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | / match token { [INFO] [stderr] 268 | | Token::BracketClose => self.tokenizer.pop_token(options.chunk), [INFO] [stderr] 269 | | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Call not closed with bracket"), SourceLocation::default())) [INFO] [stderr] 270 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 147 | if let Some(ref node) = chunk.syntax_tree { [INFO] [stderr] 148 | let src = generator.generate(node); [INFO] [stderr] 149 | [INFO] [stderr] 150 | match fs::OpenOptions::new().create(true).write(true).open(out_path) { [INFO] [stderr] 151 | Ok(ref file) => { [INFO] [stderr] 152 | let mut buf = BufWriter::new(file); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:269:71 [INFO] [stderr] | [INFO] [stderr] 269 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Call not closed with bracket"), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Call not closed with bracket".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/compiler.rs:154:29 [INFO] [stderr] | [INFO] [stderr] 154 | buf.write_all(src.as_bytes()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/compiler/compiler.rs:178:9 [INFO] [stderr] | [INFO] [stderr] 178 | / loop { [INFO] [stderr] 179 | | match file_path.components().nth(i) { [INFO] [stderr] 180 | | Some(item) => { [INFO] [stderr] 181 | | out_path.push(item.as_os_str()); [INFO] [stderr] ... | [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(item) = file_path.components().nth(i) { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/error.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &InvalidConfig(ref config_err) => match config_err { [INFO] [stderr] 19 | | &FileNotFound(ref path) => format!(" File not found at path {}", path), [INFO] [stderr] 20 | | &JsonInvalid => " Invalid json contents".to_owned(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | &NoEntries => format!("{}", " No entries defined") [INFO] [stderr] 27 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:299:83 [INFO] [stderr] | [INFO] [stderr] 299 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Declaration is not valid."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Declaration is not valid.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | InvalidConfig(ref config_err) => match config_err { [INFO] [stderr] 19 | &FileNotFound(ref path) => format!(" File not found at path {}", path), [INFO] [stderr] 20 | &JsonInvalid => " Invalid json contents".to_owned(), [INFO] [stderr] 21 | &FileContentsInvalid => " File contents are invalid".to_owned(), [INFO] [stderr] 22 | &InvalidConfigOption(ref option, ref reason) => format!(" Invalid config option '{}': {}", option, reason), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/error.rs:18:47 [INFO] [stderr] | [INFO] [stderr] 18 | &InvalidConfig(ref config_err) => match config_err { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 19 | | &FileNotFound(ref path) => format!(" File not found at path {}", path), [INFO] [stderr] 20 | | &JsonInvalid => " Invalid json contents".to_owned(), [INFO] [stderr] 21 | | &FileContentsInvalid => " File contents are invalid".to_owned(), [INFO] [stderr] 22 | | &InvalidConfigOption(ref option, ref reason) => format!(" Invalid config option '{}': {}", option, reason), [INFO] [stderr] 23 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | &InvalidConfig(ref config_err) => match *config_err { [INFO] [stderr] 19 | FileNotFound(ref path) => format!(" File not found at path {}", path), [INFO] [stderr] 20 | JsonInvalid => " Invalid json contents".to_owned(), [INFO] [stderr] 21 | FileContentsInvalid => " File contents are invalid".to_owned(), [INFO] [stderr] 22 | InvalidConfigOption(ref option, ref reason) => format!(" Invalid config option '{}': {}", option, reason), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/error.rs:26:27 [INFO] [stderr] | [INFO] [stderr] 26 | &NoEntries => format!("{}", " No entries defined") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `" No entries defined".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:316:75 [INFO] [stderr] | [INFO] [stderr] 316 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Declaration does not end correctly."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Declaration does not end correctly.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | / match self.parse_expression(options) { [INFO] [stderr] 327 | | Ok((expression_node, terminator)) => { [INFO] [stderr] 328 | | expression_option = Some(expression_node); [INFO] [stderr] 329 | | terminator_option = terminator; [INFO] [stderr] 330 | | } [INFO] [stderr] 331 | | Err(_) => {} [INFO] [stderr] 332 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 326 | if let Ok((expression_node, terminator)) = self.parse_expression(options) { [INFO] [stderr] 327 | expression_option = Some(expression_node); [INFO] [stderr] 328 | terminator_option = terminator; [INFO] [stderr] 329 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/compiler/parser/js_parser.rs:345:17 [INFO] [stderr] | [INFO] [stderr] 345 | / match name == "*" { [INFO] [stderr] 346 | | true => ImportDeclaration::All, [INFO] [stderr] 347 | | false => ImportDeclaration::Single(name.to_owned()) [INFO] [stderr] 348 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if name == "*" { ImportDeclaration::All } else { ImportDeclaration::Single(name.to_owned()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/compiler/options.rs:81:57 [INFO] [stderr] | [INFO] [stderr] 81 | for item in out_element.as_str().unwrap().split("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/transform/plugin_manager.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | plugin.handle(&mut pass); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:350:71 [INFO] [stderr] | [INFO] [stderr] 350 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:363:78 [INFO] [stderr] | [INFO] [stderr] 363 | return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:372:83 [INFO] [stderr] | [INFO] [stderr] 372 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:386:83 [INFO] [stderr] | [INFO] [stderr] 386 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:390:75 [INFO] [stderr] | [INFO] [stderr] 390 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/compiler/ast/statement.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / Return { [INFO] [stderr] 46 | | expression: Option [INFO] [stderr] 47 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] --> src/compiler/parser/js_parser.rs:433:17 [INFO] [stderr] | [INFO] [stderr] 433 | / match self.parse_keyword(options, keyword) { [INFO] [stderr] 434 | | Ok((statement, terminator)) => { [INFO] [stderr] 435 | | statement_option = Some(statement); [INFO] [stderr] 436 | | terminator_option = terminator; [INFO] [stderr] 437 | | } [INFO] [stderr] 438 | | Err(_) => {} [INFO] [stderr] 439 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 433 | if let Ok((statement, terminator)) = self.parse_keyword(options, keyword) { [INFO] [stderr] 434 | statement_option = Some(statement); [INFO] [stderr] 435 | terminator_option = terminator; [INFO] [stderr] 436 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] 46 | expression: Box> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:463:25 [INFO] [stderr] | [INFO] [stderr] 463 | self.tokenizer.pop_token(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:466:25 [INFO] [stderr] | [INFO] [stderr] 466 | self.tokenizer.pop_token(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:478:25 [INFO] [stderr] | [INFO] [stderr] 478 | self.tokenizer.pop_token(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:483:25 [INFO] [stderr] | [INFO] [stderr] 483 | self.tokenizer.pop_token(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/minify_plugin.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match pass { [INFO] [stderr] 19 | | &mut StatementNodeEmit(ref mut statement_node) => { [INFO] [stderr] 20 | | statement_node.trivia.prefix = String::from(""); [INFO] [stderr] 21 | | statement_node.trivia.suffix = String::from(""); [INFO] [stderr] ... | [INFO] [stderr] 42 | | _ => Ok("".to_owned()) [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *pass { [INFO] [stderr] 19 | StatementNodeEmit(ref mut statement_node) => { [INFO] [stderr] 20 | statement_node.trivia.prefix = String::from(""); [INFO] [stderr] 21 | statement_node.trivia.suffix = String::from(""); [INFO] [stderr] 22 | if statement_node.terminator == StatementTerminator::Newline { [INFO] [stderr] 23 | statement_node.terminator = StatementTerminator::Semicolon; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `declarations` [INFO] [stderr] --> src/compiler/ast/statement.rs:91:26 [INFO] [stderr] | [INFO] [stderr] 91 | for i in 0..declarations.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 91 | for (i, ) in declarations.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/ast/statement.rs:102:37 [INFO] [stderr] | [INFO] [stderr] 102 | format!("return{}", match expression { [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 103 | | &Some(ref value) => value.generate(), [INFO] [stderr] 104 | | &None => "".to_owned() [INFO] [stderr] 105 | | }) [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 102 | format!("return{}", match *expression { [INFO] [stderr] 103 | Some(ref value) => value.generate(), [INFO] [stderr] 104 | None => "".to_owned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/ast/statement.rs:108:42 [INFO] [stderr] | [INFO] [stderr] 108 | let declaration_string = match declaration { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 109 | | &ImportDeclaration::All => String::from("*"), [INFO] [stderr] 110 | | &ImportDeclaration::Single(ref name) => name.to_owned(), [INFO] [stderr] 111 | | &ImportDeclaration::Multiple(ref names) => names.join(",") [INFO] [stderr] 112 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 108 | let declaration_string = match *declaration { [INFO] [stderr] 109 | ImportDeclaration::All => String::from("*"), [INFO] [stderr] 110 | ImportDeclaration::Single(ref name) => name.to_owned(), [INFO] [stderr] 111 | ImportDeclaration::Multiple(ref names) => names.join(",") [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/ast/statement.rs:113:36 [INFO] [stderr] | [INFO] [stderr] 113 | let alias_string = match alias { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 114 | | &Some(ref name) => { [INFO] [stderr] 115 | | format!("{}as{}{}", trivia.as_prefix, trivia.alias_prefix, name) [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | &None => String::new(), [INFO] [stderr] 118 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 113 | let alias_string = match *alias { [INFO] [stderr] 114 | Some(ref name) => { [INFO] [stderr] 115 | format!("{}as{}{}", trivia.as_prefix, trivia.alias_prefix, name) [INFO] [stderr] 116 | } [INFO] [stderr] 117 | None => String::new(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/prettify_plugin.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match pass { [INFO] [stderr] 19 | | &mut StatementNodeEmit(ref mut statement_node) => { [INFO] [stderr] 20 | | statement_node.trivia.prefix = String::from("\n"); [INFO] [stderr] 21 | | if statement_node.terminator == StatementTerminator::Newline { [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => Ok("".to_owned()) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *pass { [INFO] [stderr] 19 | StatementNodeEmit(ref mut statement_node) => { [INFO] [stderr] 20 | statement_node.trivia.prefix = String::from("\n"); [INFO] [stderr] 21 | if statement_node.terminator == StatementTerminator::Newline { [INFO] [stderr] 22 | statement_node.terminator = StatementTerminator::Semicolon; [INFO] [stderr] 23 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `parameters` [INFO] [stderr] --> src/compiler/ast/expression.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | for i in 0..parameters.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 103 | for (i, ) in parameters.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | time += duration.subsec_nanos() as f64 / 1_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `parameters` [INFO] [stderr] --> src/compiler/ast/expression.rs:117:26 [INFO] [stderr] | [INFO] [stderr] 117 | for i in 0..parameters.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 117 | for (i, ) in parameters.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/ast/declaration.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match self.expression { [INFO] [stderr] 39 | | Some(ref expression_node) => { [INFO] [stderr] 40 | | expression += " ="; [INFO] [stderr] 41 | | expression += &expression_node.generate(); [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | None => {} [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(ref expression_node) = self.expression { [INFO] [stderr] 39 | expression += " ="; [INFO] [stderr] 40 | expression += &expression_node.generate(); [INFO] [stderr] 41 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/compiler/ast/declaration.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | return match self { [INFO] [stderr] | ________________^ [INFO] [stderr] 54 | | &Const => "const", [INFO] [stderr] 55 | | &Let => "let", [INFO] [stderr] 56 | | &Var => "var", [INFO] [stderr] 57 | | }.to_owned(); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | return match *self { [INFO] [stderr] 54 | Const => "const", [INFO] [stderr] 55 | Let => "let", [INFO] [stderr] 56 | Var => "var", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/compiler/module/resolver.rs:13:52 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn resolve(&self, chunk: &Chunk, requires: &Vec) -> Result, ResolverError> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:72:71 [INFO] [stderr] | [INFO] [stderr] 72 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Function params must begin with bracket."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Function params must begin with bracket.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compiler/parser/js_parser.rs:82:24 [INFO] [stderr] | [INFO] [stderr] 82 | if parameters.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parameters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:86:74 [INFO] [stderr] | [INFO] [stderr] 86 | return Err(ParserError::new(ParserErrorKind::Syntax, format!("Unexpected end of params."), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Unexpected end of params.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:101:83 [INFO] [stderr] | [INFO] [stderr] 101 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Function params contains invalid token."), SourceLocation::default())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Function params contains invalid token.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:104:75 [INFO] [stderr] | [INFO] [stderr] 104 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid function."), SourceLocation::default())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid function.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:111:66 [INFO] [stderr] | [INFO] [stderr] 111 | return Err(ParserError::new(ParserErrorKind::Syntax, format!("Function body must begin with brace."), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Function body must begin with brace.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | / match token { [INFO] [stderr] 268 | | Token::BracketClose => self.tokenizer.pop_token(options.chunk), [INFO] [stderr] 269 | | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Call not closed with bracket"), SourceLocation::default())) [INFO] [stderr] 270 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:269:71 [INFO] [stderr] | [INFO] [stderr] 269 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Call not closed with bracket"), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Call not closed with bracket".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:299:83 [INFO] [stderr] | [INFO] [stderr] 299 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Declaration is not valid."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Declaration is not valid.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:316:75 [INFO] [stderr] | [INFO] [stderr] 316 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Declaration does not end correctly."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Declaration does not end correctly.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | / match self.parse_expression(options) { [INFO] [stderr] 327 | | Ok((expression_node, terminator)) => { [INFO] [stderr] 328 | | expression_option = Some(expression_node); [INFO] [stderr] 329 | | terminator_option = terminator; [INFO] [stderr] 330 | | } [INFO] [stderr] 331 | | Err(_) => {} [INFO] [stderr] 332 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 326 | if let Ok((expression_node, terminator)) = self.parse_expression(options) { [INFO] [stderr] 327 | expression_option = Some(expression_node); [INFO] [stderr] 328 | terminator_option = terminator; [INFO] [stderr] 329 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/compiler/parser/js_parser.rs:345:17 [INFO] [stderr] | [INFO] [stderr] 345 | / match name == "*" { [INFO] [stderr] 346 | | true => ImportDeclaration::All, [INFO] [stderr] 347 | | false => ImportDeclaration::Single(name.to_owned()) [INFO] [stderr] 348 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if name == "*" { ImportDeclaration::All } else { ImportDeclaration::Single(name.to_owned()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:350:71 [INFO] [stderr] | [INFO] [stderr] 350 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:363:78 [INFO] [stderr] | [INFO] [stderr] 363 | return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:372:83 [INFO] [stderr] | [INFO] [stderr] 372 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:386:83 [INFO] [stderr] | [INFO] [stderr] 386 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:390:75 [INFO] [stderr] | [INFO] [stderr] 390 | _ => return Err(ParserError::new(ParserErrorKind::Syntax, format!("Invalid import."), SourceLocation::default())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid import.".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/compiler/parser/js_parser.rs:433:17 [INFO] [stderr] | [INFO] [stderr] 433 | / match self.parse_keyword(options, keyword) { [INFO] [stderr] 434 | | Ok((statement, terminator)) => { [INFO] [stderr] 435 | | statement_option = Some(statement); [INFO] [stderr] 436 | | terminator_option = terminator; [INFO] [stderr] 437 | | } [INFO] [stderr] 438 | | Err(_) => {} [INFO] [stderr] 439 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 433 | if let Ok((statement, terminator)) = self.parse_keyword(options, keyword) { [INFO] [stderr] 434 | statement_option = Some(statement); [INFO] [stderr] 435 | terminator_option = terminator; [INFO] [stderr] 436 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:463:25 [INFO] [stderr] | [INFO] [stderr] 463 | self.tokenizer.pop_token(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:466:25 [INFO] [stderr] | [INFO] [stderr] 466 | self.tokenizer.pop_token(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:478:25 [INFO] [stderr] | [INFO] [stderr] 478 | self.tokenizer.pop_token(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/compiler/parser/js_parser.rs:483:25 [INFO] [stderr] | [INFO] [stderr] 483 | self.tokenizer.pop_token(options.chunk); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/minify_plugin.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match pass { [INFO] [stderr] 19 | | &mut StatementNodeEmit(ref mut statement_node) => { [INFO] [stderr] 20 | | statement_node.trivia.prefix = String::from(""); [INFO] [stderr] 21 | | statement_node.trivia.suffix = String::from(""); [INFO] [stderr] ... | [INFO] [stderr] 42 | | _ => Ok("".to_owned()) [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *pass { [INFO] [stderr] 19 | StatementNodeEmit(ref mut statement_node) => { [INFO] [stderr] 20 | statement_node.trivia.prefix = String::from(""); [INFO] [stderr] 21 | statement_node.trivia.suffix = String::from(""); [INFO] [stderr] 22 | if statement_node.terminator == StatementTerminator::Newline { [INFO] [stderr] 23 | statement_node.terminator = StatementTerminator::Semicolon; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/plugins/prettify_plugin.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / match pass { [INFO] [stderr] 19 | | &mut StatementNodeEmit(ref mut statement_node) => { [INFO] [stderr] 20 | | statement_node.trivia.prefix = String::from("\n"); [INFO] [stderr] 21 | | if statement_node.terminator == StatementTerminator::Newline { [INFO] [stderr] ... | [INFO] [stderr] 41 | | _ => Ok("".to_owned()) [INFO] [stderr] 42 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 18 | match *pass { [INFO] [stderr] 19 | StatementNodeEmit(ref mut statement_node) => { [INFO] [stderr] 20 | statement_node.trivia.prefix = String::from("\n"); [INFO] [stderr] 21 | if statement_node.terminator == StatementTerminator::Newline { [INFO] [stderr] 22 | statement_node.terminator = StatementTerminator::Semicolon; [INFO] [stderr] 23 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | time += duration.subsec_nanos() as f64 / 1_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.18s [INFO] running `"docker" "inspect" "03424b8db35de976b891f64501106a402409d9ba9fa69ec00ad8bc7deec11619"` [INFO] running `"docker" "rm" "-f" "03424b8db35de976b891f64501106a402409d9ba9fa69ec00ad8bc7deec11619"` [INFO] [stdout] 03424b8db35de976b891f64501106a402409d9ba9fa69ec00ad8bc7deec11619