[INFO] updating cached repository CastellaFactory/esma-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CastellaFactory/esma-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CastellaFactory/esma-rs" "work/ex/clippy-test-run/sources/stable/gh/CastellaFactory/esma-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CastellaFactory/esma-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CastellaFactory/esma-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CastellaFactory/esma-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CastellaFactory/esma-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b6e78c13333d6187b74a42f8e9ff3ae67d63300e [INFO] sha for GitHub repo CastellaFactory/esma-rs: b6e78c13333d6187b74a42f8e9ff3ae67d63300e [INFO] validating manifest of CastellaFactory/esma-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CastellaFactory/esma-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CastellaFactory/esma-rs [INFO] finished frobbing CastellaFactory/esma-rs [INFO] frobbed toml for CastellaFactory/esma-rs written to work/ex/clippy-test-run/sources/stable/gh/CastellaFactory/esma-rs/Cargo.toml [INFO] started frobbing CastellaFactory/esma-rs [INFO] finished frobbing CastellaFactory/esma-rs [INFO] frobbed toml for CastellaFactory/esma-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CastellaFactory/esma-rs/Cargo.toml [INFO] crate CastellaFactory/esma-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CastellaFactory/esma-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CastellaFactory/esma-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d963ffaaaea8db328dc2983fd9557d6944d48a661fbd59db2b9993cccebf9f7 [INFO] running `"docker" "start" "-a" "1d963ffaaaea8db328dc2983fd9557d6944d48a661fbd59db2b9993cccebf9f7"` [INFO] [stderr] Checking serde v1.0.2 [INFO] [stderr] Checking clap v2.24.0 [INFO] [stderr] Checking toml v0.4.0 [INFO] [stderr] Checking esma-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grep.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grep.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused imports: `App`, `Arg` [INFO] [stderr] --> src/main.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | use clap::{Arg, App}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Mmap`, `Protection` [INFO] [stderr] --> src/runner.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | use memmap::{Mmap, Protection}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Arg` [INFO] [stderr] --> src/options.rs:1:12 [INFO] [stderr] | [INFO] [stderr] 1 | use clap::{Arg, App}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `App`, `Arg` [INFO] [stderr] --> src/main.rs:8:12 [INFO] [stderr] | [INFO] [stderr] 8 | use clap::{Arg, App}; [INFO] [stderr] | ^^^ ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Mmap`, `Protection` [INFO] [stderr] --> src/runner.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | use memmap::{Mmap, Protection}; [INFO] [stderr] | ^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Arg` [INFO] [stderr] --> src/options.rs:1:12 [INFO] [stderr] | [INFO] [stderr] 1 | use clap::{Arg, App}; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `opts` [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let opts = Options::parse(); [INFO] [stderr] | ^^^^ help: consider using `_opts` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `timer` [INFO] [stderr] --> src/runner.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let timer = Timer::new(algo); [INFO] [stderr] | ^^^^^ help: consider using `_timer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/options.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | let m = App::new("esma-rs") [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start` [INFO] [stderr] --> src/grep.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn start(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algorithm/memchr.rs:27:49 [INFO] [stderr] | [INFO] [stderr] 27 | i = match memchr(self.pat[0], &text[i..end + 1]) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `i..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algorithm/epsm.rs:26:49 [INFO] [stderr] | [INFO] [stderr] 26 | i = match memchr(self.pat[0], &text[i..end + 1]) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `i..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/runner.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | let pat = "Therefore ".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Therefore "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timer.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | (d.as_secs() * 1_000) + (d.subsec_nanos() / 1_000_000) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(d.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/timer.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | (d.as_secs() * 1_000) + (d.subsec_nanos() / 1_000_000) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `d.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] warning: unused variable: `opts` [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let opts = Options::parse(); [INFO] [stderr] | ^^^^ help: consider using `_opts` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `timer` [INFO] [stderr] --> src/runner.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | let timer = Timer::new(algo); [INFO] [stderr] | ^^^^^ help: consider using `_timer` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/options.rs:9:13 [INFO] [stderr] | [INFO] [stderr] 9 | let m = App::new("esma-rs") [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `start` [INFO] [stderr] --> src/grep.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn start(&self) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algorithm/memchr.rs:27:49 [INFO] [stderr] | [INFO] [stderr] 27 | i = match memchr(self.pat[0], &text[i..end + 1]) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `i..=end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/algorithm/epsm.rs:26:49 [INFO] [stderr] | [INFO] [stderr] 26 | i = match memchr(self.pat[0], &text[i..end + 1]) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `i..=end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/runner.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | let pat = "Therefore ".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"Therefore "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/timer.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | (d.as_secs() * 1_000) + (d.subsec_nanos() / 1_000_000) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(d.subsec_nanos() / 1_000_000)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Calling `subsec_millis()` is more concise than this calculation [INFO] [stderr] --> src/timer.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | (d.as_secs() * 1_000) + (d.subsec_nanos() / 1_000_000) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `d.subsec_millis()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::duration_subsec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duration_subsec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.23s [INFO] running `"docker" "inspect" "1d963ffaaaea8db328dc2983fd9557d6944d48a661fbd59db2b9993cccebf9f7"` [INFO] running `"docker" "rm" "-f" "1d963ffaaaea8db328dc2983fd9557d6944d48a661fbd59db2b9993cccebf9f7"` [INFO] [stdout] 1d963ffaaaea8db328dc2983fd9557d6944d48a661fbd59db2b9993cccebf9f7