[INFO] updating cached repository Caspinol/radius-debug [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Caspinol/radius-debug [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Caspinol/radius-debug" "work/ex/clippy-test-run/sources/stable/gh/Caspinol/radius-debug"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Caspinol/radius-debug'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Caspinol/radius-debug" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Caspinol/radius-debug"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Caspinol/radius-debug'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5ffd2ac025e6ab41559b3c5661e289d5f58fa77b [INFO] sha for GitHub repo Caspinol/radius-debug: 5ffd2ac025e6ab41559b3c5661e289d5f58fa77b [INFO] validating manifest of Caspinol/radius-debug on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Caspinol/radius-debug on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Caspinol/radius-debug [INFO] finished frobbing Caspinol/radius-debug [INFO] frobbed toml for Caspinol/radius-debug written to work/ex/clippy-test-run/sources/stable/gh/Caspinol/radius-debug/Cargo.toml [INFO] started frobbing Caspinol/radius-debug [INFO] finished frobbing Caspinol/radius-debug [INFO] frobbed toml for Caspinol/radius-debug written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Caspinol/radius-debug/Cargo.toml [INFO] crate Caspinol/radius-debug has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Caspinol/radius-debug against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Caspinol/radius-debug:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a557e603c407cfa9e58a97decd783fb08dfeb0f46cc13c0a32d9246c0411590 [INFO] running `"docker" "start" "-a" "8a557e603c407cfa9e58a97decd783fb08dfeb0f46cc13c0a32d9246c0411590"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking radius-debug v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if packet_with_user_pattern.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!packet_with_user_pattern.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:101:11 [INFO] [stderr] | [INFO] [stderr] 101 | v.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if packet_with_user_pattern.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!packet_with_user_pattern.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/main.rs:101:11 [INFO] [stderr] | [INFO] [stderr] 101 | v.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.75s [INFO] running `"docker" "inspect" "8a557e603c407cfa9e58a97decd783fb08dfeb0f46cc13c0a32d9246c0411590"` [INFO] running `"docker" "rm" "-f" "8a557e603c407cfa9e58a97decd783fb08dfeb0f46cc13c0a32d9246c0411590"` [INFO] [stdout] 8a557e603c407cfa9e58a97decd783fb08dfeb0f46cc13c0a32d9246c0411590