[INFO] updating cached repository CarstenWalther/blockchain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CarstenWalther/blockchain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CarstenWalther/blockchain" "work/ex/clippy-test-run/sources/stable/gh/CarstenWalther/blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CarstenWalther/blockchain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CarstenWalther/blockchain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CarstenWalther/blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CarstenWalther/blockchain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b333d22aab4425a77bc8d51019e4b11d46c479c9 [INFO] sha for GitHub repo CarstenWalther/blockchain: b333d22aab4425a77bc8d51019e4b11d46c479c9 [INFO] validating manifest of CarstenWalther/blockchain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CarstenWalther/blockchain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CarstenWalther/blockchain [INFO] finished frobbing CarstenWalther/blockchain [INFO] frobbed toml for CarstenWalther/blockchain written to work/ex/clippy-test-run/sources/stable/gh/CarstenWalther/blockchain/Cargo.toml [INFO] started frobbing CarstenWalther/blockchain [INFO] finished frobbing CarstenWalther/blockchain [INFO] frobbed toml for CarstenWalther/blockchain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CarstenWalther/blockchain/Cargo.toml [INFO] crate CarstenWalther/blockchain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CarstenWalther/blockchain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CarstenWalther/blockchain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8d76c06dbaa106b21709050d6b217d3accb8983f3b71272170f6c44745262b3 [INFO] running `"docker" "start" "-a" "e8d76c06dbaa106b21709050d6b217d3accb8983f3b71272170f6c44745262b3"` [INFO] [stderr] Compiling openssl v0.9.19 [INFO] [stderr] Compiling openssl-sys v0.9.19 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking serde_bytes v0.10.2 [INFO] [stderr] Checking crypto-hash v0.3.0 [INFO] [stderr] Checking blockchain v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/block.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | None => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:29:33 [INFO] [stderr] | [INFO] [stderr] 29 | Some(last_block) => return _block.parent != last_block.hash(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_block.parent != last_block.hash()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | None => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain.rs:29:33 [INFO] [stderr] | [INFO] [stderr] 29 | Some(last_block) => return _block.parent != last_block.hash(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_block.parent != last_block.hash()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | current_time.as_secs() * 1000 + current_time.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(current_time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/block.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `arr[..32].clone_from_slice(&d[..32])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/block.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | while &self.hash()[..2] != [0; 2] { [INFO] [stderr] | -----------------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.hash()[..2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/block.rs:35:41 [INFO] [stderr] | [INFO] [stderr] 35 | current_time.as_secs() * 1000 + current_time.subsec_nanos() as u64 / 1_000_000 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(current_time.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/block.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | for i in 0..32 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `arr[..32].clone_from_slice(&d[..32])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/block.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | while &self.hash()[..2] != [0; 2] { [INFO] [stderr] | -----------------^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `self.hash()[..2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.33s [INFO] running `"docker" "inspect" "e8d76c06dbaa106b21709050d6b217d3accb8983f3b71272170f6c44745262b3"` [INFO] running `"docker" "rm" "-f" "e8d76c06dbaa106b21709050d6b217d3accb8983f3b71272170f6c44745262b3"` [INFO] [stdout] e8d76c06dbaa106b21709050d6b217d3accb8983f3b71272170f6c44745262b3