[INFO] updating cached repository Candunc/twitch-dl
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/Candunc/twitch-dl
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/Candunc/twitch-dl" "work/ex/clippy-test-run/sources/stable/gh/Candunc/twitch-dl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Candunc/twitch-dl'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/Candunc/twitch-dl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Candunc/twitch-dl"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Candunc/twitch-dl'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c4a4ed2e792a5bbc86bcad9ce39b76f7a8520607
[INFO] sha for GitHub repo Candunc/twitch-dl: c4a4ed2e792a5bbc86bcad9ce39b76f7a8520607
[INFO] validating manifest of Candunc/twitch-dl on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of Candunc/twitch-dl on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing Candunc/twitch-dl
[INFO] finished frobbing Candunc/twitch-dl
[INFO] frobbed toml for Candunc/twitch-dl written to work/ex/clippy-test-run/sources/stable/gh/Candunc/twitch-dl/Cargo.toml
[INFO] started frobbing Candunc/twitch-dl
[INFO] finished frobbing Candunc/twitch-dl
[INFO] frobbed toml for Candunc/twitch-dl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Candunc/twitch-dl/Cargo.toml
[INFO] crate Candunc/twitch-dl has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting Candunc/twitch-dl against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Candunc/twitch-dl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] db7b44f761b5c0036d4ccf06cfd990f85fabeae2b5849a18b57f37f3d7c4c274
[INFO] running `"docker" "start" "-a" "db7b44f761b5c0036d4ccf06cfd990f85fabeae2b5849a18b57f37f3d7c4c274"`
[INFO] [stderr]    Compiling futures v0.1.15
[INFO] [stderr]    Compiling num_cpus v1.6.2
[INFO] [stderr]     Checking docopt v0.7.0
[INFO] [stderr]    Compiling rayon-core v1.2.1
[INFO] [stderr]    Compiling rayon v0.7.1
[INFO] [stderr]    Compiling ring v0.11.0
[INFO] [stderr]     Checking webpki v0.14.0
[INFO] [stderr]     Checking rustls v0.9.0
[INFO] [stderr]     Checking webpki-roots v0.11.0
[INFO] [stderr]     Checking hyper-rustls v0.6.1
[INFO] [stderr]     Checking twitch-dl v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/https.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 | const CLIENT_ID: &'static str = "y7c66dozeuhufau5a1p3xs8n0axiok";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/https.rs:35:3
[INFO] [stderr]    |
[INFO] [stderr] 35 |         return buffer;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/twitch.rs:29:2
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return vec;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `vec`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/twitch.rs:48:2
[INFO] [stderr]    |
[INFO] [stderr] 48 |     return url;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/twitch.rs:92:2
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return count;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `count`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/twitch.rs:102:2
[INFO] [stderr]     |
[INFO] [stderr] 102 |     return output;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:21:15
[INFO] [stderr]    |
[INFO] [stderr] 21 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/https.rs:12:19
[INFO] [stderr]    |
[INFO] [stderr] 12 | const CLIENT_ID: &'static str = "y7c66dozeuhufau5a1p3xs8n0axiok";
[INFO] [stderr]    |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/https.rs:35:3
[INFO] [stderr]    |
[INFO] [stderr] 35 |         return buffer;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/twitch.rs:29:2
[INFO] [stderr]    |
[INFO] [stderr] 29 |     return vec;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `vec`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/twitch.rs:48:2
[INFO] [stderr]    |
[INFO] [stderr] 48 |     return url;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `url`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/twitch.rs:92:2
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return count;
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `count`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/twitch.rs:102:2
[INFO] [stderr]     |
[INFO] [stderr] 102 |     return output;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:21:15
[INFO] [stderr]    |
[INFO] [stderr] 21 | const USAGE: &'static str = "
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/https.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     if twitch == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: try simplifying it as shown: `twitch`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/twitch.rs:20:30
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let m3u8_split = data.split("\n");
[INFO] [stderr]    |                                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/twitch.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |     let mut nauth = format!("{}",auth["token"].as_string().unwrap());
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `auth["token"].as_string().unwrap().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is only used to index `invalid`.
[INFO] [stderr]   --> src/twitch.rs:99:11
[INFO] [stderr]    |
[INFO] [stderr] 99 |     for n in 0..9 {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 99 |     for <item> in &invalid {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/twitch.rs:134:31
[INFO] [stderr]     |
[INFO] [stderr] 134 |     let vod_iter = vod_raw.split("\n");
[INFO] [stderr]     |                                  ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:55:42
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let source_iter = args.arg_source.split("/");
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:58:3
[INFO] [stderr]    |
[INFO] [stderr] 58 |           match num {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 59 | |             Ok(_) => source = part,
[INFO] [stderr] 60 | |             Err(_) => { },
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Ok(_) = num { source = part }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/https.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 |     if twitch == true {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^ help: try simplifying it as shown: `twitch`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/twitch.rs:20:30
[INFO] [stderr]    |
[INFO] [stderr] 20 |     let m3u8_split = data.split("\n");
[INFO] [stderr]    |                                 ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/twitch.rs:37:18
[INFO] [stderr]    |
[INFO] [stderr] 37 |     let mut nauth = format!("{}",auth["token"].as_string().unwrap());
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `auth["token"].as_string().unwrap().to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is only used to index `invalid`.
[INFO] [stderr]   --> src/twitch.rs:99:11
[INFO] [stderr]    |
[INFO] [stderr] 99 |     for n in 0..9 {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 99 |     for <item> in &invalid {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/twitch.rs:134:31
[INFO] [stderr]     |
[INFO] [stderr] 134 |     let vod_iter = vod_raw.split("\n");
[INFO] [stderr]     |                                  ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:55:42
[INFO] [stderr]    |
[INFO] [stderr] 55 |     let source_iter = args.arg_source.split("/");
[INFO] [stderr]    |                                             ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:58:3
[INFO] [stderr]    |
[INFO] [stderr] 58 |           match num {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 59 | |             Ok(_) => source = part,
[INFO] [stderr] 60 | |             Err(_) => { },
[INFO] [stderr] 61 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Ok(_) = num { source = part }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 23.34s
[INFO] running `"docker" "inspect" "db7b44f761b5c0036d4ccf06cfd990f85fabeae2b5849a18b57f37f3d7c4c274"`
[INFO] running `"docker" "rm" "-f" "db7b44f761b5c0036d4ccf06cfd990f85fabeae2b5849a18b57f37f3d7c4c274"`
[INFO] [stdout] db7b44f761b5c0036d4ccf06cfd990f85fabeae2b5849a18b57f37f3d7c4c274