[INFO] updating cached repository CamilleDrapier/sudoku-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CamilleDrapier/sudoku-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CamilleDrapier/sudoku-rs" "work/ex/clippy-test-run/sources/stable/gh/CamilleDrapier/sudoku-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CamilleDrapier/sudoku-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CamilleDrapier/sudoku-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CamilleDrapier/sudoku-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CamilleDrapier/sudoku-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 34486daf948ab0c3d5b7486e46f0b93a47d43209 [INFO] sha for GitHub repo CamilleDrapier/sudoku-rs: 34486daf948ab0c3d5b7486e46f0b93a47d43209 [INFO] validating manifest of CamilleDrapier/sudoku-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CamilleDrapier/sudoku-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CamilleDrapier/sudoku-rs [INFO] finished frobbing CamilleDrapier/sudoku-rs [INFO] frobbed toml for CamilleDrapier/sudoku-rs written to work/ex/clippy-test-run/sources/stable/gh/CamilleDrapier/sudoku-rs/Cargo.toml [INFO] started frobbing CamilleDrapier/sudoku-rs [INFO] finished frobbing CamilleDrapier/sudoku-rs [INFO] frobbed toml for CamilleDrapier/sudoku-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CamilleDrapier/sudoku-rs/Cargo.toml [INFO] crate CamilleDrapier/sudoku-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CamilleDrapier/sudoku-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CamilleDrapier/sudoku-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3c650950ce4e531409275cf648b809e619650c878f246767c9034ffe166590c [INFO] running `"docker" "start" "-a" "c3c650950ce4e531409275cf648b809e619650c878f246767c9034ffe166590c"` [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/models/grids.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | Some(_) => number_found = number_found + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_found += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/models/grids.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | self.number_found = self.number_found + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.number_found += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/models/grids.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | r = r + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `r += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/grids.rs:81:67 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn check_impossible(&self, i: usize, j: usize, candidate: &Option) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/models/grids.rs:14:32 [INFO] [stderr] | [INFO] [stderr] 14 | Some(_) => number_found = number_found + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_found += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/models/grids.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | self.number_found = self.number_found + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.number_found += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/models/grids.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | r = r + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `r += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/grids.rs:81:67 [INFO] [stderr] | [INFO] [stderr] 81 | pub fn check_impossible(&self, i: usize, j: usize, candidate: &Option) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `Option` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.90s [INFO] running `"docker" "inspect" "c3c650950ce4e531409275cf648b809e619650c878f246767c9034ffe166590c"` [INFO] running `"docker" "rm" "-f" "c3c650950ce4e531409275cf648b809e619650c878f246767c9034ffe166590c"` [INFO] [stdout] c3c650950ce4e531409275cf648b809e619650c878f246767c9034ffe166590c