[INFO] updating cached repository CTJeffries/Fives [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CTJeffries/Fives [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CTJeffries/Fives" "work/ex/clippy-test-run/sources/stable/gh/CTJeffries/Fives"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CTJeffries/Fives'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CTJeffries/Fives" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CTJeffries/Fives"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CTJeffries/Fives'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 75f3eedb1a513167c6d1cc36c89a0edaadde09e7 [INFO] sha for GitHub repo CTJeffries/Fives: 75f3eedb1a513167c6d1cc36c89a0edaadde09e7 [INFO] validating manifest of CTJeffries/Fives on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CTJeffries/Fives on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CTJeffries/Fives [INFO] finished frobbing CTJeffries/Fives [INFO] frobbed toml for CTJeffries/Fives written to work/ex/clippy-test-run/sources/stable/gh/CTJeffries/Fives/Cargo.toml [INFO] started frobbing CTJeffries/Fives [INFO] finished frobbing CTJeffries/Fives [INFO] frobbed toml for CTJeffries/Fives written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CTJeffries/Fives/Cargo.toml [INFO] crate CTJeffries/Fives has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CTJeffries/Fives against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CTJeffries/Fives:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fc8aab3288e909f49f916b70d28867cba1ec9fde8de47da2aa518503d2fce81c [INFO] running `"docker" "start" "-a" "fc8aab3288e909f49f916b70d28867cba1ec9fde8de47da2aa518503d2fce81c"` [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking fives v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_graphics.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_graphics.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | return Some(self.cells[current_cell[1]][current_cell[0]].to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.cells[current_cell[1]][current_cell[0]].to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | return self.cells[current_cell[1]][current_cell[0]] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cells[current_cell[1]][current_cell[0]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard_graphics.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return color [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | return false [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | return Some(self.cells[current_cell[1]][current_cell[0]].to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(self.cells[current_cell[1]][current_cell[0]].to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | return self.cells[current_cell[1]][current_cell[0]] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cells[current_cell[1]][current_cell[0]]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard_graphics.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return color [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `unused` [INFO] [stderr] --> src/gameboard_graphics.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | for unused in 0..((val as f64 / 5.0).log2() as usize / 6) { [INFO] [stderr] | ^^^^^^ help: consider using `_unused` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard::Gameboard` [INFO] [stderr] --> src/gameboard.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Gameboard { [INFO] [stderr] 32 | | Gameboard { [INFO] [stderr] 33 | | cells: [[0; SIZE]; SIZE], [INFO] [stderr] 34 | | score: 0, [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_graphics::GameboardGraphicsSettings` [INFO] [stderr] --> src/gameboard_graphics.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> GameboardGraphicsSettings { [INFO] [stderr] 36 | | GameboardGraphicsSettings { [INFO] [stderr] 37 | | position: [10.0; 2], [INFO] [stderr] 38 | | length: 580.0, [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard_graphics.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/gameboard_graphics.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | / text::Text::new_color(settings.text_color, 40) [INFO] [stderr] 112 | | .draw(&number, glyphs, &c.draw_state, [INFO] [stderr] 113 | | c.transform.trans(pos[0], pos[1]), g); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/gameboard_graphics.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / text::Text::new(50).draw(&board.get_score(), glyphs, &c.draw_state, [INFO] [stderr] 120 | | c.transform.trans(20.0, settings.length + 50.0), g); [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_graphics.rs:125:45 [INFO] [stderr] | [INFO] [stderr] 125 | let x = settings.position[0] + ((i as f64) / 5.0) * settings.length; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_graphics.rs:126:45 [INFO] [stderr] | [INFO] [stderr] 126 | let y = settings.position[1] + ((i as f64) / 5.0) * settings.length; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `color`. [INFO] [stderr] --> src/gameboard_graphics.rs:145:22 [INFO] [stderr] | [INFO] [stderr] 145 | for x in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 145 | for in &mut color { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/gameboard_graphics.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | color[x] = color[x] * 0.8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color[x] *= 0.8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let ref mut glyphs = GlyphCache::new("assets/FiraSans-Regular.ttf", (), texture_settings) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | let glyphs = &mut GlyphCache::new("assets/FiraSans-Regular.ttf", (), texture_settings) [INFO] [stderr] 70 | .expect("Could not load font."); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `unused` [INFO] [stderr] --> src/gameboard_graphics.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | for unused in 0..((val as f64 / 5.0).log2() as usize / 6) { [INFO] [stderr] | ^^^^^^ help: consider using `_unused` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard::Gameboard` [INFO] [stderr] --> src/gameboard.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Gameboard { [INFO] [stderr] 32 | | Gameboard { [INFO] [stderr] 33 | | cells: [[0; SIZE]; SIZE], [INFO] [stderr] 34 | | score: 0, [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_graphics::GameboardGraphicsSettings` [INFO] [stderr] --> src/gameboard_graphics.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn new() -> GameboardGraphicsSettings { [INFO] [stderr] 36 | | GameboardGraphicsSettings { [INFO] [stderr] 37 | | position: [10.0; 2], [INFO] [stderr] 38 | | length: 580.0, [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard_graphics.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/gameboard_graphics.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | / text::Text::new_color(settings.text_color, 40) [INFO] [stderr] 112 | | .draw(&number, glyphs, &c.draw_state, [INFO] [stderr] 113 | | c.transform.trans(pos[0], pos[1]), g); [INFO] [stderr] | |____________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/gameboard_graphics.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | / text::Text::new(50).draw(&board.get_score(), glyphs, &c.draw_state, [INFO] [stderr] 120 | | c.transform.trans(20.0, settings.length + 50.0), g); [INFO] [stderr] | |__________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_graphics.rs:125:45 [INFO] [stderr] | [INFO] [stderr] 125 | let x = settings.position[0] + ((i as f64) / 5.0) * settings.length; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_graphics.rs:126:45 [INFO] [stderr] | [INFO] [stderr] 126 | let y = settings.position[1] + ((i as f64) / 5.0) * settings.length; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is only used to index `color`. [INFO] [stderr] --> src/gameboard_graphics.rs:145:22 [INFO] [stderr] | [INFO] [stderr] 145 | for x in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 145 | for in &mut color { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/gameboard_graphics.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | color[x] = color[x] * 0.8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `color[x] *= 0.8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | let ref mut glyphs = GlyphCache::new("assets/FiraSans-Regular.ttf", (), texture_settings) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 69 | let glyphs = &mut GlyphCache::new("assets/FiraSans-Regular.ttf", (), texture_settings) [INFO] [stderr] 70 | .expect("Could not load font."); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.18s [INFO] running `"docker" "inspect" "fc8aab3288e909f49f916b70d28867cba1ec9fde8de47da2aa518503d2fce81c"` [INFO] running `"docker" "rm" "-f" "fc8aab3288e909f49f916b70d28867cba1ec9fde8de47da2aa518503d2fce81c"` [INFO] [stdout] fc8aab3288e909f49f916b70d28867cba1ec9fde8de47da2aa518503d2fce81c