[INFO] updating cached repository CM-Tech/network [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CM-Tech/network [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CM-Tech/network" "work/ex/clippy-test-run/sources/stable/gh/CM-Tech/network"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CM-Tech/network'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CM-Tech/network" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CM-Tech/network"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CM-Tech/network'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6c2a7a4c05229e7b6a1b2dfa7f0d4d936d58fdc2 [INFO] sha for GitHub repo CM-Tech/network: 6c2a7a4c05229e7b6a1b2dfa7f0d4d936d58fdc2 [INFO] validating manifest of CM-Tech/network on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CM-Tech/network on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CM-Tech/network [INFO] finished frobbing CM-Tech/network [INFO] frobbed toml for CM-Tech/network written to work/ex/clippy-test-run/sources/stable/gh/CM-Tech/network/Cargo.toml [INFO] started frobbing CM-Tech/network [INFO] finished frobbing CM-Tech/network [INFO] frobbed toml for CM-Tech/network written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CM-Tech/network/Cargo.toml [INFO] crate CM-Tech/network has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CM-Tech/network against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CM-Tech/network:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9355006f63b500097487fdb25d907ee76d632cd1c352d4644c84e4cb05d17958 [INFO] running `"docker" "start" "-a" "9355006f63b500097487fdb25d907ee76d632cd1c352d4644c84e4cb05d17958"` [INFO] [stderr] Checking x11-dl v2.17.3 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking piston-gfx_texture v0.31.0 [INFO] [stderr] Checking glutin v0.10.1 [INFO] [stderr] Checking piston2d-gfx_graphics v0.48.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking piston_window v0.75.0 [INFO] [stderr] Checking network v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | fn broadcast(&mut self, msg: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | let (reader_send, reader_read): ( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 124 | | Sender<([u8; 4096], usize)>, [INFO] [stderr] 125 | | Receiver<([u8; 4096], usize)>, [INFO] [stderr] 126 | | ) = mpsc::channel(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | players.get(&local_addr).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*players.get(&local_addr).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | players.get(&local_addr).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&players[&local_addr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | fn broadcast(&mut self, msg: &Vec) { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/main.rs:123:37 [INFO] [stderr] | [INFO] [stderr] 123 | let (reader_send, reader_read): ( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 124 | | Sender<([u8; 4096], usize)>, [INFO] [stderr] 125 | | Receiver<([u8; 4096], usize)>, [INFO] [stderr] 126 | | ) = mpsc::channel(); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | players.get(&local_addr).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*players.get(&local_addr).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:188:21 [INFO] [stderr] | [INFO] [stderr] 188 | players.get(&local_addr).unwrap().clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&players[&local_addr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 31.47s [INFO] running `"docker" "inspect" "9355006f63b500097487fdb25d907ee76d632cd1c352d4644c84e4cb05d17958"` [INFO] running `"docker" "rm" "-f" "9355006f63b500097487fdb25d907ee76d632cd1c352d4644c84e4cb05d17958"` [INFO] [stdout] 9355006f63b500097487fdb25d907ee76d632cd1c352d4644c84e4cb05d17958