[INFO] updating cached repository CJStadler/cryptopals-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CJStadler/cryptopals-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CJStadler/cryptopals-rust" "work/ex/clippy-test-run/sources/stable/gh/CJStadler/cryptopals-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CJStadler/cryptopals-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CJStadler/cryptopals-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CJStadler/cryptopals-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CJStadler/cryptopals-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8d44e31283d4a4cc2200144a6a5cf4060761da55 [INFO] sha for GitHub repo CJStadler/cryptopals-rust: 8d44e31283d4a4cc2200144a6a5cf4060761da55 [INFO] validating manifest of CJStadler/cryptopals-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CJStadler/cryptopals-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CJStadler/cryptopals-rust [INFO] finished frobbing CJStadler/cryptopals-rust [INFO] frobbed toml for CJStadler/cryptopals-rust written to work/ex/clippy-test-run/sources/stable/gh/CJStadler/cryptopals-rust/Cargo.toml [INFO] started frobbing CJStadler/cryptopals-rust [INFO] finished frobbing CJStadler/cryptopals-rust [INFO] frobbed toml for CJStadler/cryptopals-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CJStadler/cryptopals-rust/Cargo.toml [INFO] crate CJStadler/cryptopals-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CJStadler/cryptopals-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CJStadler/cryptopals-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8ed026b7dfcb3e3f35774be671e90a542f3c9e7a2cb45c389692cbc3f6b0a48d [INFO] running `"docker" "start" "-a" "8ed026b7dfcb3e3f35774be671e90a542f3c9e7a2cb45c389692cbc3f6b0a48d"` [INFO] [stderr] Checking cryptopals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/challenges/six.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | keysize: keysize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `keysize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/challenges/six.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | keysize: keysize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `keysize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/challenges/six.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | normalized_distance [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/challenges/six.rs:118:31 [INFO] [stderr] | [INFO] [stderr] 118 | let normalized_distance = (total_edit_distance * precision) / keysize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/english_score.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | const CHARS_TO_CHECK: [&'static str; 9] = [" ", "e", "t", "a", "o", "i", "n", "s", "r"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/challenges/six.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | normalized_distance [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/challenges/six.rs:118:31 [INFO] [stderr] | [INFO] [stderr] 118 | let normalized_distance = (total_edit_distance * precision) / keysize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/english_score.rs:1:25 [INFO] [stderr] | [INFO] [stderr] 1 | const CHARS_TO_CHECK: [&'static str; 9] = [" ", "e", "t", "a", "o", "i", "n", "s", "r"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BYTES_PER_BLOCK` [INFO] [stderr] --> src/challenges/eight.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const BYTES_PER_BLOCK: usize = 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `find_ecb_ciphertext` [INFO] [stderr] --> src/challenges/eight.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn find_ecb_ciphertext(ciphertexts: &[Vec]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `unique_blocks_count` [INFO] [stderr] --> src/challenges/eight.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | fn unique_blocks_count(ciphertext: &[u8]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `break_into_blocks` [INFO] [stderr] --> src/challenges/eight.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | fn break_into_blocks(ciphertext: &[u8]) -> Vec<&[u8]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `repeating_key_xor_encode` [INFO] [stderr] --> src/challenges/five.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn repeating_key_xor_encode(message: &[u8], key: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_line_in_file` [INFO] [stderr] --> src/challenges/four.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn decode_line_in_file(filename: &str) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `pkcs_pad` [INFO] [stderr] --> src/challenges/nine.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn pkcs_pad(message: &[u8], block_length: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `pkcs_unpad` [INFO] [stderr] --> src/challenges/nine.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn pkcs_unpad(padded_message: &[u8]) -> &[u8] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `hex_to_base64` [INFO] [stderr] --> src/challenges/one.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn hex_to_base64(hex: &str) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_aes_128_ecb` [INFO] [stderr] --> src/challenges/seven.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn decode_aes_128_ecb(ciphertext: &[u8], key: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BEST_KEYSIZES_TO_COLLECT` [INFO] [stderr] --> src/challenges/six.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const BEST_KEYSIZES_TO_COLLECT: usize = 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MAX_KEYSIZE` [INFO] [stderr] --> src/challenges/six.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const MAX_KEYSIZE: usize = 40; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLOCKS_TO_CHECK` [INFO] [stderr] --> src/challenges/six.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | const BLOCKS_TO_CHECK: usize = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_repeating_key_xor` [INFO] [stderr] --> src/challenges/six.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn decode_repeating_key_xor(ciphertext: &[u8]) -> (Vec, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_with_keysize` [INFO] [stderr] --> src/challenges/six.rs:29:1 [INFO] [stderr] | [INFO] [stderr] 29 | fn decode_with_keysize(ciphertext: &[u8], keysize: usize) -> (Vec, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `construct_blocks` [INFO] [stderr] --> src/challenges/six.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | fn construct_blocks(ciphertext: &[u8], keysize: usize) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `find_best_keysizes` [INFO] [stderr] --> src/challenges/six.rs:60:1 [INFO] [stderr] | [INFO] [stderr] 60 | fn find_best_keysizes(ciphertext: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `distance_for_keysize` [INFO] [stderr] --> src/challenges/six.rs:105:1 [INFO] [stderr] | [INFO] [stderr] 105 | fn distance_for_keysize(ciphertext: &[u8], keysize: usize) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BYTES_PER_BLOCK` [INFO] [stderr] --> src/challenges/ten.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const BYTES_PER_BLOCK: usize = 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_cbc_128` [INFO] [stderr] --> src/challenges/ten.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn decode_cbc_128(ciphertext: &[u8], key: &[u8], iv: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `encode_cbc_128` [INFO] [stderr] --> src/challenges/ten.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn encode_cbc_128(message: &[u8], key: &[u8], iv: Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_aes_128_block` [INFO] [stderr] --> src/challenges/ten.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | fn decode_aes_128_block(cipherblock: &[u8], key: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `encode_aes_128_block` [INFO] [stderr] --> src/challenges/ten.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | fn encode_aes_128_block(message_block: &[u8], key: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_xor` [INFO] [stderr] --> src/challenges/three.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn decode_xor(encoded: &[u8]) -> (Vec, u8, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decode_with_key` [INFO] [stderr] --> src/challenges/three.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | fn decode_with_key(encoded: &[u8], key: u8) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `xor_vectors` [INFO] [stderr] --> src/challenges/two.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn xor_vectors(a: &[u8], b: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CHARS_TO_CHECK` [INFO] [stderr] --> src/english_score.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const CHARS_TO_CHECK: [&'static str; 9] = [" ", "e", "t", "a", "o", "i", "n", "s", "r"]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `CHAR_FREQUENCIES` [INFO] [stderr] --> src/english_score.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | const CHAR_FREQUENCIES: [usize; 9] = [12, 12, 9, 8, 8, 7, 7, 6, 6]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `english_score` [INFO] [stderr] --> src/english_score.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn english_score(text: &[u8]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `distance` [INFO] [stderr] --> src/hamming.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn distance(a: &[u8], b: &[u8]) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `byte_distance` [INFO] [stderr] --> src/hamming.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | fn byte_distance(a: &u8, b: &u8) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hamming.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | fn byte_distance(a: &u8, b: &u8) -> usize { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hamming.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | fn byte_distance(a: &u8, b: &u8) -> usize { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `power_of_two` [INFO] [stderr] --> src/hamming.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | let ones: u8 = power_of_two & 255; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/challenges/nine.rs:50:40 [INFO] [stderr] | [INFO] [stderr] 50 | assert_eq!(message, pkcs_unpad(&vec![1, 2, 3, 3, 3, 3])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 3, 3, 3]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/challenges/nine.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | assert_eq!(message, pkcs_unpad(&vec![1, 2, 3, 1])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/challenges/nine.rs:52:40 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(message, pkcs_unpad(&vec![1, 2, 3, 5, 5, 5, 5, 5])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[1, 2, 3, 5, 5, 5, 5, 5]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hamming.rs:11:21 [INFO] [stderr] | [INFO] [stderr] 11 | fn byte_distance(a: &u8, b: &u8) -> usize { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hamming.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | fn byte_distance(a: &u8, b: &u8) -> usize { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `power_of_two` [INFO] [stderr] --> src/hamming.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | let ones: u8 = power_of_two & 255; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.88s [INFO] running `"docker" "inspect" "8ed026b7dfcb3e3f35774be671e90a542f3c9e7a2cb45c389692cbc3f6b0a48d"` [INFO] running `"docker" "rm" "-f" "8ed026b7dfcb3e3f35774be671e90a542f3c9e7a2cb45c389692cbc3f6b0a48d"` [INFO] [stdout] 8ed026b7dfcb3e3f35774be671e90a542f3c9e7a2cb45c389692cbc3f6b0a48d