[INFO] updating cached repository CGQAQ/Rust_SnakeGame [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/CGQAQ/Rust_SnakeGame [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/CGQAQ/Rust_SnakeGame" "work/ex/clippy-test-run/sources/stable/gh/CGQAQ/Rust_SnakeGame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/CGQAQ/Rust_SnakeGame'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/CGQAQ/Rust_SnakeGame" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CGQAQ/Rust_SnakeGame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CGQAQ/Rust_SnakeGame'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 25c1ee403fe437da24cfdbb76b10e9daa4b6eb01 [INFO] sha for GitHub repo CGQAQ/Rust_SnakeGame: 25c1ee403fe437da24cfdbb76b10e9daa4b6eb01 [INFO] validating manifest of CGQAQ/Rust_SnakeGame on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of CGQAQ/Rust_SnakeGame on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing CGQAQ/Rust_SnakeGame [INFO] finished frobbing CGQAQ/Rust_SnakeGame [INFO] frobbed toml for CGQAQ/Rust_SnakeGame written to work/ex/clippy-test-run/sources/stable/gh/CGQAQ/Rust_SnakeGame/Cargo.toml [INFO] started frobbing CGQAQ/Rust_SnakeGame [INFO] finished frobbing CGQAQ/Rust_SnakeGame [INFO] frobbed toml for CGQAQ/Rust_SnakeGame written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/CGQAQ/Rust_SnakeGame/Cargo.toml [INFO] crate CGQAQ/Rust_SnakeGame has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting CGQAQ/Rust_SnakeGame against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/CGQAQ/Rust_SnakeGame:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8a628b3b46819dd1785b2722bae1a5fd0c0750b677a70b15da5552ea3fd131d3 [INFO] running `"docker" "start" "-a" "8a628b3b46819dd1785b2722bae1a5fd0c0750b677a70b15da5552ea3fd131d3"` [INFO] [stderr] Checking inflate v0.4.2 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking pistoncore-input v0.21.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking snake_game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:53 [INFO] [stderr] | [INFO] [stderr] 84 | let body_square = rectangle::square(p.x as f64, p.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:65 [INFO] [stderr] | [INFO] [stderr] 84 | let body_square = rectangle::square(p.x as f64, p.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:77 [INFO] [stderr] | [INFO] [stderr] 84 | let body_square = rectangle::square(p.x as f64, p.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(UNIT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:53 [INFO] [stderr] | [INFO] [stderr] 94 | let food_square = rectangle::square(food.x as f64, food.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(food.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:68 [INFO] [stderr] | [INFO] [stderr] 94 | let food_square = rectangle::square(food.x as f64, food.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(food.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:83 [INFO] [stderr] | [INFO] [stderr] 94 | let food_square = rectangle::square(food.x as f64, food.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(UNIT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:24 [INFO] [stderr] | [INFO] [stderr] 146 | wall.draw([0 as f64,0 as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | wall.draw([0 as f64,0 as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | wall.draw([0 as f64,0 as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:56 [INFO] [stderr] | [INFO] [stderr] 146 | wall.draw([0 as f64,0 as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:24 [INFO] [stderr] | [INFO] [stderr] 147 | wall.draw([0 as f64,(HEIGHT - THICKNESS) as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:33 [INFO] [stderr] | [INFO] [stderr] 147 | wall.draw([0 as f64,(HEIGHT - THICKNESS) as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT - THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:61 [INFO] [stderr] | [INFO] [stderr] 147 | wall.draw([0 as f64,(HEIGHT - THICKNESS) as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:75 [INFO] [stderr] | [INFO] [stderr] 147 | wall.draw([0 as f64,(HEIGHT - THICKNESS) as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | wall.draw([0 as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:33 [INFO] [stderr] | [INFO] [stderr] 148 | wall.draw([0 as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:42 [INFO] [stderr] | [INFO] [stderr] 148 | wall.draw([0 as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:60 [INFO] [stderr] | [INFO] [stderr] 148 | wall.draw([0 as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | wall.draw([(WIDTH - THICKNESS) as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WIDTH - THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:51 [INFO] [stderr] | [INFO] [stderr] 149 | wall.draw([(WIDTH - THICKNESS) as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:60 [INFO] [stderr] | [INFO] [stderr] 149 | wall.draw([(WIDTH - THICKNESS) as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:78 [INFO] [stderr] | [INFO] [stderr] 149 | wall.draw([(WIDTH - THICKNESS) as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:187:54 [INFO] [stderr] | [INFO] [stderr] 187 | }).collect::>().len() > 1 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 188 | | // println!("{:?}", body.iter().filter_map(|b| { [INFO] [stderr] 189 | | // if b.x == head.x && b.y == head.y { [INFO] [stderr] 190 | | // Some(b) [INFO] [stderr] ... | [INFO] [stderr] 197 | | true [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:176:128 [INFO] [stderr] | [INFO] [stderr] 176 | if head.x < THICKNESS || head.x > WIDTH - (THICKNESS+UNIT) || head.y < THICKNESS || head.y > HEIGHT - (THICKNESS+UNIT) { [INFO] [stderr] | ________________________________________________________________________________________________________________________________^ [INFO] [stderr] 177 | | // hit the wall [INFO] [stderr] 178 | | true [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:180:14 [INFO] [stderr] | [INFO] [stderr] 180 | else if body.iter().filter_map(|b| { [INFO] [stderr] | ______________^ [INFO] [stderr] 181 | | if b.x == head.x && b.y == head.y { [INFO] [stderr] 182 | | Some(b) [INFO] [stderr] 183 | | } [INFO] [stderr] ... | [INFO] [stderr] 201 | | false [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 180 | else body.iter().filter_map(|b| { [INFO] [stderr] 181 | if b.x == head.x && b.y == head.y { [INFO] [stderr] 182 | Some(b) [INFO] [stderr] 183 | } [INFO] [stderr] 184 | else{ [INFO] [stderr] 185 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:180:44 [INFO] [stderr] | [INFO] [stderr] 180 | else if body.iter().filter_map(|b| { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 181 | | if b.x == head.x && b.y == head.y { [INFO] [stderr] 182 | | Some(b) [INFO] [stderr] 183 | | } [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | }).collect::>().len() > 1 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/main.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | else if body.iter().filter_map(|b| { [INFO] [stderr] | _________________^ [INFO] [stderr] 181 | | if b.x == head.x && b.y == head.y { [INFO] [stderr] 182 | | Some(b) [INFO] [stderr] 183 | | } [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | }).collect::>().len() > 1 { [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | / if head.x == food.x && head.y == food.y{ [INFO] [stderr] 210 | | // println!("ate!"); [INFO] [stderr] 211 | | true [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | else { [INFO] [stderr] 214 | | false [INFO] [stderr] 215 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `head.x == food.x && head.y == food.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:230:51 [INFO] [stderr] | [INFO] [stderr] 230 | if self.dir != Direction::Down && *can_turn == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*can_turn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:236:49 [INFO] [stderr] | [INFO] [stderr] 236 | if self.dir != Direction::Up && *can_turn == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*can_turn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:242:52 [INFO] [stderr] | [INFO] [stderr] 242 | if self.dir != Direction::Right && *can_turn == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*can_turn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:248:52 [INFO] [stderr] | [INFO] [stderr] 248 | if self.dir != Direction::Left && *can_turn == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*can_turn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:352:48 [INFO] [stderr] | [INFO] [stderr] 352 | if game.state == State::Stopped && game.inited == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!game.inited` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:362:17 [INFO] [stderr] | [INFO] [stderr] 362 | game.score = game.score + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game.score += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `BASESPEED` [INFO] [stderr] --> src/main.rs:374:37 [INFO] [stderr] | [INFO] [stderr] 374 | 1 => events.set_ups(BASESPEED + 0), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `snake_game`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:53 [INFO] [stderr] | [INFO] [stderr] 84 | let body_square = rectangle::square(p.x as f64, p.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:65 [INFO] [stderr] | [INFO] [stderr] 84 | let body_square = rectangle::square(p.x as f64, p.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(p.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:84:77 [INFO] [stderr] | [INFO] [stderr] 84 | let body_square = rectangle::square(p.x as f64, p.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(UNIT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:53 [INFO] [stderr] | [INFO] [stderr] 94 | let food_square = rectangle::square(food.x as f64, food.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(food.x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:68 [INFO] [stderr] | [INFO] [stderr] 94 | let food_square = rectangle::square(food.x as f64, food.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(food.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:83 [INFO] [stderr] | [INFO] [stderr] 94 | let food_square = rectangle::square(food.x as f64, food.y as f64, UNIT as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(UNIT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:101:33 [INFO] [stderr] | [INFO] [stderr] 101 | fn update(&mut self, _args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:24 [INFO] [stderr] | [INFO] [stderr] 146 | wall.draw([0 as f64,0 as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:33 [INFO] [stderr] | [INFO] [stderr] 146 | wall.draw([0 as f64,0 as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | wall.draw([0 as f64,0 as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:146:56 [INFO] [stderr] | [INFO] [stderr] 146 | wall.draw([0 as f64,0 as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:24 [INFO] [stderr] | [INFO] [stderr] 147 | wall.draw([0 as f64,(HEIGHT - THICKNESS) as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:33 [INFO] [stderr] | [INFO] [stderr] 147 | wall.draw([0 as f64,(HEIGHT - THICKNESS) as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT - THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:61 [INFO] [stderr] | [INFO] [stderr] 147 | wall.draw([0 as f64,(HEIGHT - THICKNESS) as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:75 [INFO] [stderr] | [INFO] [stderr] 147 | wall.draw([0 as f64,(HEIGHT - THICKNESS) as f64,WIDTH as f64, THICKNESS as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:24 [INFO] [stderr] | [INFO] [stderr] 148 | wall.draw([0 as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:33 [INFO] [stderr] | [INFO] [stderr] 148 | wall.draw([0 as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:42 [INFO] [stderr] | [INFO] [stderr] 148 | wall.draw([0 as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:148:60 [INFO] [stderr] | [INFO] [stderr] 148 | wall.draw([0 as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:24 [INFO] [stderr] | [INFO] [stderr] 149 | wall.draw([(WIDTH - THICKNESS) as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(WIDTH - THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:51 [INFO] [stderr] | [INFO] [stderr] 149 | wall.draw([(WIDTH - THICKNESS) as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:60 [INFO] [stderr] | [INFO] [stderr] 149 | wall.draw([(WIDTH - THICKNESS) as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(THICKNESS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:78 [INFO] [stderr] | [INFO] [stderr] 149 | wall.draw([(WIDTH - THICKNESS) as f64,0 as f64,THICKNESS as f64, HEIGHT as f64], &c.draw_state, c.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(HEIGHT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:187:54 [INFO] [stderr] | [INFO] [stderr] 187 | }).collect::>().len() > 1 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 188 | | // println!("{:?}", body.iter().filter_map(|b| { [INFO] [stderr] 189 | | // if b.x == head.x && b.y == head.y { [INFO] [stderr] 190 | | // Some(b) [INFO] [stderr] ... | [INFO] [stderr] 197 | | true [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:176:128 [INFO] [stderr] | [INFO] [stderr] 176 | if head.x < THICKNESS || head.x > WIDTH - (THICKNESS+UNIT) || head.y < THICKNESS || head.y > HEIGHT - (THICKNESS+UNIT) { [INFO] [stderr] | ________________________________________________________________________________________________________________________________^ [INFO] [stderr] 177 | | // hit the wall [INFO] [stderr] 178 | | true [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:180:14 [INFO] [stderr] | [INFO] [stderr] 180 | else if body.iter().filter_map(|b| { [INFO] [stderr] | ______________^ [INFO] [stderr] 181 | | if b.x == head.x && b.y == head.y { [INFO] [stderr] 182 | | Some(b) [INFO] [stderr] 183 | | } [INFO] [stderr] ... | [INFO] [stderr] 201 | | false [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] help: you can reduce it to [INFO] [stderr] | [INFO] [stderr] 180 | else body.iter().filter_map(|b| { [INFO] [stderr] 181 | if b.x == head.x && b.y == head.y { [INFO] [stderr] 182 | Some(b) [INFO] [stderr] 183 | } [INFO] [stderr] 184 | else{ [INFO] [stderr] 185 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:180:44 [INFO] [stderr] | [INFO] [stderr] 180 | else if body.iter().filter_map(|b| { [INFO] [stderr] | ____________________________________________^ [INFO] [stderr] 181 | | if b.x == head.x && b.y == head.y { [INFO] [stderr] 182 | | Some(b) [INFO] [stderr] 183 | | } [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | }).collect::>().len() > 1 { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter` [INFO] [stderr] --> src/main.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | else if body.iter().filter_map(|b| { [INFO] [stderr] | _________________^ [INFO] [stderr] 181 | | if b.x == head.x && b.y == head.y { [INFO] [stderr] 182 | | Some(b) [INFO] [stderr] 183 | | } [INFO] [stderr] ... | [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | }).collect::>().len() > 1 { [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_filter_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | / if head.x == food.x && head.y == food.y{ [INFO] [stderr] 210 | | // println!("ate!"); [INFO] [stderr] 211 | | true [INFO] [stderr] 212 | | } [INFO] [stderr] 213 | | else { [INFO] [stderr] 214 | | false [INFO] [stderr] 215 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `head.x == food.x && head.y == food.y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:230:51 [INFO] [stderr] | [INFO] [stderr] 230 | if self.dir != Direction::Down && *can_turn == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*can_turn` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:236:49 [INFO] [stderr] | [INFO] [stderr] 236 | if self.dir != Direction::Up && *can_turn == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*can_turn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:242:52 [INFO] [stderr] | [INFO] [stderr] 242 | if self.dir != Direction::Right && *can_turn == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*can_turn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:248:52 [INFO] [stderr] | [INFO] [stderr] 248 | if self.dir != Direction::Left && *can_turn == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `*can_turn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:352:48 [INFO] [stderr] | [INFO] [stderr] 352 | if game.state == State::Stopped && game.inited == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!game.inited` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:362:17 [INFO] [stderr] | [INFO] [stderr] 362 | game.score = game.score + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `game.score += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `BASESPEED` [INFO] [stderr] --> src/main.rs:374:37 [INFO] [stderr] | [INFO] [stderr] 374 | 1 => events.set_ups(BASESPEED + 0), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `snake_game`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8a628b3b46819dd1785b2722bae1a5fd0c0750b677a70b15da5552ea3fd131d3"` [INFO] running `"docker" "rm" "-f" "8a628b3b46819dd1785b2722bae1a5fd0c0750b677a70b15da5552ea3fd131d3"` [INFO] [stdout] 8a628b3b46819dd1785b2722bae1a5fd0c0750b677a70b15da5552ea3fd131d3