[INFO] updating cached repository C4K3/crates-ectype
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/C4K3/crates-ectype
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/C4K3/crates-ectype" "work/ex/clippy-test-run/sources/stable/gh/C4K3/crates-ectype"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/C4K3/crates-ectype'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/C4K3/crates-ectype" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C4K3/crates-ectype"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C4K3/crates-ectype'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7979612aeb34b7f3624ac2000263b6613315e327
[INFO] sha for GitHub repo C4K3/crates-ectype: 7979612aeb34b7f3624ac2000263b6613315e327
[INFO] validating manifest of C4K3/crates-ectype on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of C4K3/crates-ectype on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing C4K3/crates-ectype
[INFO] finished frobbing C4K3/crates-ectype
[INFO] frobbed toml for C4K3/crates-ectype written to work/ex/clippy-test-run/sources/stable/gh/C4K3/crates-ectype/Cargo.toml
[INFO] started frobbing C4K3/crates-ectype
[INFO] finished frobbing C4K3/crates-ectype
[INFO] frobbed toml for C4K3/crates-ectype written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C4K3/crates-ectype/Cargo.toml
[INFO] crate C4K3/crates-ectype has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting C4K3/crates-ectype against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/C4K3/crates-ectype:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0e2725694a8dee99ed1d8fe7394b1885e244eb4ef5127ad3d8aecb2013e8d037
[INFO] running `"docker" "start" "-a" "0e2725694a8dee99ed1d8fe7394b1885e244eb4ef5127ad3d8aecb2013e8d037"`
[INFO] [stderr]    Compiling cmake v0.1.32
[INFO] [stderr]     Checking socket2 v0.3.7
[INFO] [stderr]    Compiling curl-sys v0.4.8
[INFO] [stderr]     Checking libz-sys v1.0.20
[INFO] [stderr]    Compiling libssh2-sys v0.2.10
[INFO] [stderr]    Compiling libgit2-sys v0.7.7
[INFO] [stderr]     Checking curl v0.4.14
[INFO] [stderr]     Checking git2 v0.7.5
[INFO] [stderr]     Checking crates-ectype v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:120:27
[INFO] [stderr]     |
[INFO] [stderr] 120 |             update_index: matches.opt_present("no-update-index") == false,
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!matches.opt_present("no-update-index")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:122:25
[INFO] [stderr]     |
[INFO] [stderr] 122 |             check_sums: matches.opt_present("no-check-sums") == false,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!matches.opt_present("no-check-sums")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:248:8
[INFO] [stderr]     |
[INFO] [stderr] 248 |     if path.is_dir() == false {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!path.is_dir()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:295:28
[INFO] [stderr]     |
[INFO] [stderr] 295 |         Ok(ref remotes) if remotes.len() == 0 => {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remotes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:342:9
[INFO] [stderr]     |
[INFO] [stderr] 342 | /         if filename.starts_with(".") || filename == "config.json" {
[INFO] [stderr] 343 | |             false
[INFO] [stderr] 344 | |         } else {
[INFO] [stderr] 345 | |             true
[INFO] [stderr] 346 | |         }
[INFO] [stderr]     | |_________^ help: you can reduce it to: `!(filename.starts_with(".") || filename == "config.json")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:342:33
[INFO] [stderr]     |
[INFO] [stderr] 342 |         if filename.starts_with(".") || filename == "config.json" {
[INFO] [stderr]     |                                 ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:361:9
[INFO] [stderr]     |
[INFO] [stderr] 361 | /         loop {
[INFO] [stderr] 362 | |             let line = match iter.next() {
[INFO] [stderr] 363 | |                 Some(x) => x,
[INFO] [stderr] 364 | |                 None => break,
[INFO] [stderr] ...   |
[INFO] [stderr] 388 | |             }
[INFO] [stderr] 389 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(x) = iter.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:385:45
[INFO] [stderr]     |
[INFO] [stderr] 385 |             if (settings.download_yanked || crate_info.yanked == false)
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!crate_info.yanked`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:120:27
[INFO] [stderr]     |
[INFO] [stderr] 120 |             update_index: matches.opt_present("no-update-index") == false,
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!matches.opt_present("no-update-index")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:122:25
[INFO] [stderr]     |
[INFO] [stderr] 122 |             check_sums: matches.opt_present("no-check-sums") == false,
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!matches.opt_present("no-check-sums")`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:248:8
[INFO] [stderr]     |
[INFO] [stderr] 248 |     if path.is_dir() == false {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!path.is_dir()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:295:28
[INFO] [stderr]     |
[INFO] [stderr] 295 |         Ok(ref remotes) if remotes.len() == 0 => {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remotes.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:342:9
[INFO] [stderr]     |
[INFO] [stderr] 342 | /         if filename.starts_with(".") || filename == "config.json" {
[INFO] [stderr] 343 | |             false
[INFO] [stderr] 344 | |         } else {
[INFO] [stderr] 345 | |             true
[INFO] [stderr] 346 | |         }
[INFO] [stderr]     | |_________^ help: you can reduce it to: `!(filename.starts_with(".") || filename == "config.json")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/main.rs:342:33
[INFO] [stderr]     |
[INFO] [stderr] 342 |         if filename.starts_with(".") || filename == "config.json" {
[INFO] [stderr]     |                                 ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:361:9
[INFO] [stderr]     |
[INFO] [stderr] 361 | /         loop {
[INFO] [stderr] 362 | |             let line = match iter.next() {
[INFO] [stderr] 363 | |                 Some(x) => x,
[INFO] [stderr] 364 | |                 None => break,
[INFO] [stderr] ...   |
[INFO] [stderr] 388 | |             }
[INFO] [stderr] 389 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(x) = iter.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:385:45
[INFO] [stderr]     |
[INFO] [stderr] 385 |             if (settings.download_yanked || crate_info.yanked == false)
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!crate_info.yanked`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3m 00s
[INFO] running `"docker" "inspect" "0e2725694a8dee99ed1d8fe7394b1885e244eb4ef5127ad3d8aecb2013e8d037"`
[INFO] running `"docker" "rm" "-f" "0e2725694a8dee99ed1d8fe7394b1885e244eb4ef5127ad3d8aecb2013e8d037"`
[INFO] [stdout] 0e2725694a8dee99ed1d8fe7394b1885e244eb4ef5127ad3d8aecb2013e8d037