[INFO] updating cached repository C-Saunders/google_analytics_v4_report_flattener [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/C-Saunders/google_analytics_v4_report_flattener [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/C-Saunders/google_analytics_v4_report_flattener" "work/ex/clippy-test-run/sources/stable/gh/C-Saunders/google_analytics_v4_report_flattener"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/C-Saunders/google_analytics_v4_report_flattener'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/C-Saunders/google_analytics_v4_report_flattener" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C-Saunders/google_analytics_v4_report_flattener"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C-Saunders/google_analytics_v4_report_flattener'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8b0eb2ffbe297cbe67e91a1cdc7db85ed875a403 [INFO] sha for GitHub repo C-Saunders/google_analytics_v4_report_flattener: 8b0eb2ffbe297cbe67e91a1cdc7db85ed875a403 [INFO] validating manifest of C-Saunders/google_analytics_v4_report_flattener on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of C-Saunders/google_analytics_v4_report_flattener on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing C-Saunders/google_analytics_v4_report_flattener [INFO] finished frobbing C-Saunders/google_analytics_v4_report_flattener [INFO] frobbed toml for C-Saunders/google_analytics_v4_report_flattener written to work/ex/clippy-test-run/sources/stable/gh/C-Saunders/google_analytics_v4_report_flattener/Cargo.toml [INFO] started frobbing C-Saunders/google_analytics_v4_report_flattener [INFO] finished frobbing C-Saunders/google_analytics_v4_report_flattener [INFO] frobbed toml for C-Saunders/google_analytics_v4_report_flattener written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C-Saunders/google_analytics_v4_report_flattener/Cargo.toml [INFO] crate C-Saunders/google_analytics_v4_report_flattener has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting C-Saunders/google_analytics_v4_report_flattener against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/C-Saunders/google_analytics_v4_report_flattener:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36270aa3853386a5560de2fc19dab523fdd86c41fbc80037f16c3550fa509a10 [INFO] running `"docker" "start" "-a" "36270aa3853386a5560de2fc19dab523fdd86c41fbc80037f16c3550fa509a10"` [INFO] [stderr] Compiling syn v0.14.7 [INFO] [stderr] Checking itertools-num v0.1.2 [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Checking csv v1.0.1 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.71 [INFO] [stderr] Compiling indoc-impl v0.2.6 [INFO] [stderr] Checking indoc v0.2.6 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stderr] Checking ga-v4-flattener v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/to_row_array.rs:239:43 [INFO] [stderr] | [INFO] [stderr] 239 | "ga:avgTimeOnPage_2": 129.7071651, [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `129.707_165_1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/to_row_array.rs:240:49 [INFO] [stderr] | [INFO] [stderr] 240 | "ga:pageviewsPerSession_2": 3.60975609, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3.609_756_09` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/to_row_array.rs:243:41 [INFO] [stderr] | [INFO] [stderr] 243 | "ga:avgTimeOnPage": 51.794117, [INFO] [stderr] | ^^^^^^^^^ help: consider: `51.794_117` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/to_row_array.rs:244:47 [INFO] [stderr] | [INFO] [stderr] 244 | "ga:pageviewsPerSession": 6.6666667, [INFO] [stderr] | ^^^^^^^^^ help: consider: `6.666_666_7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/to_row_array.rs:245:43 [INFO] [stderr] | [INFO] [stderr] 245 | "ga:avgTimeOnPage_2": 210.866667, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `210.866_667` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/to_row_array.rs:249:41 [INFO] [stderr] | [INFO] [stderr] 249 | "ga:avgTimeOnPage": 123.657142, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `123.657_142` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/to_row_array.rs:251:43 [INFO] [stderr] | [INFO] [stderr] 251 | "ga:avgTimeOnPage_2": 75.333333, [INFO] [stderr] | ^^^^^^^^^ help: consider: `75.333_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/to_delimited.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | assert!(report_to_flat(&deserialized_response.reports[0], ",").len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!report_to_flat(&deserialized_response.reports[0], ",").is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 41.21s [INFO] running `"docker" "inspect" "36270aa3853386a5560de2fc19dab523fdd86c41fbc80037f16c3550fa509a10"` [INFO] running `"docker" "rm" "-f" "36270aa3853386a5560de2fc19dab523fdd86c41fbc80037f16c3550fa509a10"` [INFO] [stdout] 36270aa3853386a5560de2fc19dab523fdd86c41fbc80037f16c3550fa509a10