[INFO] updating cached repository C-Saunders/days_between [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/C-Saunders/days_between [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/C-Saunders/days_between" "work/ex/clippy-test-run/sources/stable/gh/C-Saunders/days_between"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/C-Saunders/days_between'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/C-Saunders/days_between" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C-Saunders/days_between"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C-Saunders/days_between'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bbf5027b592fda1a07056190b13f58a3f9ab0a1d [INFO] sha for GitHub repo C-Saunders/days_between: bbf5027b592fda1a07056190b13f58a3f9ab0a1d [INFO] validating manifest of C-Saunders/days_between on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of C-Saunders/days_between on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing C-Saunders/days_between [INFO] finished frobbing C-Saunders/days_between [INFO] frobbed toml for C-Saunders/days_between written to work/ex/clippy-test-run/sources/stable/gh/C-Saunders/days_between/Cargo.toml [INFO] started frobbing C-Saunders/days_between [INFO] finished frobbing C-Saunders/days_between [INFO] frobbed toml for C-Saunders/days_between written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/C-Saunders/days_between/Cargo.toml [INFO] crate C-Saunders/days_between has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting C-Saunders/days_between against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/C-Saunders/days_between:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 01413178c7031e9005eb17abbbff26a7163da045a2594920e84708f9d2467b93 [INFO] running `"docker" "start" "-a" "01413178c7031e9005eb17abbbff26a7163da045a2594920e84708f9d2467b93"` [INFO] [stderr] Compiling rand v0.4.2 [INFO] [stderr] Compiling serde_json v1.0.9 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking clap v2.29.2 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking regex v0.2.5 [INFO] [stderr] Compiling tempdir v0.3.6 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Checking days_between v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/calculate.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 79 | | if inputs.end.is_some() { [INFO] [stderr] 80 | | println!("{}", range.difference()) [INFO] [stderr] 81 | | } else { [INFO] [stderr] 82 | | println!("{}", range.end.format(output_format)); [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | } else if inputs.end.is_some() { [INFO] [stderr] 79 | println!("{}", range.difference()) [INFO] [stderr] 80 | } else { [INFO] [stderr] 81 | println!("{}", range.end.format(output_format)); [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/inputs/date_string_parser.rs:21:48 [INFO] [stderr] | [INFO] [stderr] 21 | format_type: if input.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/inputs/mod.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if !offset.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `offset.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Compiling assert_cli v0.5.4 [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/calculate.rs:78:12 [INFO] [stderr] | [INFO] [stderr] 78 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 79 | | if inputs.end.is_some() { [INFO] [stderr] 80 | | println!("{}", range.difference()) [INFO] [stderr] 81 | | } else { [INFO] [stderr] 82 | | println!("{}", range.end.format(output_format)); [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | } else if inputs.end.is_some() { [INFO] [stderr] 79 | println!("{}", range.difference()) [INFO] [stderr] 80 | } else { [INFO] [stderr] 81 | println!("{}", range.end.format(output_format)); [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/inputs/date_string_parser.rs:21:48 [INFO] [stderr] | [INFO] [stderr] 21 | format_type: if input.contains("-") { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/inputs/mod.rs:68:16 [INFO] [stderr] | [INFO] [stderr] 68 | if !offset.is_some() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `offset.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.07s [INFO] running `"docker" "inspect" "01413178c7031e9005eb17abbbff26a7163da045a2594920e84708f9d2467b93"` [INFO] running `"docker" "rm" "-f" "01413178c7031e9005eb17abbbff26a7163da045a2594920e84708f9d2467b93"` [INFO] [stdout] 01413178c7031e9005eb17abbbff26a7163da045a2594920e84708f9d2467b93