[INFO] updating cached repository Byron/git-reconstruct [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Byron/git-reconstruct [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Byron/git-reconstruct" "work/ex/clippy-test-run/sources/stable/gh/Byron/git-reconstruct"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Byron/git-reconstruct'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Byron/git-reconstruct" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/git-reconstruct"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/git-reconstruct'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fb99104bc00fbde35e7ca1ace6bc4f95b9ca5449 [INFO] sha for GitHub repo Byron/git-reconstruct: fb99104bc00fbde35e7ca1ace6bc4f95b9ca5449 [INFO] validating manifest of Byron/git-reconstruct on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Byron/git-reconstruct on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Byron/git-reconstruct [INFO] finished frobbing Byron/git-reconstruct [INFO] frobbed toml for Byron/git-reconstruct written to work/ex/clippy-test-run/sources/stable/gh/Byron/git-reconstruct/Cargo.toml [INFO] started frobbing Byron/git-reconstruct [INFO] finished frobbing Byron/git-reconstruct [INFO] frobbed toml for Byron/git-reconstruct written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/git-reconstruct/Cargo.toml [INFO] crate Byron/git-reconstruct has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Byron/git-reconstruct against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Byron/git-reconstruct:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c9001b3cecfd23b727cbb043847450dc41451fad52ebc46b0f5e6622607c14c7 [INFO] running `"docker" "start" "-a" "c9001b3cecfd23b727cbb043847450dc41451fad52ebc46b0f5e6622607c14c7"` [INFO] [stderr] Compiling openssl-sys v0.9.32 [INFO] [stderr] Compiling pulldown-cmark v0.0.8 [INFO] [stderr] Compiling lz4-sys v1.8.0 [INFO] [stderr] Compiling libgit2-sys v0.7.3 [INFO] [stderr] Checking bincode v1.0.0 [INFO] [stderr] Checking crossbeam-channel v0.2.1 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking failure-tools v4.0.2 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Compiling skeptic v0.9.0 [INFO] [stderr] Compiling curl-sys v0.4.5 [INFO] [stderr] Compiling libssh2-sys v0.2.7 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Compiling lz4 v1.22.0 [INFO] [stderr] Checking git2 v0.7.1 [INFO] [stderr] Checking git-reconstruct v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lut.rs:131:35 [INFO] [stderr] | [INFO] [stderr] 131 | self.vertices_to_oid.push(oid.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `oid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/find.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | let num_threads = opts.threads.unwrap_or(num_cpus::get_physical()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(num_cpus::get_physical)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lut.rs:131:35 [INFO] [stderr] | [INFO] [stderr] 131 | self.vertices_to_oid.push(oid.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `oid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/find.rs:56:36 [INFO] [stderr] | [INFO] [stderr] 56 | let num_threads = opts.threads.unwrap_or(num_cpus::get_physical()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(num_cpus::get_physical)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 31s [INFO] running `"docker" "inspect" "c9001b3cecfd23b727cbb043847450dc41451fad52ebc46b0f5e6622607c14c7"` [INFO] running `"docker" "rm" "-f" "c9001b3cecfd23b727cbb043847450dc41451fad52ebc46b0f5e6622607c14c7"` [INFO] [stdout] c9001b3cecfd23b727cbb043847450dc41451fad52ebc46b0f5e6622607c14c7