[INFO] updating cached repository Byron/git-commits-by-blob [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Byron/git-commits-by-blob [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Byron/git-commits-by-blob" "work/ex/clippy-test-run/sources/stable/gh/Byron/git-commits-by-blob"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Byron/git-commits-by-blob'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Byron/git-commits-by-blob" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/git-commits-by-blob"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/git-commits-by-blob'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 55d988680a66e1252f144e0a2e76dccace242cf4 [INFO] sha for GitHub repo Byron/git-commits-by-blob: 55d988680a66e1252f144e0a2e76dccace242cf4 [INFO] validating manifest of Byron/git-commits-by-blob on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Byron/git-commits-by-blob on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Byron/git-commits-by-blob [INFO] finished frobbing Byron/git-commits-by-blob [INFO] frobbed toml for Byron/git-commits-by-blob written to work/ex/clippy-test-run/sources/stable/gh/Byron/git-commits-by-blob/Cargo.toml [INFO] started frobbing Byron/git-commits-by-blob [INFO] finished frobbing Byron/git-commits-by-blob [INFO] frobbed toml for Byron/git-commits-by-blob written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/git-commits-by-blob/Cargo.toml [INFO] crate Byron/git-commits-by-blob has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Byron/git-commits-by-blob against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Byron/git-commits-by-blob:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d7af4158da6f341c48e98b5283a78224a95c10000d1b15645f47529f94acef22 [INFO] running `"docker" "start" "-a" "d7af4158da6f341c48e98b5283a78224a95c10000d1b15645f47529f94acef22"` [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.5 [INFO] [stderr] Compiling libssh2-sys v0.2.7 [INFO] [stderr] Compiling libgit2-sys v0.7.3 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking failure-tools v4.0.2 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking git2 v0.7.1 [INFO] [stderr] Checking git-commits-by-blob v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lut.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lut.rs:234:77 [INFO] [stderr] | [INFO] [stderr] 234 | fn compact_memory(lut: &mut BTreeMap, progress: &ProgressBar) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lut.rs:40:3 [INFO] [stderr] | [INFO] [stderr] 40 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lut.rs:234:77 [INFO] [stderr] | [INFO] [stderr] 234 | fn compact_memory(lut: &mut BTreeMap, progress: &ProgressBar) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lut.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn commit_oids_table(luts: &MultiReverseCommitGraph) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lut.rs:24:11 [INFO] [stderr] | [INFO] [stderr] 24 | luts: &MultiReverseCommitGraph, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lut.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | all_oids: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lut.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | all_oids: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Oid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cli.rs:10:38 [INFO] [stderr] | [INFO] [stderr] 10 | fn deplete_requests_from_stdin(luts: &MultiReverseCommitGraph) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lut.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn commit_oids_table(luts: &MultiReverseCommitGraph) -> Vec> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lut.rs:24:11 [INFO] [stderr] | [INFO] [stderr] 24 | luts: &MultiReverseCommitGraph, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lut.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | all_oids: &Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lut.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | all_oids: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Oid]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cli.rs:10:38 [INFO] [stderr] | [INFO] [stderr] 10 | fn deplete_requests_from_stdin(luts: &MultiReverseCommitGraph) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 24s [INFO] running `"docker" "inspect" "d7af4158da6f341c48e98b5283a78224a95c10000d1b15645f47529f94acef22"` [INFO] running `"docker" "rm" "-f" "d7af4158da6f341c48e98b5283a78224a95c10000d1b15645f47529f94acef22"` [INFO] [stdout] d7af4158da6f341c48e98b5283a78224a95c10000d1b15645f47529f94acef22