[INFO] updating cached repository Byron/crates-io-cli-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Byron/crates-io-cli-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Byron/crates-io-cli-rs" "work/ex/clippy-test-run/sources/stable/gh/Byron/crates-io-cli-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Byron/crates-io-cli-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Byron/crates-io-cli-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/crates-io-cli-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/crates-io-cli-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 85cb942ad1b829a79f59a46984aaf5fbea7981b5 [INFO] sha for GitHub repo Byron/crates-io-cli-rs: 85cb942ad1b829a79f59a46984aaf5fbea7981b5 [INFO] validating manifest of Byron/crates-io-cli-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Byron/crates-io-cli-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Byron/crates-io-cli-rs [INFO] finished frobbing Byron/crates-io-cli-rs [INFO] frobbed toml for Byron/crates-io-cli-rs written to work/ex/clippy-test-run/sources/stable/gh/Byron/crates-io-cli-rs/Cargo.toml [INFO] started frobbing Byron/crates-io-cli-rs [INFO] finished frobbing Byron/crates-io-cli-rs [INFO] frobbed toml for Byron/crates-io-cli-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Byron/crates-io-cli-rs/Cargo.toml [INFO] crate Byron/crates-io-cli-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Byron/crates-io-cli-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Byron/crates-io-cli-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9befdb5658a091054844b987be54529c89776a83230e2117a559369ed28a05c3 [INFO] running `"docker" "start" "-a" "9befdb5658a091054844b987be54529c89776a83230e2117a559369ed28a05c3"` [INFO] [stderr] warning: file found to be present in multiple build targets: /opt/crater/workdir/src/main.rs [INFO] [stderr] Compiling curl-sys v0.4.12 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking curl v0.4.18 [INFO] [stderr] Checking tokio-curl v0.1.11 [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stderr] Checking crates-index-diff v3.0.0 [INFO] [stderr] Checking crates-io-cli v2.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/search/interactive.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/search/interactive.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/search/interactive.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/list/cmd.rs:42:58 [INFO] [stderr] | [INFO] [stderr] 42 | Ok((Decodable::decode(&mut decoder)?, Meta { total: total })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | print!("{}\n", matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/search/interactive.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/list/cmd.rs:42:58 [INFO] [stderr] | [INFO] [stderr] 42 | Ok((Decodable::decode(&mut decoder)?, Meta { total: total })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | print!("{}\n", matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/search/interactive.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/search/interactive.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/list/cmd.rs:42:58 [INFO] [stderr] | [INFO] [stderr] 42 | Ok((Decodable::decode(&mut decoder)?, Meta { total: total })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | print!("{}\n", matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/search/interactive.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | force: force, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `force` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/search/interactive.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | number: number, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scmds/list/cmd.rs:42:58 [INFO] [stderr] | [INFO] [stderr] 42 | Ok((Decodable::decode(&mut decoder)?, Meta { total: total })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:47:5 [INFO] [stderr] | [INFO] [stderr] 47 | print!("{}\n", matches.usage()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scmds/search/interactive.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | return Ok(LoopControl::ShouldKeepGoing); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(LoopControl::ShouldKeepGoing)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scmds/list/cmd.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | const TOTAL_PATH: [&'static str; 2] = ["meta", "total"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scmds/list/cmd.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const CRATES_PATH: [&'static str; 1] = ["crates"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | const CHANGES_SUBCOMMAND_DESCRIPTION: &'static str = r##" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scmds/search/interactive.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | return Ok(LoopControl::ShouldKeepGoing); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(LoopControl::ShouldKeepGoing)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scmds/list/cmd.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | const TOTAL_PATH: [&'static str; 2] = ["meta", "total"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scmds/list/cmd.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const CRATES_PATH: [&'static str; 1] = ["crates"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | const CHANGES_SUBCOMMAND_DESCRIPTION: &'static str = r##" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scmds/search/interactive.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | return Ok(LoopControl::ShouldKeepGoing); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(LoopControl::ShouldKeepGoing)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scmds/list/cmd.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | const TOTAL_PATH: [&'static str; 2] = ["meta", "total"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scmds/list/cmd.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const CRATES_PATH: [&'static str; 1] = ["crates"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | const CHANGES_SUBCOMMAND_DESCRIPTION: &'static str = r##" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scmds/search/interactive.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | return Ok(LoopControl::ShouldKeepGoing); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(LoopControl::ShouldKeepGoing)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scmds/list/cmd.rs:15:21 [INFO] [stderr] | [INFO] [stderr] 15 | const TOTAL_PATH: [&'static str; 2] = ["meta", "total"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/scmds/list/cmd.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | const CRATES_PATH: [&'static str; 1] = ["crates"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | const CHANGES_SUBCOMMAND_DESCRIPTION: &'static str = r##" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:112:49 [INFO] [stderr] | [INFO] [stderr] 112 | Some(ref mut f) => f.poll().map_err(|e| DroppedOrError::Err(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DroppedOrError::Err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/utils.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn remote_call<'a>(url: &str, session: Arc>) -> RemoteCallFuture { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scmds/search/structs.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | let dllen = f64::log10(c.downloads as f64) as usize + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.downloads)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scmds/search/structs.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | for (i, &w) in prio_widths.clone().iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `prio_widths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/scmds/search/interactive.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | Some(dim.height as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(dim.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scmds/search/interactive.rs:113:40 [INFO] [stderr] | [INFO] [stderr] 113 | let timeout = Timeout::new(default_timeout.clone(), handle) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `default_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/scmds/search/interactive.rs:157:6 [INFO] [stderr] | [INFO] [stderr] 157 | ) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/scmds/search/interactive.rs:276:27 [INFO] [stderr] | [INFO] [stderr] 276 | info(&format!("Please enter digits from 0-9")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Please enter digits from 0-9".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the `key @ _` pattern can be written as just `key` [INFO] [stderr] --> src/scmds/search/interactive.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | key @ _ => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/scmds/search/interactive.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | / match show_last_search { [INFO] [stderr] 312 | | true => ShowLast, [INFO] [stderr] 313 | | false => Search(state.term.clone()), [INFO] [stderr] 314 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if show_last_search { ShowLast } else { Search(state.term.clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scmds/search/interactive.rs:317:20 [INFO] [stderr] | [INFO] [stderr] 317 | Opening if state.number.len() > 0 => Open { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.number.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:112:49 [INFO] [stderr] | [INFO] [stderr] 112 | Some(ref mut f) => f.poll().map_err(|e| DroppedOrError::Err(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DroppedOrError::Err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/utils.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn remote_call<'a>(url: &str, session: Arc>) -> RemoteCallFuture { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scmds/search/structs.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | let dllen = f64::log10(c.downloads as f64) as usize + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.downloads)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scmds/search/structs.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | for (i, &w) in prio_widths.clone().iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `prio_widths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/scmds/search/interactive.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | Some(dim.height as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(dim.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scmds/search/interactive.rs:113:40 [INFO] [stderr] | [INFO] [stderr] 113 | let timeout = Timeout::new(default_timeout.clone(), handle) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `default_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/scmds/search/interactive.rs:157:6 [INFO] [stderr] | [INFO] [stderr] 157 | ) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:112:49 [INFO] [stderr] | [INFO] [stderr] 112 | Some(ref mut f) => f.poll().map_err(|e| DroppedOrError::Err(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DroppedOrError::Err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/utils.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn remote_call<'a>(url: &str, session: Arc>) -> RemoteCallFuture { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/scmds/search/interactive.rs:276:27 [INFO] [stderr] | [INFO] [stderr] 276 | info(&format!("Please enter digits from 0-9")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Please enter digits from 0-9".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the `key @ _` pattern can be written as just `key` [INFO] [stderr] --> src/scmds/search/interactive.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | key @ _ => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/scmds/search/interactive.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | / match show_last_search { [INFO] [stderr] 312 | | true => ShowLast, [INFO] [stderr] 313 | | false => Search(state.term.clone()), [INFO] [stderr] 314 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if show_last_search { ShowLast } else { Search(state.term.clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scmds/search/interactive.rs:317:20 [INFO] [stderr] | [INFO] [stderr] 317 | Opening if state.number.len() > 0 => Open { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.number.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scmds/search/structs.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | let dllen = f64::log10(c.downloads as f64) as usize + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.downloads)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scmds/search/structs.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | for (i, &w) in prio_widths.clone().iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `prio_widths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/scmds/search/interactive.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | Some(dim.height as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(dim.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scmds/search/interactive.rs:113:40 [INFO] [stderr] | [INFO] [stderr] 113 | let timeout = Timeout::new(default_timeout.clone(), handle) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `default_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/scmds/search/interactive.rs:157:6 [INFO] [stderr] | [INFO] [stderr] 157 | ) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/scmds/search/interactive.rs:276:27 [INFO] [stderr] | [INFO] [stderr] 276 | info(&format!("Please enter digits from 0-9")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Please enter digits from 0-9".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the `key @ _` pattern can be written as just `key` [INFO] [stderr] --> src/scmds/search/interactive.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | key @ _ => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/scmds/search/interactive.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | / match show_last_search { [INFO] [stderr] 312 | | true => ShowLast, [INFO] [stderr] 313 | | false => Search(state.term.clone()), [INFO] [stderr] 314 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if show_last_search { ShowLast } else { Search(state.term.clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scmds/search/interactive.rs:317:20 [INFO] [stderr] | [INFO] [stderr] 317 | Opening if state.number.len() > 0 => Open { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.number.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/utils.rs:112:49 [INFO] [stderr] | [INFO] [stderr] 112 | Some(ref mut f) => f.poll().map_err(|e| DroppedOrError::Err(e)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `DroppedOrError::Err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/utils.rs:134:20 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn remote_call<'a>(url: &str, session: Arc>) -> RemoteCallFuture { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scmds/search/structs.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | let dllen = f64::log10(c.downloads as f64) as usize + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.downloads)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scmds/search/structs.rs:91:24 [INFO] [stderr] | [INFO] [stderr] 91 | for (i, &w) in prio_widths.clone().iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `prio_widths` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/scmds/search/interactive.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | Some(dim.height as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(dim.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/scmds/search/interactive.rs:113:40 [INFO] [stderr] | [INFO] [stderr] 113 | let timeout = Timeout::new(default_timeout.clone(), handle) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `default_timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/scmds/search/interactive.rs:157:6 [INFO] [stderr] | [INFO] [stderr] 157 | ) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/scmds/search/interactive.rs:276:27 [INFO] [stderr] | [INFO] [stderr] 276 | info(&format!("Please enter digits from 0-9")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Please enter digits from 0-9".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: the `key @ _` pattern can be written as just `key` [INFO] [stderr] --> src/scmds/search/interactive.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | key @ _ => { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/scmds/search/interactive.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | / match show_last_search { [INFO] [stderr] 312 | | true => ShowLast, [INFO] [stderr] 313 | | false => Search(state.term.clone()), [INFO] [stderr] 314 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if show_last_search { ShowLast } else { Search(state.term.clone()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/scmds/search/interactive.rs:317:20 [INFO] [stderr] | [INFO] [stderr] 317 | Opening if state.number.len() > 0 => Open { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!state.number.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.47s [INFO] running `"docker" "inspect" "9befdb5658a091054844b987be54529c89776a83230e2117a559369ed28a05c3"` [INFO] running `"docker" "rm" "-f" "9befdb5658a091054844b987be54529c89776a83230e2117a559369ed28a05c3"` [INFO] [stdout] 9befdb5658a091054844b987be54529c89776a83230e2117a559369ed28a05c3