[INFO] updating cached repository ButteryCrumpet/html-text-ectractor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ButteryCrumpet/html-text-ectractor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ButteryCrumpet/html-text-ectractor" "work/ex/clippy-test-run/sources/stable/gh/ButteryCrumpet/html-text-ectractor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ButteryCrumpet/html-text-ectractor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ButteryCrumpet/html-text-ectractor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ButteryCrumpet/html-text-ectractor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ButteryCrumpet/html-text-ectractor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 295a1a8293f7d224dba7cfb20dbed1d30798a680 [INFO] sha for GitHub repo ButteryCrumpet/html-text-ectractor: 295a1a8293f7d224dba7cfb20dbed1d30798a680 [INFO] validating manifest of ButteryCrumpet/html-text-ectractor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ButteryCrumpet/html-text-ectractor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ButteryCrumpet/html-text-ectractor [INFO] finished frobbing ButteryCrumpet/html-text-ectractor [INFO] frobbed toml for ButteryCrumpet/html-text-ectractor written to work/ex/clippy-test-run/sources/stable/gh/ButteryCrumpet/html-text-ectractor/Cargo.toml [INFO] started frobbing ButteryCrumpet/html-text-ectractor [INFO] finished frobbing ButteryCrumpet/html-text-ectractor [INFO] frobbed toml for ButteryCrumpet/html-text-ectractor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ButteryCrumpet/html-text-ectractor/Cargo.toml [INFO] crate ButteryCrumpet/html-text-ectractor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ButteryCrumpet/html-text-ectractor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/ButteryCrumpet/html-text-ectractor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 65dfbd4b2d3cbbc2afeee195f30b85359843ac536f0e3f03870172b46794c6be [INFO] running `"docker" "start" "-a" "65dfbd4b2d3cbbc2afeee195f30b85359843ac536f0e3f03870172b46794c6be"` [INFO] [stderr] Checking seiki-to-twig v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | matches: matches [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | matches: matches [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|file| read_file(file)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `read_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match deduped.last() { [INFO] [stderr] 58 | | Some(x) => { [INFO] [stderr] 59 | | if text == x.to_owned() { [INFO] [stderr] 60 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 63 | | _ => () [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 57 | if let Some(x) = deduped.last() { [INFO] [stderr] 58 | if text == x.to_owned() { [INFO] [stderr] 59 | continue; [INFO] [stderr] 60 | } [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | if text == x.to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:50:14 [INFO] [stderr] | [INFO] [stderr] 50 | .map(|file| read_file(file)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `read_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match deduped.last() { [INFO] [stderr] 58 | | Some(x) => { [INFO] [stderr] 59 | | if text == x.to_owned() { [INFO] [stderr] 60 | | continue; [INFO] [stderr] ... | [INFO] [stderr] 63 | | _ => () [INFO] [stderr] 64 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 57 | if let Some(x) = deduped.last() { [INFO] [stderr] 58 | if text == x.to_owned() { [INFO] [stderr] 59 | continue; [INFO] [stderr] 60 | } [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | if text == x.to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.53s [INFO] running `"docker" "inspect" "65dfbd4b2d3cbbc2afeee195f30b85359843ac536f0e3f03870172b46794c6be"` [INFO] running `"docker" "rm" "-f" "65dfbd4b2d3cbbc2afeee195f30b85359843ac536f0e3f03870172b46794c6be"` [INFO] [stdout] 65dfbd4b2d3cbbc2afeee195f30b85359843ac536f0e3f03870172b46794c6be