[INFO] updating cached repository BurntSushi/vcr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BurntSushi/vcr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BurntSushi/vcr" "work/ex/clippy-test-run/sources/stable/gh/BurntSushi/vcr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BurntSushi/vcr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BurntSushi/vcr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BurntSushi/vcr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BurntSushi/vcr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef1ba50743ad5eb2b637abe65d18c9eeee336563 [INFO] sha for GitHub repo BurntSushi/vcr: ef1ba50743ad5eb2b637abe65d18c9eeee336563 [INFO] validating manifest of BurntSushi/vcr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BurntSushi/vcr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BurntSushi/vcr [INFO] finished frobbing BurntSushi/vcr [INFO] frobbed toml for BurntSushi/vcr written to work/ex/clippy-test-run/sources/stable/gh/BurntSushi/vcr/Cargo.toml [INFO] started frobbing BurntSushi/vcr [INFO] finished frobbing BurntSushi/vcr [INFO] frobbed toml for BurntSushi/vcr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BurntSushi/vcr/Cargo.toml [INFO] crate BurntSushi/vcr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BurntSushi/vcr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BurntSushi/vcr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cae73b3e98f33cb13b56b3cc655fc3ec88ee7f2d5f9cd1e350f7f4956a8bff58 [INFO] running `"docker" "start" "-a" "cae73b3e98f33cb13b56b3cc655fc3ec88ee7f2d5f9cd1e350f7f4956a8bff58"` [INFO] [stderr] Checking vcr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | tmpdir: tmpdir, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tmpdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | output_name: output_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | video: video, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `video` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | audio: audio, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `audio` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | tmpdir: tmpdir, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tmpdir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | output: output, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `output` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | output_name: output_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | video: video, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `video` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | audio: audio, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `audio` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/capture.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | duration: duration, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/blue.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | const BLUE_FRAME: &'static [u8] = include_bytes!("blue.jpg"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/blue.rs:8:20 [INFO] [stderr] | [INFO] [stderr] 8 | const BLUE_FRAME: &'static [u8] = include_bytes!("blue.jpg"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/capture.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | if blues.0.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `blues.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/capture.rs:140:12 [INFO] [stderr] | [INFO] [stderr] 140 | if blues.0.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `blues.0.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.66s [INFO] running `"docker" "inspect" "cae73b3e98f33cb13b56b3cc655fc3ec88ee7f2d5f9cd1e350f7f4956a8bff58"` [INFO] running `"docker" "rm" "-f" "cae73b3e98f33cb13b56b3cc655fc3ec88ee7f2d5f9cd1e350f7f4956a8bff58"` [INFO] [stdout] cae73b3e98f33cb13b56b3cc655fc3ec88ee7f2d5f9cd1e350f7f4956a8bff58