[INFO] updating cached repository BrooksPatton/rusty-chatbot-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BrooksPatton/rusty-chatbot-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BrooksPatton/rusty-chatbot-server" "work/ex/clippy-test-run/sources/stable/gh/BrooksPatton/rusty-chatbot-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BrooksPatton/rusty-chatbot-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BrooksPatton/rusty-chatbot-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrooksPatton/rusty-chatbot-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrooksPatton/rusty-chatbot-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1aab9068e84370a95c791efc4e6ae4c566f69998 [INFO] sha for GitHub repo BrooksPatton/rusty-chatbot-server: 1aab9068e84370a95c791efc4e6ae4c566f69998 [INFO] validating manifest of BrooksPatton/rusty-chatbot-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BrooksPatton/rusty-chatbot-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BrooksPatton/rusty-chatbot-server [INFO] finished frobbing BrooksPatton/rusty-chatbot-server [INFO] frobbed toml for BrooksPatton/rusty-chatbot-server written to work/ex/clippy-test-run/sources/stable/gh/BrooksPatton/rusty-chatbot-server/Cargo.toml [INFO] started frobbing BrooksPatton/rusty-chatbot-server [INFO] finished frobbing BrooksPatton/rusty-chatbot-server [INFO] frobbed toml for BrooksPatton/rusty-chatbot-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrooksPatton/rusty-chatbot-server/Cargo.toml [INFO] crate BrooksPatton/rusty-chatbot-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BrooksPatton/rusty-chatbot-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BrooksPatton/rusty-chatbot-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d40347e5572e5c3e3bd6bc0988035f887d3fd600d7be134219e662387a465230 [INFO] running `"docker" "start" "-a" "d40347e5572e5c3e3bd6bc0988035f887d3fd600d7be134219e662387a465230"` [INFO] [stderr] Checking tokio-timer v0.1.2 [INFO] [stderr] Checking mio-extras v2.0.5 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking ws v0.7.8 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking irc v0.13.5 [INFO] [stderr] Checking rusty_chatbot_server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/chatbot.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 45 | | if nickname != "brookzerker_bot" { [INFO] [stderr] 46 | | let response = format!("{{\"nickname\":\"{}\",\"message\":\"{}\"}}", nickname , message); [INFO] [stderr] 47 | | [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | } else if nickname != "brookzerker_bot" { [INFO] [stderr] 45 | let response = format!("{{\"nickname\":\"{}\",\"message\":\"{}\"}}", nickname , message); [INFO] [stderr] 46 | [INFO] [stderr] 47 | println!("Sending message to websocket: {}", response); [INFO] [stderr] 48 | chatbot_tx.send(response).expect("unable to send chat message to thread"); [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/websocket.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | self.out.broadcast(format!("{}", message)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `message.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/chatbot.rs:44:24 [INFO] [stderr] | [INFO] [stderr] 44 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 45 | | if nickname != "brookzerker_bot" { [INFO] [stderr] 46 | | let response = format!("{{\"nickname\":\"{}\",\"message\":\"{}\"}}", nickname , message); [INFO] [stderr] 47 | | [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | } else if nickname != "brookzerker_bot" { [INFO] [stderr] 45 | let response = format!("{{\"nickname\":\"{}\",\"message\":\"{}\"}}", nickname , message); [INFO] [stderr] 46 | [INFO] [stderr] 47 | println!("Sending message to websocket: {}", response); [INFO] [stderr] 48 | chatbot_tx.send(response).expect("unable to send chat message to thread"); [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/websocket.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | self.out.broadcast(format!("{}", message)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `message.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.14s [INFO] running `"docker" "inspect" "d40347e5572e5c3e3bd6bc0988035f887d3fd600d7be134219e662387a465230"` [INFO] running `"docker" "rm" "-f" "d40347e5572e5c3e3bd6bc0988035f887d3fd600d7be134219e662387a465230"` [INFO] [stdout] d40347e5572e5c3e3bd6bc0988035f887d3fd600d7be134219e662387a465230