[INFO] updating cached repository BrianMehrman/rust_mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BrianMehrman/rust_mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BrianMehrman/rust_mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/BrianMehrman/rust_mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BrianMehrman/rust_mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BrianMehrman/rust_mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrianMehrman/rust_mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrianMehrman/rust_mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7824c96e7ab8fb4919949c75a990f49c80ff09ba [INFO] sha for GitHub repo BrianMehrman/rust_mandelbrot: 7824c96e7ab8fb4919949c75a990f49c80ff09ba [INFO] validating manifest of BrianMehrman/rust_mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BrianMehrman/rust_mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BrianMehrman/rust_mandelbrot [INFO] finished frobbing BrianMehrman/rust_mandelbrot [INFO] frobbed toml for BrianMehrman/rust_mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/BrianMehrman/rust_mandelbrot/Cargo.toml [INFO] started frobbing BrianMehrman/rust_mandelbrot [INFO] finished frobbing BrianMehrman/rust_mandelbrot [INFO] frobbed toml for BrianMehrman/rust_mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrianMehrman/rust_mandelbrot/Cargo.toml [INFO] crate BrianMehrman/rust_mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BrianMehrman/rust_mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BrianMehrman/rust_mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3cda5777e78ee3fddc7c6e9bed90b69a252d7eb511fb234d61af8f63c6fc8d4e [INFO] running `"docker" "start" "-a" "3cda5777e78ee3fddc7c6e9bed90b69a252d7eb511fb234d61af8f63c6fc8d4e"` [INFO] [stderr] Compiling cmake v0.1.30 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Checking glfw v0.19.0 [INFO] [stderr] Checking benoƮt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:271:154 [INFO] [stderr] | [INFO] [stderr] 271 | fn process_events(window: &mut glfw::Window, events: &Receiver<(f64, glfw::WindowEvent)>, keypress: &mut bool, x: &mut f64, y: &mut f64, zoom: &mut f64) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:271:154 [INFO] [stderr] | [INFO] [stderr] 271 | fn process_events(window: &mut glfw::Window, events: &Receiver<(f64, glfw::WindowEvent)>, keypress: &mut bool, x: &mut f64, y: &mut f64, zoom: &mut f64) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:23 [INFO] [stderr] | [INFO] [stderr] 106 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | / let smaller: i32; [INFO] [stderr] 240 | | if w >= h { [INFO] [stderr] 241 | | smaller = h; [INFO] [stderr] 242 | | } else { [INFO] [stderr] 243 | | smaller= w; [INFO] [stderr] 244 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let smaller = if w >= h { h } else { w };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:23 [INFO] [stderr] | [INFO] [stderr] 106 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:118:23 [INFO] [stderr] | [INFO] [stderr] 118 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:130:23 [INFO] [stderr] | [INFO] [stderr] 130 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:239:17 [INFO] [stderr] | [INFO] [stderr] 239 | / let smaller: i32; [INFO] [stderr] 240 | | if w >= h { [INFO] [stderr] 241 | | smaller = h; [INFO] [stderr] 242 | | } else { [INFO] [stderr] 243 | | smaller= w; [INFO] [stderr] 244 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let smaller = if w >= h { h } else { w };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.16s [INFO] running `"docker" "inspect" "3cda5777e78ee3fddc7c6e9bed90b69a252d7eb511fb234d61af8f63c6fc8d4e"` [INFO] running `"docker" "rm" "-f" "3cda5777e78ee3fddc7c6e9bed90b69a252d7eb511fb234d61af8f63c6fc8d4e"` [INFO] [stdout] 3cda5777e78ee3fddc7c6e9bed90b69a252d7eb511fb234d61af8f63c6fc8d4e