[INFO] updating cached repository BrianLeishman/mysql-format [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BrianLeishman/mysql-format [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BrianLeishman/mysql-format" "work/ex/clippy-test-run/sources/stable/gh/BrianLeishman/mysql-format"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BrianLeishman/mysql-format'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BrianLeishman/mysql-format" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrianLeishman/mysql-format"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrianLeishman/mysql-format'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0431709f071edfe3fe7db80930437cbffb695880 [INFO] sha for GitHub repo BrianLeishman/mysql-format: 0431709f071edfe3fe7db80930437cbffb695880 [INFO] validating manifest of BrianLeishman/mysql-format on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BrianLeishman/mysql-format on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BrianLeishman/mysql-format [INFO] finished frobbing BrianLeishman/mysql-format [INFO] frobbed toml for BrianLeishman/mysql-format written to work/ex/clippy-test-run/sources/stable/gh/BrianLeishman/mysql-format/Cargo.toml [INFO] started frobbing BrianLeishman/mysql-format [INFO] finished frobbing BrianLeishman/mysql-format [INFO] frobbed toml for BrianLeishman/mysql-format written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrianLeishman/mysql-format/Cargo.toml [INFO] crate BrianLeishman/mysql-format has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BrianLeishman/mysql-format against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BrianLeishman/mysql-format:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf86079897c9c11048b1f4a83941ec36047c8a9e3f2fe7d540f523a41720b014 [INFO] running `"docker" "start" "-a" "cf86079897c9c11048b1f4a83941ec36047c8a9e3f2fe7d540f523a41720b014"` [INFO] [stderr] Compiling mysql-format v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/mysql-format-272cfdd588a7c873/out/codegen.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 6246114685207409605, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_246_114_685_207_409_605` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/mysql-format-272cfdd588a7c873/out/codegen.rs:835:10 [INFO] [stderr] | [INFO] [stderr] 835 | key: 6246114685207409605, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_246_114_685_207_409_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:657:2 [INFO] [stderr] | [INFO] [stderr] 657 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/mysql-format-272cfdd588a7c873/out/codegen.rs:2:10 [INFO] [stderr] | [INFO] [stderr] 2 | key: 6246114685207409605, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_246_114_685_207_409_605` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> /opt/crater/target/debug/build/mysql-format-272cfdd588a7c873/out/codegen.rs:835:10 [INFO] [stderr] | [INFO] [stderr] 835 | key: 6246114685207409605, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_246_114_685_207_409_605` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:657:2 [INFO] [stderr] | [INFO] [stderr] 657 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cur_line_len` is never read [INFO] [stderr] --> src/main.rs:232:6 [INFO] [stderr] | [INFO] [stderr] 232 | cur_line_len = len_after_breakpoint; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `len_after_breakpoint` is never read [INFO] [stderr] --> src/main.rs:234:6 [INFO] [stderr] | [INFO] [stderr] 234 | len_after_breakpoint = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `breakpoint_p` is never read [INFO] [stderr] --> src/main.rs:235:6 [INFO] [stderr] | [INFO] [stderr] 235 | breakpoint_p = p; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `len_after_breakpoint` is never read [INFO] [stderr] --> src/main.rs:419:7 [INFO] [stderr] | [INFO] [stderr] 419 | len_after_breakpoint = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `breakpoint_p` is never read [INFO] [stderr] --> src/main.rs:420:7 [INFO] [stderr] | [INFO] [stderr] 420 | breakpoint_p = p; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `len_after_breakpoint` is never read [INFO] [stderr] --> src/main.rs:424:7 [INFO] [stderr] | [INFO] [stderr] 424 | len_after_breakpoint = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `breakpoint_p` is never read [INFO] [stderr] --> src/main.rs:425:7 [INFO] [stderr] | [INFO] [stderr] 425 | breakpoint_p = p + 1; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `cur_line_len` is never read [INFO] [stderr] --> src/main.rs:232:6 [INFO] [stderr] | [INFO] [stderr] 232 | cur_line_len = len_after_breakpoint; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `len_after_breakpoint` is never read [INFO] [stderr] --> src/main.rs:234:6 [INFO] [stderr] | [INFO] [stderr] 234 | len_after_breakpoint = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `breakpoint_p` is never read [INFO] [stderr] --> src/main.rs:235:6 [INFO] [stderr] | [INFO] [stderr] 235 | breakpoint_p = p; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `len_after_breakpoint` is never read [INFO] [stderr] --> src/main.rs:419:7 [INFO] [stderr] | [INFO] [stderr] 419 | len_after_breakpoint = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `breakpoint_p` is never read [INFO] [stderr] --> src/main.rs:420:7 [INFO] [stderr] | [INFO] [stderr] 420 | breakpoint_p = p; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `len_after_breakpoint` is never read [INFO] [stderr] --> src/main.rs:424:7 [INFO] [stderr] | [INFO] [stderr] 424 | len_after_breakpoint = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: value assigned to `breakpoint_p` is never read [INFO] [stderr] --> src/main.rs:425:7 [INFO] [stderr] | [INFO] [stderr] 425 | breakpoint_p = p + 1; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 571 | push_token_string!(); [INFO] [stderr] | --------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 206 [INFO] [stderr] --> src/main.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | / fn mysql_format2(mysql: &str) -> String { [INFO] [stderr] 120 | | let mysql = mysql.trim(); [INFO] [stderr] 121 | | let bs = mysql.as_bytes(); [INFO] [stderr] 122 | | let lower = mysql.to_lowercase(); [INFO] [stderr] ... | [INFO] [stderr] 657 | | return s; [INFO] [stderr] 658 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | / match prev_token { [INFO] [stderr] 273 | | $(Token::$p)|+ => l_push!(' '), [INFO] [stderr] 274 | | _ => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Token::$p = prev_token { push_token_name!(); }` [INFO] [stderr] ... [INFO] [stderr] 564 | push_token_name!(); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 206 [INFO] [stderr] --> src/main.rs:119:1 [INFO] [stderr] | [INFO] [stderr] 119 | / fn mysql_format2(mysql: &str) -> String { [INFO] [stderr] 120 | | let mysql = mysql.trim(); [INFO] [stderr] 121 | | let bs = mysql.as_bytes(); [INFO] [stderr] 122 | | let lower = mysql.to_lowercase(); [INFO] [stderr] ... | [INFO] [stderr] 657 | | return s; [INFO] [stderr] 658 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:477:5 [INFO] [stderr] | [INFO] [stderr] 477 | match $word { [INFO] [stderr] | _________________^ [INFO] [stderr] 478 | | "on" => { [INFO] [stderr] 479 | | last_breakpoint = s.len(); [INFO] [stderr] 480 | | len_after_breakpoint = 0; [INFO] [stderr] ... | [INFO] [stderr] 483 | | _ => {} [INFO] [stderr] 484 | | } [INFO] [stderr] | |_________________^ help: try this: `if let "on" = &lower[start..=i] { push_token_word!(); }` [INFO] [stderr] ... [INFO] [stderr] 627 | push_token_word!(); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | / match prev_token { [INFO] [stderr] 273 | | $(Token::$p)|+ => l_push!(' '), [INFO] [stderr] 274 | | _ => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Token::$p = prev_token { push_token_name!(); }` [INFO] [stderr] ... [INFO] [stderr] 629 | push_token_name!(); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | / match prev_token { [INFO] [stderr] 273 | | $(Token::$p)|+ => l_push!(' '), [INFO] [stderr] 274 | | _ => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Token::$p = prev_token { push_token_name!(); }` [INFO] [stderr] ... [INFO] [stderr] 564 | push_token_name!(); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:477:5 [INFO] [stderr] | [INFO] [stderr] 477 | match $word { [INFO] [stderr] | _________________^ [INFO] [stderr] 478 | | "on" => { [INFO] [stderr] 479 | | last_breakpoint = s.len(); [INFO] [stderr] 480 | | len_after_breakpoint = 0; [INFO] [stderr] ... | [INFO] [stderr] 483 | | _ => {} [INFO] [stderr] 484 | | } [INFO] [stderr] | |_________________^ help: try this: `if let "on" = &lower[start..=i] { push_token_word!(); }` [INFO] [stderr] ... [INFO] [stderr] 627 | push_token_word!(); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | / match prev_token { [INFO] [stderr] 273 | | $(Token::$p)|+ => l_push!(' '), [INFO] [stderr] 274 | | _ => {} [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Token::$p = prev_token { push_token_name!(); }` [INFO] [stderr] ... [INFO] [stderr] 629 | push_token_name!(); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.24s [INFO] running `"docker" "inspect" "cf86079897c9c11048b1f4a83941ec36047c8a9e3f2fe7d540f523a41720b014"` [INFO] running `"docker" "rm" "-f" "cf86079897c9c11048b1f4a83941ec36047c8a9e3f2fe7d540f523a41720b014"` [INFO] [stdout] cf86079897c9c11048b1f4a83941ec36047c8a9e3f2fe7d540f523a41720b014