[INFO] updating cached repository BrandtNick/rust-user-api [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BrandtNick/rust-user-api [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BrandtNick/rust-user-api" "work/ex/clippy-test-run/sources/stable/gh/BrandtNick/rust-user-api"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BrandtNick/rust-user-api'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BrandtNick/rust-user-api" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrandtNick/rust-user-api"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrandtNick/rust-user-api'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd1241db8ff8463622672a56a5433691b2fe46ce [INFO] sha for GitHub repo BrandtNick/rust-user-api: fd1241db8ff8463622672a56a5433691b2fe46ce [INFO] validating manifest of BrandtNick/rust-user-api on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BrandtNick/rust-user-api on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BrandtNick/rust-user-api [INFO] finished frobbing BrandtNick/rust-user-api [INFO] frobbed toml for BrandtNick/rust-user-api written to work/ex/clippy-test-run/sources/stable/gh/BrandtNick/rust-user-api/Cargo.toml [INFO] started frobbing BrandtNick/rust-user-api [INFO] finished frobbing BrandtNick/rust-user-api [INFO] frobbed toml for BrandtNick/rust-user-api written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrandtNick/rust-user-api/Cargo.toml [INFO] crate BrandtNick/rust-user-api has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BrandtNick/rust-user-api against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BrandtNick/rust-user-api:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6c13133e785278d73879618d7ba92c9f663c6c48eaeb7ddc855293891b0c0274 [INFO] running `"docker" "start" "-a" "6c13133e785278d73879618d7ba92c9f663c6c48eaeb7ddc855293891b0c0274"` [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking textnonce v0.6.4 [INFO] [stderr] Checking bcrypt v0.2.0 [INFO] [stderr] Checking trust-dns-proto v0.4.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0-alpha.3 [INFO] [stderr] Checking bson v0.12.3 [INFO] [stderr] Checking jsonwebtoken v5.0.1 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking mongodb v0.3.10 [INFO] [stderr] Checking trust-dns-resolver v0.10.0-alpha.3 [INFO] [stderr] Checking actix v0.7.5 [INFO] [stderr] Checking actix-net v0.1.1 [INFO] [stderr] Checking actix-web v0.7.13 [INFO] [stderr] Checking rest-api v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/user.rs:101:41 [INFO] [stderr] | [INFO] [stderr] 101 | let exp = time_in_seconds.as_secs()+604800; [INFO] [stderr] | ^^^^^^ help: consider: `604_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/user.rs:101:41 [INFO] [stderr] | [INFO] [stderr] 101 | let exp = time_in_seconds.as_secs()+604800; [INFO] [stderr] | ^^^^^^ help: consider: `604_800` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/user.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | let mut cursor = coll.find(Some(user.clone()), None).ok().expect("Failed to execute find"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/user.rs:115:19 [INFO] [stderr] | [INFO] [stderr] 115 | Err(_) => format!("Token error") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Token error".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/user.rs:119:8 [INFO] [stderr] | [INFO] [stderr] 119 | if valid == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `valid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/user.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | let mut cursor = coll.find(Some(user.clone()), None).ok().expect("Failed to execute find"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/user.rs:115:19 [INFO] [stderr] | [INFO] [stderr] 115 | Err(_) => format!("Token error") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Token error".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/user.rs:119:8 [INFO] [stderr] | [INFO] [stderr] 119 | if valid == true { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try simplifying it as shown: `valid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `"docker" "inspect" "6c13133e785278d73879618d7ba92c9f663c6c48eaeb7ddc855293891b0c0274"` [INFO] running `"docker" "rm" "-f" "6c13133e785278d73879618d7ba92c9f663c6c48eaeb7ddc855293891b0c0274"` [INFO] [stdout] 6c13133e785278d73879618d7ba92c9f663c6c48eaeb7ddc855293891b0c0274