[INFO] updating cached repository BrandtNick/rust-space-defenders [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BrandtNick/rust-space-defenders [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BrandtNick/rust-space-defenders" "work/ex/clippy-test-run/sources/stable/gh/BrandtNick/rust-space-defenders"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BrandtNick/rust-space-defenders'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BrandtNick/rust-space-defenders" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrandtNick/rust-space-defenders"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrandtNick/rust-space-defenders'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 41482d2c671acb8681fb91d6c77cca318cb50430 [INFO] sha for GitHub repo BrandtNick/rust-space-defenders: 41482d2c671acb8681fb91d6c77cca318cb50430 [INFO] validating manifest of BrandtNick/rust-space-defenders on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BrandtNick/rust-space-defenders on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BrandtNick/rust-space-defenders [INFO] finished frobbing BrandtNick/rust-space-defenders [INFO] frobbed toml for BrandtNick/rust-space-defenders written to work/ex/clippy-test-run/sources/stable/gh/BrandtNick/rust-space-defenders/Cargo.toml [INFO] started frobbing BrandtNick/rust-space-defenders [INFO] finished frobbing BrandtNick/rust-space-defenders [INFO] frobbed toml for BrandtNick/rust-space-defenders written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BrandtNick/rust-space-defenders/Cargo.toml [INFO] crate BrandtNick/rust-space-defenders has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BrandtNick/rust-space-defenders against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BrandtNick/rust-space-defenders:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] be6681cd31d4742ab05aa5d3927dbb7c0cefcaea43ccb9a80a097b4fc09d6033 [INFO] running `"docker" "start" "-a" "be6681cd31d4742ab05aa5d3927dbb7c0cefcaea43ccb9a80a097b4fc09d6033"` [INFO] [stderr] Compiling khronos_api v3.0.0 [INFO] [stderr] Checking piston-viewport v0.5.0 [INFO] [stderr] Compiling wayland-client v0.21.4 [INFO] [stderr] Compiling wayland-protocols v0.21.4 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking pistoncore-input v0.23.0 [INFO] [stderr] Compiling gl_generator v0.10.0 [INFO] [stderr] Checking andrew v0.1.4 [INFO] [stderr] Checking piston2d-graphics v0.28.0 [INFO] [stderr] Compiling gl v0.11.0 [INFO] [stderr] Compiling glutin v0.19.0 [INFO] [stderr] Checking pistoncore-window v0.34.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.2 [INFO] [stderr] Checking pistoncore-event_loop v0.39.0 [INFO] [stderr] Checking piston v0.39.0 [INFO] [stderr] Checking winit v0.18.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.57.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.51.1 [INFO] [stderr] Checking rust-space-defender v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 52.33s [INFO] running `"docker" "inspect" "be6681cd31d4742ab05aa5d3927dbb7c0cefcaea43ccb9a80a097b4fc09d6033"` [INFO] running `"docker" "rm" "-f" "be6681cd31d4742ab05aa5d3927dbb7c0cefcaea43ccb9a80a097b4fc09d6033"` [INFO] [stdout] be6681cd31d4742ab05aa5d3927dbb7c0cefcaea43ccb9a80a097b4fc09d6033