[INFO] updating cached repository BorFour/procedural-level-generator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BorFour/procedural-level-generator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BorFour/procedural-level-generator" "work/ex/clippy-test-run/sources/stable/gh/BorFour/procedural-level-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BorFour/procedural-level-generator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BorFour/procedural-level-generator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BorFour/procedural-level-generator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BorFour/procedural-level-generator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec068f1f521a1b4cfacba63704324a7a84b5002a [INFO] sha for GitHub repo BorFour/procedural-level-generator: ec068f1f521a1b4cfacba63704324a7a84b5002a [INFO] validating manifest of BorFour/procedural-level-generator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BorFour/procedural-level-generator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BorFour/procedural-level-generator [INFO] finished frobbing BorFour/procedural-level-generator [INFO] frobbed toml for BorFour/procedural-level-generator written to work/ex/clippy-test-run/sources/stable/gh/BorFour/procedural-level-generator/Cargo.toml [INFO] started frobbing BorFour/procedural-level-generator [INFO] finished frobbing BorFour/procedural-level-generator [INFO] frobbed toml for BorFour/procedural-level-generator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BorFour/procedural-level-generator/Cargo.toml [INFO] crate BorFour/procedural-level-generator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BorFour/procedural-level-generator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BorFour/procedural-level-generator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb77146790098c6e4d93f0fa04021640e942f124853159c3593265f2244956be [INFO] running `"docker" "start" "-a" "fb77146790098c6e4d93f0fa04021640e942f124853159c3593265f2244956be"` [INFO] [stderr] Checking pathfinding v0.7.3 [INFO] [stderr] Checking rsgenetic v1.7.14 [INFO] [stderr] Checking level_generator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/design_element.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/design_element.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/design_element.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | elements: elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room_level.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room_level.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | rooms: rooms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rooms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/design_element.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/design_element.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/design_element.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | position: position, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | elements: elements, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room_level.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/level_rooms/room_level.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | rooms: rooms, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rooms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/design_element.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return |_de: &GenericDesignElement| -> i32 { 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `|_de: &GenericDesignElement| -> i32 { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/design_element.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return (self.x, self.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x, self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/room.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/level_rooms/room_level.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | None => -999999, [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/room_level.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return cp; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/room_level.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | return cp; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/room_level.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | / return self.rooms [INFO] [stderr] 207 | | .iter() [INFO] [stderr] 208 | | .map(|r| r.calculate_reward()) [INFO] [stderr] 209 | | .fold(0, |acc, len| acc + len); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 206 | self.rooms [INFO] [stderr] 207 | .iter() [INFO] [stderr] 208 | .map(|r| r.calculate_reward()) [INFO] [stderr] 209 | .fold(0, |acc, len| acc + len) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generation.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return (x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generation.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return rooms; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `rooms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `position::search_path_in_level` [INFO] [stderr] --> src/natural_selection.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use position::search_path_in_level; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/natural_selection.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return result.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/design_element.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return |_de: &GenericDesignElement| -> i32 { 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `|_de: &GenericDesignElement| -> i32 { 0 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/design_element.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return (self.x, self.y); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.x, self.y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/room.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/level_rooms/room_level.rs:104:22 [INFO] [stderr] | [INFO] [stderr] 104 | None => -999999, [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/room_level.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return cp; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/room_level.rs:169:9 [INFO] [stderr] | [INFO] [stderr] 169 | return cp; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `cp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/level_rooms/room_level.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | / return self.rooms [INFO] [stderr] 207 | | .iter() [INFO] [stderr] 208 | | .map(|r| r.calculate_reward()) [INFO] [stderr] 209 | | .fold(0, |acc, len| acc + len); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 206 | self.rooms [INFO] [stderr] 207 | .iter() [INFO] [stderr] 208 | .map(|r| r.calculate_reward()) [INFO] [stderr] 209 | .fold(0, |acc, len| acc + len) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generation.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | return (x, y); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `(x, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generation.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | return rooms; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `rooms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `position::search_path_in_level` [INFO] [stderr] --> src/natural_selection.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use position::search_path_in_level; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/natural_selection.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return result.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rsgenetic::sim::select::TournamentSelector::new': The `TournamentSelector` requires at least 2 participants. This is not enforced [INFO] [stderr] by the `new` function. You should use `new_checked` instead. [INFO] [stderr] --> src/natural_selection.rs:47:44 [INFO] [stderr] | [INFO] [stderr] 47 | .set_selector(Box::new(TournamentSelector::new(population_size/5, 10))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rsgenetic::sim::select::TournamentSelector::new': The `TournamentSelector` requires at least 2 participants. This is not enforced [INFO] [stderr] by the `new` function. You should use `new_checked` instead. [INFO] [stderr] --> src/natural_selection.rs:47:44 [INFO] [stderr] | [INFO] [stderr] 47 | .set_selector(Box::new(TournamentSelector::new(population_size/5, 10))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/level_rooms/design_element.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn reward_from_name(name: &String) -> RewardType { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/level_rooms/room_level.rs:53:52 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn get_room_from_position(&self, position: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/level_rooms/room_level.rs:85:47 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn get_rewards_from_path(&self, path: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/level_rooms/room_level.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | path.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/level_rooms/design_element.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn reward_from_name(name: &String) -> RewardType { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/level_rooms/room_level.rs:208:43 [INFO] [stderr] | [INFO] [stderr] 208 | .map(|r| r.calculate_reward()) [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 209 | | .fold(0, |acc, len| acc + len); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/level_rooms/room_level.rs:53:52 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn get_room_from_position(&self, position: &Pos) -> Option { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/level_rooms/room_level.rs:85:47 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn get_rewards_from_path(&self, path: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Pos]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/level_rooms/room_level.rs:86:14 [INFO] [stderr] | [INFO] [stderr] 86 | path.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/level_rooms/room_level.rs:208:43 [INFO] [stderr] | [INFO] [stderr] 208 | .map(|r| r.calculate_reward()) [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 209 | | .fold(0, |acc, len| acc + len); [INFO] [stderr] | |__________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/natural_selection.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn neighbours(&self) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn neighbours_with_size(&self) -> Vec<(Pos, usize)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/natural_selection.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | stdout().flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | fn distance(&self, other: &Pos) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | fn distance(&self, other: &Pos) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | fn is_equal(&self, &other: &Pos) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | fn is_equal(&self, &other: &Pos) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/position.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | let start: Pos = level.rooms[0].position.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `level.rooms[0].position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/position.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let goal: Pos = level.rooms[level.rooms.len() - 1].position.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `level.rooms[level.rooms.len() - 1].position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn neighbours(&self) -> Vec { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn neighbours_with_size(&self) -> Vec<(Pos, usize)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | fn distance(&self, other: &Pos) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | fn distance(&self, other: &Pos) -> usize { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:32:17 [INFO] [stderr] | [INFO] [stderr] 32 | fn is_equal(&self, &other: &Pos) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/position.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | fn is_equal(&self, &other: &Pos) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/position.rs:56:22 [INFO] [stderr] | [INFO] [stderr] 56 | let start: Pos = level.rooms[0].position.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `level.rooms[0].position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/position.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let goal: Pos = level.rooms[level.rooms.len() - 1].position.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `level.rooms[level.rooms.len() - 1].position` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.09s [INFO] running `"docker" "inspect" "fb77146790098c6e4d93f0fa04021640e942f124853159c3593265f2244956be"` [INFO] running `"docker" "rm" "-f" "fb77146790098c6e4d93f0fa04021640e942f124853159c3593265f2244956be"` [INFO] [stdout] fb77146790098c6e4d93f0fa04021640e942f124853159c3593265f2244956be