[INFO] updating cached repository BonsaiDen/lobby-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BonsaiDen/lobby-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BonsaiDen/lobby-server" "work/ex/clippy-test-run/sources/stable/gh/BonsaiDen/lobby-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BonsaiDen/lobby-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BonsaiDen/lobby-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BonsaiDen/lobby-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BonsaiDen/lobby-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 392d531299146486fd8f9df0de7650ef11516a1a [INFO] sha for GitHub repo BonsaiDen/lobby-server: 392d531299146486fd8f9df0de7650ef11516a1a [INFO] validating manifest of BonsaiDen/lobby-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BonsaiDen/lobby-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BonsaiDen/lobby-server [INFO] finished frobbing BonsaiDen/lobby-server [INFO] frobbed toml for BonsaiDen/lobby-server written to work/ex/clippy-test-run/sources/stable/gh/BonsaiDen/lobby-server/Cargo.toml [INFO] started frobbing BonsaiDen/lobby-server [INFO] finished frobbing BonsaiDen/lobby-server [INFO] frobbed toml for BonsaiDen/lobby-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BonsaiDen/lobby-server/Cargo.toml [INFO] crate BonsaiDen/lobby-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BonsaiDen/lobby-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BonsaiDen/lobby-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d28145fd51943ac09491050f383c88cef693398c30b3f9b744c3e002065f085 [INFO] running `"docker" "start" "-a" "7d28145fd51943ac09491050f383c88cef693398c30b3f9b744c3e002065f085"` [INFO] [stderr] Checking lbs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | let addr = self.udp_address.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.udp_address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / match self.receive() { [INFO] [stderr] 154 | | Ok(received) => for e in received { [INFO] [stderr] 155 | | match e { [INFO] [stderr] 156 | | ServerEvent::Identify(token) => { [INFO] [stderr] ... | [INFO] [stderr] 268 | | Err(_) => {} [INFO] [stderr] 269 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 153 | if let Ok(received) = self.receive() for e in received { [INFO] [stderr] 154 | match e { [INFO] [stderr] 155 | ServerEvent::Identify(token) => { [INFO] [stderr] 156 | self.udp_token = Some(token); [INFO] [stderr] 157 | }, [INFO] [stderr] 158 | ServerEvent::UdpAddress(addr) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/server.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn listen(mut self, address: A) -> Result<(), IOError> { [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | let listener = TcpListener::bind(address.clone())?; [INFO] [stderr] 53 | | listener.set_nonblocking(true)?; [INFO] [stderr] ... | [INFO] [stderr] 217 | | [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | let addr = self.udp_address.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.udp_address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:153:9 [INFO] [stderr] | [INFO] [stderr] 153 | / match self.receive() { [INFO] [stderr] 154 | | Ok(received) => for e in received { [INFO] [stderr] 155 | | match e { [INFO] [stderr] 156 | | ServerEvent::Identify(token) => { [INFO] [stderr] ... | [INFO] [stderr] 268 | | Err(_) => {} [INFO] [stderr] 269 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 153 | if let Ok(received) = self.receive() for e in received { [INFO] [stderr] 154 | match e { [INFO] [stderr] 155 | ServerEvent::Identify(token) => { [INFO] [stderr] 156 | self.udp_token = Some(token); [INFO] [stderr] 157 | }, [INFO] [stderr] 158 | ServerEvent::UdpAddress(addr) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/server.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | / pub fn listen(mut self, address: A) -> Result<(), IOError> { [INFO] [stderr] 51 | | [INFO] [stderr] 52 | | let listener = TcpListener::bind(address.clone())?; [INFO] [stderr] 53 | | listener.set_nonblocking(true)?; [INFO] [stderr] ... | [INFO] [stderr] 217 | | [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> examples/client/main.rs:59:41 [INFO] [stderr] | [INFO] [stderr] 59 | Event::LobbyJoinRequest(id, conn, payload) => { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `id` [INFO] [stderr] --> examples/client/main.rs:63:47 [INFO] [stderr] | [INFO] [stderr] 63 | Event::LobbyPreferenceRequest(id, conn, key, value) => { [INFO] [stderr] | ^^ help: consider using `_id` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `socket` [INFO] [stderr] --> examples/client/main.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | Event::LobbyStarted(id, socket, connections, pref) => { [INFO] [stderr] | ^^^^^^ help: consider using `_socket` instead [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/client/main.rs:93:23 [INFO] [stderr] | [INFO] [stderr] 93 | let arg: String = env::args().skip(1).next().unwrap_or_else(|| "create".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.74s [INFO] running `"docker" "inspect" "7d28145fd51943ac09491050f383c88cef693398c30b3f9b744c3e002065f085"` [INFO] running `"docker" "rm" "-f" "7d28145fd51943ac09491050f383c88cef693398c30b3f9b744c3e002065f085"` [INFO] [stdout] 7d28145fd51943ac09491050f383c88cef693398c30b3f9b744c3e002065f085