[INFO] updating cached repository Bolt64/sheller [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Bolt64/sheller [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Bolt64/sheller" "work/ex/clippy-test-run/sources/stable/gh/Bolt64/sheller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Bolt64/sheller'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Bolt64/sheller" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bolt64/sheller"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bolt64/sheller'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 95099a53d2f7e6b8957b8cf7006195946e3520b5 [INFO] sha for GitHub repo Bolt64/sheller: 95099a53d2f7e6b8957b8cf7006195946e3520b5 [INFO] validating manifest of Bolt64/sheller on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Bolt64/sheller on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Bolt64/sheller [INFO] finished frobbing Bolt64/sheller [INFO] frobbed toml for Bolt64/sheller written to work/ex/clippy-test-run/sources/stable/gh/Bolt64/sheller/Cargo.toml [INFO] started frobbing Bolt64/sheller [INFO] finished frobbing Bolt64/sheller [INFO] frobbed toml for Bolt64/sheller written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bolt64/sheller/Cargo.toml [INFO] crate Bolt64/sheller has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Bolt64/sheller against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Bolt64/sheller:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] edad570e1a4ca26a0bc7a2f62b370737a1d61f477abefa37f7256c2b2075f46b [INFO] running `"docker" "start" "-a" "edad570e1a4ca26a0bc7a2f62b370737a1d61f477abefa37f7256c2b2075f46b"` [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking sheller v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lexer.rs:153:55 [INFO] [stderr] | [INFO] [stderr] 153 | let quoted_part = Token::Argument(&string[fb..(lb + 1)]); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `fb..=lb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lexer.rs:202:49 [INFO] [stderr] | [INFO] [stderr] 202 | if has_balanced_apostrophes(&string[fb..(lb + 1)], '\"') { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `fb..=lb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lexer.rs:205:57 [INFO] [stderr] | [INFO] [stderr] 205 | Err(ParseError::UnbalancedQuote(&string[fb..lb + 1])) [INFO] [stderr] | ^^^^^^^^^^ help: use: `fb..=lb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lexer.rs:153:55 [INFO] [stderr] | [INFO] [stderr] 153 | let quoted_part = Token::Argument(&string[fb..(lb + 1)]); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `fb..=lb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lexer.rs:202:49 [INFO] [stderr] | [INFO] [stderr] 202 | if has_balanced_apostrophes(&string[fb..(lb + 1)], '\"') { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `fb..=lb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lexer.rs:205:57 [INFO] [stderr] | [INFO] [stderr] 205 | Err(ParseError::UnbalancedQuote(&string[fb..lb + 1])) [INFO] [stderr] | ^^^^^^^^^^ help: use: `fb..=lb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.34s [INFO] running `"docker" "inspect" "edad570e1a4ca26a0bc7a2f62b370737a1d61f477abefa37f7256c2b2075f46b"` [INFO] running `"docker" "rm" "-f" "edad570e1a4ca26a0bc7a2f62b370737a1d61f477abefa37f7256c2b2075f46b"` [INFO] [stdout] edad570e1a4ca26a0bc7a2f62b370737a1d61f477abefa37f7256c2b2075f46b