[INFO] updating cached repository Bluecodelf/rustbf [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Bluecodelf/rustbf [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Bluecodelf/rustbf" "work/ex/clippy-test-run/sources/stable/gh/Bluecodelf/rustbf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Bluecodelf/rustbf'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Bluecodelf/rustbf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bluecodelf/rustbf"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bluecodelf/rustbf'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a0322e2012d1b52e7974bb52cbb1e4f93ee41f99 [INFO] sha for GitHub repo Bluecodelf/rustbf: a0322e2012d1b52e7974bb52cbb1e4f93ee41f99 [INFO] validating manifest of Bluecodelf/rustbf on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Bluecodelf/rustbf on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Bluecodelf/rustbf [INFO] finished frobbing Bluecodelf/rustbf [INFO] frobbed toml for Bluecodelf/rustbf written to work/ex/clippy-test-run/sources/stable/gh/Bluecodelf/rustbf/Cargo.toml [INFO] started frobbing Bluecodelf/rustbf [INFO] finished frobbing Bluecodelf/rustbf [INFO] frobbed toml for Bluecodelf/rustbf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bluecodelf/rustbf/Cargo.toml [INFO] crate Bluecodelf/rustbf has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Bluecodelf/rustbf against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Bluecodelf/rustbf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ed5a4d9193d0d3b9324c112f47eebc0e6c1f9260433a69ebf8feac873b77c50 [INFO] running `"docker" "start" "-a" "1ed5a4d9193d0d3b9324c112f47eebc0e6c1f9260433a69ebf8feac873b77c50"` [INFO] [stderr] Checking rustbf v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | operation: operation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | operation: operation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `operation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ast::Ast` [INFO] [stderr] --> src/ast.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Ast { [INFO] [stderr] 43 | | Ast(Vec::new()) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/c.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match cmd { [INFO] [stderr] 22 | | &Command::PtrIncrement => print_c_line("++ptr;", indent), [INFO] [stderr] 23 | | &Command::PtrDecrement => print_c_line("--ptr;", indent), [INFO] [stderr] 24 | | &Command::DataIncrement => print_c_line("++*ptr;", indent), [INFO] [stderr] ... | [INFO] [stderr] 34 | | _ => (), [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *cmd { [INFO] [stderr] 22 | Command::PtrIncrement => print_c_line("++ptr;", indent), [INFO] [stderr] 23 | Command::PtrDecrement => print_c_line("--ptr;", indent), [INFO] [stderr] 24 | Command::DataIncrement => print_c_line("++*ptr;", indent), [INFO] [stderr] 25 | Command::DataDecrement => print_c_line("--*ptr;", indent), [INFO] [stderr] 26 | Command::Output => print_c_line("putchar(*ptr);", indent), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vm::VirtualMachine` [INFO] [stderr] --> src/vm.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> VirtualMachine { [INFO] [stderr] 14 | | VirtualMachine { [INFO] [stderr] 15 | | data: [0; 30000], [INFO] [stderr] 16 | | ptr: 0, [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for vm::VirtualMachine { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/vm.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / match cmd { [INFO] [stderr] 29 | | &Command::PtrIncrement => self.ptr += 1, [INFO] [stderr] 30 | | &Command::PtrDecrement => self.ptr -= 1, [INFO] [stderr] 31 | | &Command::DataIncrement => self.data[self.ptr] += 1, [INFO] [stderr] ... | [INFO] [stderr] 46 | | _ => (), [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *cmd { [INFO] [stderr] 29 | Command::PtrIncrement => self.ptr += 1, [INFO] [stderr] 30 | Command::PtrDecrement => self.ptr -= 1, [INFO] [stderr] 31 | Command::DataIncrement => self.data[self.ptr] += 1, [INFO] [stderr] 32 | Command::DataDecrement => self.data[self.ptr] -= 1, [INFO] [stderr] 33 | Command::Output => print!("{}", self.data[self.ptr] as char), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ast::Ast` [INFO] [stderr] --> src/ast.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / pub fn new() -> Ast { [INFO] [stderr] 43 | | Ast(Vec::new()) [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 39 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/c.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match cmd { [INFO] [stderr] 22 | | &Command::PtrIncrement => print_c_line("++ptr;", indent), [INFO] [stderr] 23 | | &Command::PtrDecrement => print_c_line("--ptr;", indent), [INFO] [stderr] 24 | | &Command::DataIncrement => print_c_line("++*ptr;", indent), [INFO] [stderr] ... | [INFO] [stderr] 34 | | _ => (), [INFO] [stderr] 35 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *cmd { [INFO] [stderr] 22 | Command::PtrIncrement => print_c_line("++ptr;", indent), [INFO] [stderr] 23 | Command::PtrDecrement => print_c_line("--ptr;", indent), [INFO] [stderr] 24 | Command::DataIncrement => print_c_line("++*ptr;", indent), [INFO] [stderr] 25 | Command::DataDecrement => print_c_line("--*ptr;", indent), [INFO] [stderr] 26 | Command::Output => print_c_line("putchar(*ptr);", indent), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `vm::VirtualMachine` [INFO] [stderr] --> src/vm.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> VirtualMachine { [INFO] [stderr] 14 | | VirtualMachine { [INFO] [stderr] 15 | | data: [0; 30000], [INFO] [stderr] 16 | | ptr: 0, [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | impl Default for vm::VirtualMachine { [INFO] [stderr] 13 | fn default() -> Self { [INFO] [stderr] 14 | Self::new() [INFO] [stderr] 15 | } [INFO] [stderr] 16 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/vm.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | / match cmd { [INFO] [stderr] 29 | | &Command::PtrIncrement => self.ptr += 1, [INFO] [stderr] 30 | | &Command::PtrDecrement => self.ptr -= 1, [INFO] [stderr] 31 | | &Command::DataIncrement => self.data[self.ptr] += 1, [INFO] [stderr] ... | [INFO] [stderr] 46 | | _ => (), [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | match *cmd { [INFO] [stderr] 29 | Command::PtrIncrement => self.ptr += 1, [INFO] [stderr] 30 | Command::PtrDecrement => self.ptr -= 1, [INFO] [stderr] 31 | Command::DataIncrement => self.data[self.ptr] += 1, [INFO] [stderr] 32 | Command::DataDecrement => self.data[self.ptr] -= 1, [INFO] [stderr] 33 | Command::Output => print!("{}", self.data[self.ptr] as char), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.29s [INFO] running `"docker" "inspect" "1ed5a4d9193d0d3b9324c112f47eebc0e6c1f9260433a69ebf8feac873b77c50"` [INFO] running `"docker" "rm" "-f" "1ed5a4d9193d0d3b9324c112f47eebc0e6c1f9260433a69ebf8feac873b77c50"` [INFO] [stdout] 1ed5a4d9193d0d3b9324c112f47eebc0e6c1f9260433a69ebf8feac873b77c50