[INFO] updating cached repository BlueSpaceCanary/rustbucket [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BlueSpaceCanary/rustbucket [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BlueSpaceCanary/rustbucket" "work/ex/clippy-test-run/sources/stable/gh/BlueSpaceCanary/rustbucket"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BlueSpaceCanary/rustbucket'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BlueSpaceCanary/rustbucket" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlueSpaceCanary/rustbucket"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlueSpaceCanary/rustbucket'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 605e70161b6b3717c2aa8fe415a40d59c185b9b6 [INFO] sha for GitHub repo BlueSpaceCanary/rustbucket: 605e70161b6b3717c2aa8fe415a40d59c185b9b6 [INFO] validating manifest of BlueSpaceCanary/rustbucket on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BlueSpaceCanary/rustbucket on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BlueSpaceCanary/rustbucket [INFO] finished frobbing BlueSpaceCanary/rustbucket [INFO] frobbed toml for BlueSpaceCanary/rustbucket written to work/ex/clippy-test-run/sources/stable/gh/BlueSpaceCanary/rustbucket/Cargo.toml [INFO] started frobbing BlueSpaceCanary/rustbucket [INFO] finished frobbing BlueSpaceCanary/rustbucket [INFO] frobbed toml for BlueSpaceCanary/rustbucket written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlueSpaceCanary/rustbucket/Cargo.toml [INFO] crate BlueSpaceCanary/rustbucket has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BlueSpaceCanary/rustbucket against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BlueSpaceCanary/rustbucket:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b50083e89117f6072313ff9fe7da67af4ac51d8e8f49d76b1a5dae68a025df4 [INFO] running `"docker" "start" "-a" "4b50083e89117f6072313ff9fe7da67af4ac51d8e8f49d76b1a5dae68a025df4"` [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-mockstream v1.1.0 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-reactor v0.1.5 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking irc v0.13.5 [INFO] [stderr] Checking rustbucket v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factoid.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factoid.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | verbs: verbs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verbs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factoid.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/factoid.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | verbs: verbs, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `verbs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::rngs::SmallRng` [INFO] [stderr] --> src/factoid.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rand::rngs::SmallRng; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | Err(e) => panic!("AHHHH"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/factoid.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_rng_seed` [INFO] [stderr] --> src/factoid.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn set_rng_seed(&mut self, seed: [u8; 16]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/factoid.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | fn get_factoid<'a>(&'a mut self, &String) -> Option<&'a String>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/factoid.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | fn literal_factoid(&self, &String) -> String; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/factoid.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | let name_index = s.find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/factoid.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | .or_insert(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/factoid.rs:82:30 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn creates_factoid(name: &String, verbs: &Vec, s: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/factoid.rs:82:46 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn creates_factoid(name: &String, verbs: &Vec, s: &String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/factoid.rs:82:63 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn creates_factoid(name: &String, verbs: &Vec, s: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `rand::rngs::SmallRng` [INFO] [stderr] --> src/factoid.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use rand::rngs::SmallRng; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/main.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | Err(e) => panic!("AHHHH"), [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/factoid.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/factoid.rs:33:38 [INFO] [stderr] | [INFO] [stderr] 33 | fn get_factoid<'a>(&'a mut self, &String) -> Option<&'a String>; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/factoid.rs:34:31 [INFO] [stderr] | [INFO] [stderr] 34 | fn literal_factoid(&self, &String) -> String; [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/factoid.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | let name_index = s.find(":").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/factoid.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | .or_insert(vec![]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/factoid.rs:82:30 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn creates_factoid(name: &String, verbs: &Vec, s: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/factoid.rs:82:46 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn creates_factoid(name: &String, verbs: &Vec, s: &String) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/factoid.rs:82:63 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn creates_factoid(name: &String, verbs: &Vec, s: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/factoid.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | brain.create_factoid("sidra: foo is bar".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/factoid.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | brain.hippocampus.get("foo").unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&brain.hippocampus["foo"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/factoid.rs:125:9 [INFO] [stderr] | [INFO] [stderr] 125 | brain.create_factoid("sidra: foo is bar".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/factoid.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | brain.create_factoid("sidra: foo is zip".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/factoid.rs:166:9 [INFO] [stderr] | [INFO] [stderr] 166 | brain.create_factoid("sidra: foo is zip".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.56s [INFO] running `"docker" "inspect" "4b50083e89117f6072313ff9fe7da67af4ac51d8e8f49d76b1a5dae68a025df4"` [INFO] running `"docker" "rm" "-f" "4b50083e89117f6072313ff9fe7da67af4ac51d8e8f49d76b1a5dae68a025df4"` [INFO] [stdout] 4b50083e89117f6072313ff9fe7da67af4ac51d8e8f49d76b1a5dae68a025df4