[INFO] updating cached repository BlinfoldKing/pong-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BlinfoldKing/pong-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BlinfoldKing/pong-rs" "work/ex/clippy-test-run/sources/stable/gh/BlinfoldKing/pong-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BlinfoldKing/pong-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BlinfoldKing/pong-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlinfoldKing/pong-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlinfoldKing/pong-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 63aa4a78c2c45f8d4fd96058b8f951a30baadad6 [INFO] sha for GitHub repo BlinfoldKing/pong-rs: 63aa4a78c2c45f8d4fd96058b8f951a30baadad6 [INFO] validating manifest of BlinfoldKing/pong-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BlinfoldKing/pong-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BlinfoldKing/pong-rs [INFO] finished frobbing BlinfoldKing/pong-rs [INFO] frobbed toml for BlinfoldKing/pong-rs written to work/ex/clippy-test-run/sources/stable/gh/BlinfoldKing/pong-rs/Cargo.toml [INFO] started frobbing BlinfoldKing/pong-rs [INFO] finished frobbing BlinfoldKing/pong-rs [INFO] frobbed toml for BlinfoldKing/pong-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BlinfoldKing/pong-rs/Cargo.toml [INFO] crate BlinfoldKing/pong-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BlinfoldKing/pong-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BlinfoldKing/pong-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db19f13a7454a9b8b0883cbd943e470caf3570b4e87ccafd3fe4d9ee6abd8a53 [INFO] running `"docker" "start" "-a" "db19f13a7454a9b8b0883cbd943e470caf3570b4e87ccafd3fe4d9ee6abd8a53"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Compiling glutin v0.14.0 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking piston-gfx_texture v0.26.0 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking piston2d-gfx_graphics v0.43.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking glutin v0.9.2 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.1 [INFO] [stderr] Checking piston_window v0.70.0 [INFO] [stderr] Checking pong-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let mut opengl = OpenGL::V3_2; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | self.position[0] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | self.position[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | self.position[0] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | self.position[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | (self.position[0] + 20) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[0] + 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | (self.position[1] + 100) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[1] + 100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method `moveDown` should have a snake case name such as `move_down` [INFO] [stderr] --> src/main.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / fn moveDown(&mut self, speed: f32) { [INFO] [stderr] 116 | | if self.position[1] < 400 { [INFO] [stderr] 117 | | self.position[1] += (20.0 * speed) as i32 [INFO] [stderr] 118 | | }; [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method `moveUp` should have a snake case name such as `move_up` [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / fn moveUp(&mut self, speed: f32) { [INFO] [stderr] 122 | | if self.position[1] > 0 { [INFO] [stderr] 123 | | self.position[1] -= (20.0 * speed) as i32 [INFO] [stderr] 124 | | }; [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | let y = ((self.ball.position[1] + 10) - (self.player.position[1] + 50)) as f64 / 50.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.ball.position[1] + 10) - (self.player.position[1] + 50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | let y = ((self.ball.position[1] + 10) - (self.player.position[1] + 50)) as f64 / 50.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.ball.position[1] + 10) - (self.player.position[1] + 50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | let mut opengl = OpenGL::V3_2; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `reset` [INFO] [stderr] --> src/main.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | fn reset(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | self.position[0] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | self.position[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | self.position[0] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | self.position[1] as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | (self.position[0] + 20) as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[0] + 20)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | (self.position[1] + 100) as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.position[1] + 100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: method `moveDown` should have a snake case name such as `move_down` [INFO] [stderr] --> src/main.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / fn moveDown(&mut self, speed: f32) { [INFO] [stderr] 116 | | if self.position[1] < 400 { [INFO] [stderr] 117 | | self.position[1] += (20.0 * speed) as i32 [INFO] [stderr] 118 | | }; [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method `moveUp` should have a snake case name such as `move_up` [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / fn moveUp(&mut self, speed: f32) { [INFO] [stderr] 122 | | if self.position[1] > 0 { [INFO] [stderr] 123 | | self.position[1] -= (20.0 * speed) as i32 [INFO] [stderr] 124 | | }; [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:149:25 [INFO] [stderr] | [INFO] [stderr] 149 | let y = ((self.ball.position[1] + 10) - (self.player.position[1] + 50)) as f64 / 50.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.ball.position[1] + 10) - (self.player.position[1] + 50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | let y = ((self.ball.position[1] + 10) - (self.player.position[1] + 50)) as f64 / 50.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.ball.position[1] + 10) - (self.player.position[1] + 50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `"docker" "inspect" "db19f13a7454a9b8b0883cbd943e470caf3570b4e87ccafd3fe4d9ee6abd8a53"` [INFO] running `"docker" "rm" "-f" "db19f13a7454a9b8b0883cbd943e470caf3570b4e87ccafd3fe4d9ee6abd8a53"` [INFO] [stdout] db19f13a7454a9b8b0883cbd943e470caf3570b4e87ccafd3fe4d9ee6abd8a53