[INFO] updating cached repository BjarkePedersen/Mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BjarkePedersen/Mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BjarkePedersen/Mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/BjarkePedersen/Mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BjarkePedersen/Mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BjarkePedersen/Mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BjarkePedersen/Mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BjarkePedersen/Mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3f03960e5699c5531621cf792d71b132dcf95db5 [INFO] sha for GitHub repo BjarkePedersen/Mandelbrot: 3f03960e5699c5531621cf792d71b132dcf95db5 [INFO] validating manifest of BjarkePedersen/Mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BjarkePedersen/Mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BjarkePedersen/Mandelbrot [INFO] finished frobbing BjarkePedersen/Mandelbrot [INFO] frobbed toml for BjarkePedersen/Mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/BjarkePedersen/Mandelbrot/Cargo.toml [INFO] started frobbing BjarkePedersen/Mandelbrot [INFO] finished frobbing BjarkePedersen/Mandelbrot [INFO] frobbed toml for BjarkePedersen/Mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BjarkePedersen/Mandelbrot/Cargo.toml [INFO] crate BjarkePedersen/Mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BjarkePedersen/Mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BjarkePedersen/Mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 20a65bb9bc97dfbb21f165d6b1e4b7b0c8e4eb31d02d76a518be48e1f591a1d7 [INFO] running `"docker" "start" "-a" "20a65bb9bc97dfbb21f165d6b1e4b7b0c8e4eb31d02d76a518be48e1f591a1d7"` [INFO] [stderr] Compiling minifb v0.10.7 [INFO] [stderr] Checking x11-dl v2.14.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking mandlebrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | Col { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | Col { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | Col { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/helpers.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | let g = if (h % 1.0) < 1.0 / 3.0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/helpers.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | let b = if (h % 1.0) < 2.0 / 3.0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:23:15 [INFO] [stderr] | [INFO] [stderr] 23 | Col { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | Col { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/helpers.rs:23:27 [INFO] [stderr] | [INFO] [stderr] 23 | Col { r: r, g: g, b: b } [INFO] [stderr] | ^^^^ help: replace it with: `b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/helpers.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | let g = if (h % 1.0) < 1.0 / 3.0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/helpers.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | let b = if (h % 1.0) < 2.0 / 3.0 { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `cgmath::Vector3` [INFO] [stderr] --> src/helpers.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use cgmath::Vector3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `HEIGHT` [INFO] [stderr] --> src/helpers.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | use {HEIGHT, WIDTH}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `cgmath::Vector3` [INFO] [stderr] --> src/helpers.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use cgmath::Vector3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `HEIGHT` [INFO] [stderr] --> src/helpers.rs:7:6 [INFO] [stderr] | [INFO] [stderr] 7 | use {HEIGHT, WIDTH}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/helpers.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | r: self.r + val, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/helpers.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | g: self.g + val, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/helpers.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | b: self.b + val, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | window.get_keys_pressed(KeyRepeat::No).map(|keys| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 39 | || for t in keys { [INFO] [stderr] 40 | || match t { [INFO] [stderr] 41 | || Key::Enter => (bw = !bw), [INFO] [stderr] ... || [INFO] [stderr] 48 | || } [INFO] [stderr] 49 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(keys) = window.get_keys_pressed(KeyRepeat::No) { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | window.get_keys().map(|keys| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 52 | || for t in keys { [INFO] [stderr] 53 | || match t { [INFO] [stderr] 54 | || Key::W => (y_offset -= 0.15 * zoom), [INFO] [stderr] ... || [INFO] [stderr] 66 | || } [INFO] [stderr] 67 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(keys) = window.get_keys() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:40 [INFO] [stderr] | [INFO] [stderr] 94 | let nu = (log_zn / (2 as f64).log(10.0)).log(10.0) / (2 as f64).log(10.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | let nu = (log_zn / (2 as f64).log(10.0)).log(10.0) / (2 as f64).log(10.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mandlebrot`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/helpers.rs:56:23 [INFO] [stderr] | [INFO] [stderr] 56 | r: self.r + val, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/helpers.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | g: self.g + val, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/helpers.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | b: self.b + val, [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | window.get_keys_pressed(KeyRepeat::No).map(|keys| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 39 | || for t in keys { [INFO] [stderr] 40 | || match t { [INFO] [stderr] 41 | || Key::Enter => (bw = !bw), [INFO] [stderr] ... || [INFO] [stderr] 48 | || } [INFO] [stderr] 49 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(keys) = window.get_keys_pressed(KeyRepeat::No) { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | window.get_keys().map(|keys| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 52 | || for t in keys { [INFO] [stderr] 53 | || match t { [INFO] [stderr] 54 | || Key::W => (y_offset -= 0.15 * zoom), [INFO] [stderr] ... || [INFO] [stderr] 66 | || } [INFO] [stderr] 67 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(keys) = window.get_keys() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:40 [INFO] [stderr] | [INFO] [stderr] 94 | let nu = (log_zn / (2 as f64).log(10.0)).log(10.0) / (2 as f64).log(10.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:74 [INFO] [stderr] | [INFO] [stderr] 94 | let nu = (log_zn / (2 as f64).log(10.0)).log(10.0) / (2 as f64).log(10.0); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mandlebrot`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "20a65bb9bc97dfbb21f165d6b1e4b7b0c8e4eb31d02d76a518be48e1f591a1d7"` [INFO] running `"docker" "rm" "-f" "20a65bb9bc97dfbb21f165d6b1e4b7b0c8e4eb31d02d76a518be48e1f591a1d7"` [INFO] [stdout] 20a65bb9bc97dfbb21f165d6b1e4b7b0c8e4eb31d02d76a518be48e1f591a1d7