[INFO] updating cached repository Bestra/rust-weekend-raytracer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Bestra/rust-weekend-raytracer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Bestra/rust-weekend-raytracer" "work/ex/clippy-test-run/sources/stable/gh/Bestra/rust-weekend-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Bestra/rust-weekend-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Bestra/rust-weekend-raytracer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bestra/rust-weekend-raytracer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bestra/rust-weekend-raytracer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f4b9903d037396543bc4eba270de1dbce31f7a7 [INFO] sha for GitHub repo Bestra/rust-weekend-raytracer: 2f4b9903d037396543bc4eba270de1dbce31f7a7 [INFO] validating manifest of Bestra/rust-weekend-raytracer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Bestra/rust-weekend-raytracer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Bestra/rust-weekend-raytracer [INFO] finished frobbing Bestra/rust-weekend-raytracer [INFO] frobbed toml for Bestra/rust-weekend-raytracer written to work/ex/clippy-test-run/sources/stable/gh/Bestra/rust-weekend-raytracer/Cargo.toml [INFO] started frobbing Bestra/rust-weekend-raytracer [INFO] finished frobbing Bestra/rust-weekend-raytracer [INFO] frobbed toml for Bestra/rust-weekend-raytracer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Bestra/rust-weekend-raytracer/Cargo.toml [INFO] crate Bestra/rust-weekend-raytracer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Bestra/rust-weekend-raytracer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Bestra/rust-weekend-raytracer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30dd78fd35b5d3848841c6edf14c3ba157591d61f8e837f65551b79886eea842 [INFO] running `"docker" "start" "-a" "30dd78fd35b5d3848841c6edf14c3ba157591d61f8e837f65551b79886eea842"` [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking weekend-raytracer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let t = temp_minus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let p = r.point_at_parameter(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | let t = temp_plus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | let p = r.point_at_parameter(temp_plus); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | let t = temp_minus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let p = r.point_at_parameter(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | let t = temp_plus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | let p = r.point_at_parameter(temp_plus); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | attenuation: attenuation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attenuation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | let t = temp_minus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let p = r.point_at_parameter(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | let t = temp_plus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | let p = r.point_at_parameter(temp_plus); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:144:21 [INFO] [stderr] | [INFO] [stderr] 144 | let t = temp_minus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:145:21 [INFO] [stderr] | [INFO] [stderr] 145 | let p = r.point_at_parameter(t); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:158:21 [INFO] [stderr] | [INFO] [stderr] 158 | let t = temp_plus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/geo.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | let p = r.point_at_parameter(temp_plus); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:371:13 [INFO] [stderr] | [INFO] [stderr] 371 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/geo.rs:372:13 [INFO] [stderr] | [INFO] [stderr] 372 | right: right, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/material.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | attenuation: attenuation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `attenuation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/camera.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new( [INFO] [stderr] 17 | | look_from: Vec3, [INFO] [stderr] 18 | | look_at: Vec3, [INFO] [stderr] 19 | | v_up: Vec3, [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/geo.rs:396:13 [INFO] [stderr] | [INFO] [stderr] 396 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geo.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | / match item.hit(&r.clone(), t_min, closest_so_far) { [INFO] [stderr] 206 | | Some(temp_rec) => { [INFO] [stderr] 207 | | closest_so_far = temp_rec.t; [INFO] [stderr] 208 | | hit = Some(temp_rec) [INFO] [stderr] ... | [INFO] [stderr] 211 | | None => (), [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | if let Some(temp_rec) = item.hit(&r.clone(), t_min, closest_so_far) { [INFO] [stderr] 206 | closest_so_far = temp_rec.t; [INFO] [stderr] 207 | hit = Some(temp_rec) [INFO] [stderr] 208 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/geo.rs:219:12 [INFO] [stderr] | [INFO] [stderr] 219 | if self.list.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:244:25 [INFO] [stderr] | [INFO] [stderr] 244 | pub fn box_x_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:244:44 [INFO] [stderr] | [INFO] [stderr] 244 | pub fn box_x_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:257:25 [INFO] [stderr] | [INFO] [stderr] 257 | pub fn box_y_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:257:44 [INFO] [stderr] | [INFO] [stderr] 257 | pub fn box_y_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:270:25 [INFO] [stderr] | [INFO] [stderr] 270 | pub fn box_z_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:270:44 [INFO] [stderr] | [INFO] [stderr] 270 | pub fn box_z_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:289:23 [INFO] [stderr] | [INFO] [stderr] 289 | pub fn box_compare(a: &Box, b: &Box, axis: Axis) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:289:42 [INFO] [stderr] | [INFO] [stderr] 289 | pub fn box_compare(a: &Box, b: &Box, axis: Axis) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | let center = vec3(a as f64 + 0.9 * v1, 0.2, b as f64 + 0.9 * v2); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:24:57 [INFO] [stderr] | [INFO] [stderr] 24 | let center = vec3(a as f64 + 0.9 * v1, 0.2, b as f64 + 0.9 * v2); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | let r = cam.get_ray(u, v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:60:25 [INFO] [stderr] | [INFO] [stderr] 60 | let r = cam.get_ray(u, v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/camera.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new( [INFO] [stderr] 17 | | look_from: Vec3, [INFO] [stderr] 18 | | look_at: Vec3, [INFO] [stderr] 19 | | v_up: Vec3, [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/geo.rs:205:13 [INFO] [stderr] | [INFO] [stderr] 205 | / match item.hit(&r.clone(), t_min, closest_so_far) { [INFO] [stderr] 206 | | Some(temp_rec) => { [INFO] [stderr] 207 | | closest_so_far = temp_rec.t; [INFO] [stderr] 208 | | hit = Some(temp_rec) [INFO] [stderr] ... | [INFO] [stderr] 211 | | None => (), [INFO] [stderr] 212 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | if let Some(temp_rec) = item.hit(&r.clone(), t_min, closest_so_far) { [INFO] [stderr] 206 | closest_so_far = temp_rec.t; [INFO] [stderr] 207 | hit = Some(temp_rec) [INFO] [stderr] 208 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/geo.rs:219:12 [INFO] [stderr] | [INFO] [stderr] 219 | if self.list.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:244:25 [INFO] [stderr] | [INFO] [stderr] 244 | pub fn box_x_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:244:44 [INFO] [stderr] | [INFO] [stderr] 244 | pub fn box_x_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:257:25 [INFO] [stderr] | [INFO] [stderr] 257 | pub fn box_y_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:257:44 [INFO] [stderr] | [INFO] [stderr] 257 | pub fn box_y_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:270:25 [INFO] [stderr] | [INFO] [stderr] 270 | pub fn box_z_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:270:44 [INFO] [stderr] | [INFO] [stderr] 270 | pub fn box_z_compare(a: &Box, b: &Box) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:289:23 [INFO] [stderr] | [INFO] [stderr] 289 | pub fn box_compare(a: &Box, b: &Box, axis: Axis) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/geo.rs:289:42 [INFO] [stderr] | [INFO] [stderr] 289 | pub fn box_compare(a: &Box, b: &Box, axis: Axis) -> Ordering { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Hittable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | let center = vec3(a as f64 + 0.9 * v1, 0.2, b as f64 + 0.9 * v2); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene.rs:24:57 [INFO] [stderr] | [INFO] [stderr] 24 | let center = vec3(a as f64 + 0.9 * v1, 0.2, b as f64 + 0.9 * v2); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused imports: `random_scene`, `simple_spheres` [INFO] [stderr] --> src/main.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | use weekend_raytracer::scene::{random_scene, simple_spheres, sphere_tree}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `random_scene`, `simple_spheres` [INFO] [stderr] --> src/main.rs:16:32 [INFO] [stderr] | [INFO] [stderr] 16 | use weekend_raytracer::scene::{random_scene, simple_spheres, sphere_tree}; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | nx as f64 / ny as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | nx as f64 / ny as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:46 [INFO] [stderr] | [INFO] [stderr] 58 | let u = (i as f64 + a) / nx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:46 [INFO] [stderr] | [INFO] [stderr] 59 | let v = (j as f64 + b) / ny as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | let col = total_color / ns as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let ref mut w = BufWriter::new(file); [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let w = &mut BufWriter::new(file);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | nx as f64 / ny as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | nx as f64 / ny as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:46 [INFO] [stderr] | [INFO] [stderr] 58 | let u = (i as f64 + a) / nx as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(nx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:46 [INFO] [stderr] | [INFO] [stderr] 59 | let v = (j as f64 + b) / ny as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ny)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:41 [INFO] [stderr] | [INFO] [stderr] 64 | let col = total_color / ns as f64; [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(ns)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | let ref mut w = BufWriter::new(file); [INFO] [stderr] | ----^^^^^^^^^------------------------ help: try: `let w = &mut BufWriter::new(file);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.70s [INFO] running `"docker" "inspect" "30dd78fd35b5d3848841c6edf14c3ba157591d61f8e837f65551b79886eea842"` [INFO] running `"docker" "rm" "-f" "30dd78fd35b5d3848841c6edf14c3ba157591d61f8e837f65551b79886eea842"` [INFO] [stdout] 30dd78fd35b5d3848841c6edf14c3ba157591d61f8e837f65551b79886eea842