[INFO] updating cached repository Beskhue/advent-of-code-2017 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Beskhue/advent-of-code-2017 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Beskhue/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable/gh/Beskhue/advent-of-code-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Beskhue/advent-of-code-2017'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Beskhue/advent-of-code-2017" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Beskhue/advent-of-code-2017"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Beskhue/advent-of-code-2017'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0252981713d6b1c7fb04ff979a5011290892ba12 [INFO] sha for GitHub repo Beskhue/advent-of-code-2017: 0252981713d6b1c7fb04ff979a5011290892ba12 [INFO] validating manifest of Beskhue/advent-of-code-2017 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Beskhue/advent-of-code-2017 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Beskhue/advent-of-code-2017 [INFO] finished frobbing Beskhue/advent-of-code-2017 [INFO] frobbed toml for Beskhue/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable/gh/Beskhue/advent-of-code-2017/Cargo.toml [INFO] started frobbing Beskhue/advent-of-code-2017 [INFO] finished frobbing Beskhue/advent-of-code-2017 [INFO] frobbed toml for Beskhue/advent-of-code-2017 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Beskhue/advent-of-code-2017/Cargo.toml [INFO] crate Beskhue/advent-of-code-2017 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Beskhue/advent-of-code-2017 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Beskhue/advent-of-code-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2cc2a8711ae469e7a343f38255e0e63bfa8e069b8ec2b1a08b6ac390b08056ce [INFO] running `"docker" "start" "-a" "2cc2a8711ae469e7a343f38255e0e63bfa8e069b8ec2b1a08b6ac390b08056ce"` [INFO] [stderr] Checking ordermap v0.3.2 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Checking advent_of_code_2017 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december05.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | fn num_steps_to_exit(instructions: &Vec, next_offset: fn(i32) -> i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 14 | fn num_steps_to_exit(instructions: &[i32], next_offset: fn(i32) -> i32) -> i32 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `instructions.clone()` to [INFO] [stderr] | [INFO] [stderr] 20 | let mut instructions_copy = instructions.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/december05.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(while_true)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/december08.rs:10:38 [INFO] [stderr] | [INFO] [stderr] 10 | let instrs: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/december08.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | let test_register = registers.entry(instrs[4].to_string()).or_insert(0).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*registers.entry(instrs[4].to_string()).or_insert(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/december08.rs:10:38 [INFO] [stderr] | [INFO] [stderr] 10 | let instrs: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/december08.rs:12:23 [INFO] [stderr] | [INFO] [stderr] 12 | let test_register = registers.entry(instrs[4].to_string()).or_insert(0).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*registers.entry(instrs[4].to_string()).or_insert(0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december04.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | fn count_valid_passphrases(lines: &Vec, anagrams_allowed: bool) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/december04.rs:19:61 [INFO] [stderr] | [INFO] [stderr] 19 | let mut passphrase: Vec = line.trim().split(" ").map(|s| s.to_owned()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december06.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | fn redistribute_once(memory: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/december06.rs:15:8 [INFO] [stderr] | [INFO] [stderr] 15 | if memory.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `memory.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/december06.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | let mut new_memory: Vec = memory.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/december06.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(while_true)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/december06.rs:75:50 [INFO] [stderr] | [INFO] [stderr] 75 | let memory: Vec = lines[0].trim().split("\t").map(|num| num.parse::().unwrap()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/december06.rs:77:64 [INFO] [stderr] | [INFO] [stderr] 77 | println!("Part 1: {:#?}", redistribute_until_loop_detected(memory.iter().cloned().collect(), false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/december03.rs:152:62 [INFO] [stderr] | [INFO] [stderr] 152 | println!("Part 1: {:#?}", calc_steps_to_port_brute_force(265149)); [INFO] [stderr] | ^^^^^^ help: consider: `265_149` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/december03.rs:153:68 [INFO] [stderr] | [INFO] [stderr] 153 | println!("Part 2: {:#?}", find_first_written_value_larger_than(265149)); [INFO] [stderr] | ^^^^^^ help: consider: `265_149` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable `cur_location` is assigned to, but never used [INFO] [stderr] --> src/december03.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let mut cur_location = 1; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_cur_location` instead [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/december03.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(while_true)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december04.rs:14:35 [INFO] [stderr] | [INFO] [stderr] 14 | fn count_valid_passphrases(lines: &Vec, anagrams_allowed: bool) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/december04.rs:19:61 [INFO] [stderr] | [INFO] [stderr] 19 | let mut passphrase: Vec = line.trim().split(" ").map(|s| s.to_owned()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/december03.rs:152:62 [INFO] [stderr] | [INFO] [stderr] 152 | println!("Part 1: {:#?}", calc_steps_to_port_brute_force(265149)); [INFO] [stderr] | ^^^^^^ help: consider: `265_149` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/december03.rs:153:68 [INFO] [stderr] | [INFO] [stderr] 153 | println!("Part 2: {:#?}", find_first_written_value_larger_than(265149)); [INFO] [stderr] | ^^^^^^ help: consider: `265_149` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/december02.rs:17:59 [INFO] [stderr] | [INFO] [stderr] 17 | let nums: Result, _> = line.trim().split("\t").map(str::parse).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december02.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | fn calc_checksum(spreadsheet: &Vec>) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december02.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | fn calc_evenly_divisible_numbers(spreadsheet: &Vec>) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/december02.rs:17:59 [INFO] [stderr] | [INFO] [stderr] 17 | let nums: Result, _> = line.trim().split("\t").map(str::parse).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december02.rs:23:31 [INFO] [stderr] | [INFO] [stderr] 23 | fn calc_checksum(spreadsheet: &Vec>) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december02.rs:34:47 [INFO] [stderr] | [INFO] [stderr] 34 | fn calc_evenly_divisible_numbers(spreadsheet: &Vec>) -> i32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december06.rs:14:30 [INFO] [stderr] | [INFO] [stderr] 14 | fn redistribute_once(memory: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/december06.rs:15:8 [INFO] [stderr] | [INFO] [stderr] 15 | if memory.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `memory.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/december06.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | let mut new_memory: Vec = memory.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/december06.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(while_true)] on by default [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/december06.rs:75:50 [INFO] [stderr] | [INFO] [stderr] 75 | let memory: Vec = lines[0].trim().split("\t").map(|num| num.parse::().unwrap()).collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\t'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/december06.rs:77:64 [INFO] [stderr] | [INFO] [stderr] 77 | println!("Part 1: {:#?}", redistribute_until_loop_detected(memory.iter().cloned().collect(), false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: variable `cur_location` is assigned to, but never used [INFO] [stderr] --> src/december03.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let mut cur_location = 1; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] = note: consider using `_cur_location` instead [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/december03.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(while_true)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/december05.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | fn num_steps_to_exit(instructions: &Vec, next_offset: fn(i32) -> i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 14 | fn num_steps_to_exit(instructions: &[i32], next_offset: fn(i32) -> i32) -> i32 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] help: change `instructions.clone()` to [INFO] [stderr] | [INFO] [stderr] 20 | let mut instructions_copy = instructions.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: denote infinite loops with `loop { ... }` [INFO] [stderr] --> src/december05.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | while true { [INFO] [stderr] | ^^^^^^^^^^ help: use `loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(while_true)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/december07.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | matches[2..].iter().cloned().collect::>() // Adjacencies [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/december07.rs:95:50 [INFO] [stderr] | [INFO] [stderr] 95 | let correct_weight = normal_weight - (&graph[neighbor_node_id].total_weight - &graph[neighbor_node_id].weight); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 95 | let correct_weight = normal_weight - (graph[neighbor_node_id].total_weight - graph[neighbor_node_id].weight); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/december07.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | matches[2..].iter().cloned().collect::>() // Adjacencies [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/december07.rs:95:50 [INFO] [stderr] | [INFO] [stderr] 95 | let correct_weight = normal_weight - (&graph[neighbor_node_id].total_weight - &graph[neighbor_node_id].weight); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 95 | let correct_weight = normal_weight - (graph[neighbor_node_id].total_weight - graph[neighbor_node_id].weight); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.87s [INFO] running `"docker" "inspect" "2cc2a8711ae469e7a343f38255e0e63bfa8e069b8ec2b1a08b6ac390b08056ce"` [INFO] running `"docker" "rm" "-f" "2cc2a8711ae469e7a343f38255e0e63bfa8e069b8ec2b1a08b6ac390b08056ce"` [INFO] [stdout] 2cc2a8711ae469e7a343f38255e0e63bfa8e069b8ec2b1a08b6ac390b08056ce