[INFO] updating cached repository BenjaminEckardt/metrix [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BenjaminEckardt/metrix [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BenjaminEckardt/metrix" "work/ex/clippy-test-run/sources/stable/gh/BenjaminEckardt/metrix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BenjaminEckardt/metrix'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BenjaminEckardt/metrix" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenjaminEckardt/metrix"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenjaminEckardt/metrix'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2b67938ab2eb0456347651d6a96f2911470bea5b [INFO] sha for GitHub repo BenjaminEckardt/metrix: 2b67938ab2eb0456347651d6a96f2911470bea5b [INFO] validating manifest of BenjaminEckardt/metrix on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BenjaminEckardt/metrix on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BenjaminEckardt/metrix [INFO] finished frobbing BenjaminEckardt/metrix [INFO] frobbed toml for BenjaminEckardt/metrix written to work/ex/clippy-test-run/sources/stable/gh/BenjaminEckardt/metrix/Cargo.toml [INFO] started frobbing BenjaminEckardt/metrix [INFO] finished frobbing BenjaminEckardt/metrix [INFO] frobbed toml for BenjaminEckardt/metrix written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenjaminEckardt/metrix/Cargo.toml [INFO] crate BenjaminEckardt/metrix has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BenjaminEckardt/metrix against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BenjaminEckardt/metrix:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a3009f52923637b92d65ee3fee6a73186be5ad7bc3de6c8a88c76dbf8cc2b83c [INFO] running `"docker" "start" "-a" "a3009f52923637b92d65ee3fee6a73186be5ad7bc3de6c8a88c76dbf8cc2b83c"` [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking globset v0.2.0 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking ignore v0.2.2 [INFO] [stderr] Checking metrix v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metrics.rs:5:32 [INFO] [stderr] | [INFO] [stderr] 5 | .filter(|trimmed_line| trimmed_line.len() != 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!trimmed_line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / Walk::new(current_dir) [INFO] [stderr] 77 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `Walk::new(current_dir)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/metrics.rs:5:32 [INFO] [stderr] | [INFO] [stderr] 5 | .filter(|trimmed_line| trimmed_line.len() != 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!trimmed_line.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / Walk::new(current_dir) [INFO] [stderr] 77 | | .into_iter() [INFO] [stderr] | |____________________^ help: consider removing `.into_iter()`: `Walk::new(current_dir)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.25s [INFO] running `"docker" "inspect" "a3009f52923637b92d65ee3fee6a73186be5ad7bc3de6c8a88c76dbf8cc2b83c"` [INFO] running `"docker" "rm" "-f" "a3009f52923637b92d65ee3fee6a73186be5ad7bc3de6c8a88c76dbf8cc2b83c"` [INFO] [stdout] a3009f52923637b92d65ee3fee6a73186be5ad7bc3de6c8a88c76dbf8cc2b83c