[INFO] updating cached repository BenMatteson/CS410_Rust_Project [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BenMatteson/CS410_Rust_Project [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BenMatteson/CS410_Rust_Project" "work/ex/clippy-test-run/sources/stable/gh/BenMatteson/CS410_Rust_Project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BenMatteson/CS410_Rust_Project'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BenMatteson/CS410_Rust_Project" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenMatteson/CS410_Rust_Project"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenMatteson/CS410_Rust_Project'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4445635fd8eb9851286c680685f9e7e3c7dcdb86 [INFO] sha for GitHub repo BenMatteson/CS410_Rust_Project: 4445635fd8eb9851286c680685f9e7e3c7dcdb86 [INFO] validating manifest of BenMatteson/CS410_Rust_Project on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BenMatteson/CS410_Rust_Project on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BenMatteson/CS410_Rust_Project [INFO] finished frobbing BenMatteson/CS410_Rust_Project [INFO] frobbed toml for BenMatteson/CS410_Rust_Project written to work/ex/clippy-test-run/sources/stable/gh/BenMatteson/CS410_Rust_Project/Cargo.toml [INFO] started frobbing BenMatteson/CS410_Rust_Project [INFO] finished frobbing BenMatteson/CS410_Rust_Project [INFO] frobbed toml for BenMatteson/CS410_Rust_Project written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BenMatteson/CS410_Rust_Project/Cargo.toml [INFO] crate BenMatteson/CS410_Rust_Project has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BenMatteson/CS410_Rust_Project against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BenMatteson/CS410_Rust_Project:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14db8bf6bd7c96cae06ad157776beba2d9f5c76b5e7e353ae06d9bc534e667c0 [INFO] running `"docker" "start" "-a" "14db8bf6bd7c96cae06ad157776beba2d9f5c76b5e7e353ae06d9bc534e667c0"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking rawslice v0.1.0 [INFO] [stderr] Checking x11-dl v2.18.1 [INFO] [stderr] Checking pistoncore-window v0.32.0 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking odds v0.3.1 [INFO] [stderr] Checking pistoncore-event_loop v0.37.0 [INFO] [stderr] Checking tempfile v3.0.3 [INFO] [stderr] Checking piston v0.37.0 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking winit v0.12.0 [INFO] [stderr] Checking piston-gfx_texture v0.32.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.53.0 [INFO] [stderr] Checking glutin v0.14.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.51.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.47.0 [INFO] [stderr] Checking piston_window v0.80.0 [INFO] [stderr] Checking game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | Key::W => match release { [INFO] [stderr] | _______________________^ [INFO] [stderr] 59 | | false => self.movement.up = SPEED, [INFO] [stderr] 60 | | true => self.movement.up = 0.0, [INFO] [stderr] 61 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if release { self.movement.up = 0.0 } else { self.movement.up = SPEED }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | Key::A => match release { [INFO] [stderr] | _______________________^ [INFO] [stderr] 63 | | false => self.movement.left = SPEED, [INFO] [stderr] 64 | | true => self.movement.left = 0.0, [INFO] [stderr] 65 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if release { self.movement.left = 0.0 } else { self.movement.left = SPEED }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | Key::S => match release { [INFO] [stderr] | _______________________^ [INFO] [stderr] 67 | | false => self.movement.down = SPEED, [INFO] [stderr] 68 | | true => self.movement.down = 0.0, [INFO] [stderr] 69 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if release { self.movement.down = 0.0 } else { self.movement.down = SPEED }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | Key::D => match release { [INFO] [stderr] | _______________________^ [INFO] [stderr] 71 | | false => self.movement.right = SPEED, [INFO] [stderr] 72 | | true => self.movement.right = 0.0, [INFO] [stderr] 73 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if release { self.movement.right = 0.0 } else { self.movement.right = SPEED }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / match self.fire_key_down { [INFO] [stderr] 151 | | true => Some(self.fire()), [INFO] [stderr] 152 | | false => None, [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.fire_key_down { Some(self.fire()) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity/mod.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | fn update(&mut self, args: &UpdateArgs) -> Option>> { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:102:32 [INFO] [stderr] | [INFO] [stderr] 102 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / match self.player.update(args) { [INFO] [stderr] 149 | | Some(mut shots) => self.entities.append(&mut shots), [INFO] [stderr] 150 | | None => (), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(mut shots) = self.player.update(args) { self.entities.append(&mut shots) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | / match entity.update(args) { [INFO] [stderr] 162 | | Some(mut shots) => new_entities.append(&mut shots), [INFO] [stderr] 163 | | None => {} [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(mut shots) = entity.update(args) { new_entities.append(&mut shots) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | Key::W => match release { [INFO] [stderr] | _______________________^ [INFO] [stderr] 59 | | false => self.movement.up = SPEED, [INFO] [stderr] 60 | | true => self.movement.up = 0.0, [INFO] [stderr] 61 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if release { self.movement.up = 0.0 } else { self.movement.up = SPEED }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:62:23 [INFO] [stderr] | [INFO] [stderr] 62 | Key::A => match release { [INFO] [stderr] | _______________________^ [INFO] [stderr] 63 | | false => self.movement.left = SPEED, [INFO] [stderr] 64 | | true => self.movement.left = 0.0, [INFO] [stderr] 65 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if release { self.movement.left = 0.0 } else { self.movement.left = SPEED }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:66:23 [INFO] [stderr] | [INFO] [stderr] 66 | Key::S => match release { [INFO] [stderr] | _______________________^ [INFO] [stderr] 67 | | false => self.movement.down = SPEED, [INFO] [stderr] 68 | | true => self.movement.down = 0.0, [INFO] [stderr] 69 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if release { self.movement.down = 0.0 } else { self.movement.down = SPEED }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | Key::D => match release { [INFO] [stderr] | _______________________^ [INFO] [stderr] 71 | | false => self.movement.right = SPEED, [INFO] [stderr] 72 | | true => self.movement.right = 0.0, [INFO] [stderr] 73 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if release { self.movement.right = 0.0 } else { self.movement.right = SPEED }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/entity/player.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | / match self.fire_key_down { [INFO] [stderr] 151 | | true => Some(self.fire()), [INFO] [stderr] 152 | | false => None, [INFO] [stderr] 153 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.fire_key_down { Some(self.fire()) } else { None }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/entity/mod.rs:19:32 [INFO] [stderr] | [INFO] [stderr] 19 | fn update(&mut self, args: &UpdateArgs) -> Option>> { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:102:32 [INFO] [stderr] | [INFO] [stderr] 102 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | / match self.player.update(args) { [INFO] [stderr] 149 | | Some(mut shots) => self.entities.append(&mut shots), [INFO] [stderr] 150 | | None => (), [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(mut shots) = self.player.update(args) { self.entities.append(&mut shots) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | / match entity.update(args) { [INFO] [stderr] 162 | | Some(mut shots) => new_entities.append(&mut shots), [INFO] [stderr] 163 | | None => {} [INFO] [stderr] 164 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(mut shots) = entity.update(args) { new_entities.append(&mut shots) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.58s [INFO] running `"docker" "inspect" "14db8bf6bd7c96cae06ad157776beba2d9f5c76b5e7e353ae06d9bc534e667c0"` [INFO] running `"docker" "rm" "-f" "14db8bf6bd7c96cae06ad157776beba2d9f5c76b5e7e353ae06d9bc534e667c0"` [INFO] [stdout] 14db8bf6bd7c96cae06ad157776beba2d9f5c76b5e7e353ae06d9bc534e667c0