[INFO] updating cached repository BeatButton/pixiv-dl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BeatButton/pixiv-dl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BeatButton/pixiv-dl" "work/ex/clippy-test-run/sources/stable/gh/BeatButton/pixiv-dl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BeatButton/pixiv-dl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BeatButton/pixiv-dl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BeatButton/pixiv-dl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BeatButton/pixiv-dl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e285f8d29e0b8392795da74e3b622dad7be445cd [INFO] sha for GitHub repo BeatButton/pixiv-dl: e285f8d29e0b8392795da74e3b622dad7be445cd [INFO] validating manifest of BeatButton/pixiv-dl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BeatButton/pixiv-dl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BeatButton/pixiv-dl [INFO] finished frobbing BeatButton/pixiv-dl [INFO] frobbed toml for BeatButton/pixiv-dl written to work/ex/clippy-test-run/sources/stable/gh/BeatButton/pixiv-dl/Cargo.toml [INFO] started frobbing BeatButton/pixiv-dl [INFO] finished frobbing BeatButton/pixiv-dl [INFO] frobbed toml for BeatButton/pixiv-dl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BeatButton/pixiv-dl/Cargo.toml [INFO] crate BeatButton/pixiv-dl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BeatButton/pixiv-dl against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BeatButton/pixiv-dl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 923fb529d7bba3eac0cc95df818b0e6ac2e31e19b4fddf92db9debf725fdbf68 [INFO] running `"docker" "start" "-a" "923fb529d7bba3eac0cc95df818b0e6ac2e31e19b4fddf92db9debf725fdbf68"` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling quote v0.6.9 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.4 [INFO] [stderr] Checking pixiv-dl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | downloader: downloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `downloader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | downloader: downloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `downloader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:92:13 [INFO] [stderr] | [INFO] [stderr] 92 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(mut resp) => match resp["illusts"].as_array_mut() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 110 | | Some(illusts) => { [INFO] [stderr] 111 | | self.illusts.append(illusts); [INFO] [stderr] 112 | | self.offset += 30; [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | None => {} [INFO] [stderr] 115 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | Ok(mut resp) => if let Some(illusts) = resp["illusts"].as_array_mut() { [INFO] [stderr] 110 | self.illusts.append(illusts); [INFO] [stderr] 111 | self.offset += 30; [INFO] [stderr] 112 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:237:37 [INFO] [stderr] | [INFO] [stderr] 237 | / match dirname [INFO] [stderr] 238 | | .chars() [INFO] [stderr] 239 | | .enumerate() [INFO] [stderr] 240 | | .filter(|(_, ch)| !['+', '=', '-', '_'].contains(ch)) [INFO] [stderr] ... | [INFO] [stderr] 262 | | None => {} [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 237 | if let Some(idx) = dirname [INFO] [stderr] 238 | .chars() [INFO] [stderr] 239 | .enumerate() [INFO] [stderr] 240 | .filter(|(_, ch)| !['+', '=', '-', '_'].contains(ch)) [INFO] [stderr] 241 | .map(|(idx, _)| idx) [INFO] [stderr] 242 | .next() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:400:38 [INFO] [stderr] | [INFO] [stderr] 400 | &zip_url[..zip_url.rfind("/").unwrap()], [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:109:33 [INFO] [stderr] | [INFO] [stderr] 109 | Ok(mut resp) => match resp["illusts"].as_array_mut() { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 110 | | Some(illusts) => { [INFO] [stderr] 111 | | self.illusts.append(illusts); [INFO] [stderr] 112 | | self.offset += 30; [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | None => {} [INFO] [stderr] 115 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 109 | Ok(mut resp) => if let Some(illusts) = resp["illusts"].as_array_mut() { [INFO] [stderr] 110 | self.illusts.append(illusts); [INFO] [stderr] 111 | self.offset += 30; [INFO] [stderr] 112 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:237:37 [INFO] [stderr] | [INFO] [stderr] 237 | / match dirname [INFO] [stderr] 238 | | .chars() [INFO] [stderr] 239 | | .enumerate() [INFO] [stderr] 240 | | .filter(|(_, ch)| !['+', '=', '-', '_'].contains(ch)) [INFO] [stderr] ... | [INFO] [stderr] 262 | | None => {} [INFO] [stderr] 263 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 237 | if let Some(idx) = dirname [INFO] [stderr] 238 | .chars() [INFO] [stderr] 239 | .enumerate() [INFO] [stderr] 240 | .filter(|(_, ch)| !['+', '=', '-', '_'].contains(ch)) [INFO] [stderr] 241 | .map(|(idx, _)| idx) [INFO] [stderr] 242 | .next() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:400:38 [INFO] [stderr] | [INFO] [stderr] 400 | &zip_url[..zip_url.rfind("/").unwrap()], [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "923fb529d7bba3eac0cc95df818b0e6ac2e31e19b4fddf92db9debf725fdbf68"` [INFO] running `"docker" "rm" "-f" "923fb529d7bba3eac0cc95df818b0e6ac2e31e19b4fddf92db9debf725fdbf68"` [INFO] [stdout] 923fb529d7bba3eac0cc95df818b0e6ac2e31e19b4fddf92db9debf725fdbf68