[INFO] updating cached repository BearzRobotics/c2f [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BearzRobotics/c2f [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BearzRobotics/c2f" "work/ex/clippy-test-run/sources/stable/gh/BearzRobotics/c2f"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BearzRobotics/c2f'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BearzRobotics/c2f" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BearzRobotics/c2f"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BearzRobotics/c2f'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f2c87b9eaf1c8e686579caa6691bd43a2bf004e8 [INFO] sha for GitHub repo BearzRobotics/c2f: f2c87b9eaf1c8e686579caa6691bd43a2bf004e8 [INFO] validating manifest of BearzRobotics/c2f on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BearzRobotics/c2f on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BearzRobotics/c2f [INFO] finished frobbing BearzRobotics/c2f [INFO] frobbed toml for BearzRobotics/c2f written to work/ex/clippy-test-run/sources/stable/gh/BearzRobotics/c2f/Cargo.toml [INFO] started frobbing BearzRobotics/c2f [INFO] finished frobbing BearzRobotics/c2f [INFO] frobbed toml for BearzRobotics/c2f written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BearzRobotics/c2f/Cargo.toml [INFO] crate BearzRobotics/c2f has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BearzRobotics/c2f against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BearzRobotics/c2f:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7e87bf6c53148dade52a0ffa4c9043f9695aec4138f32c3e559176f04c77e13e [INFO] running `"docker" "start" "-a" "7e87bf6c53148dade52a0ffa4c9043f9695aec4138f32c3e559176f04c77e13e"` [INFO] [stderr] Checking c2f v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::process` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::process; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | resualts [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | let resualts = degree * (1.8) + 32.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | resualts [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | let resualts = (degree - 32.0) * (0.555555556); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:61:39 [INFO] [stderr] | [INFO] [stderr] 61 | let resualts = (degree - 32.0) * (0.555555556); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.555_555_556` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/main.rs:61:38 [INFO] [stderr] | [INFO] [stderr] 61 | let resualts = (degree - 32.0) * (0.555555556); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.555_555_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | for i in staring_range..ending_range + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `staring_range..=ending_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | for i in staring_range..ending_range + 1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `staring_range..=ending_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::process` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::process; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | resualts [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | let resualts = degree * (1.8) + 32.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | resualts [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | let resualts = (degree - 32.0) * (0.555555556); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:61:39 [INFO] [stderr] | [INFO] [stderr] 61 | let resualts = (degree - 32.0) * (0.555555556); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.555_555_556` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/main.rs:61:38 [INFO] [stderr] | [INFO] [stderr] 61 | let resualts = (degree - 32.0) * (0.555555556); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.555_555_6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:83:18 [INFO] [stderr] | [INFO] [stderr] 83 | for i in staring_range..ending_range + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `staring_range..=ending_range` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | for i in staring_range..ending_range + 1{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `staring_range..=ending_range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.06s [INFO] running `"docker" "inspect" "7e87bf6c53148dade52a0ffa4c9043f9695aec4138f32c3e559176f04c77e13e"` [INFO] running `"docker" "rm" "-f" "7e87bf6c53148dade52a0ffa4c9043f9695aec4138f32c3e559176f04c77e13e"` [INFO] [stdout] 7e87bf6c53148dade52a0ffa4c9043f9695aec4138f32c3e559176f04c77e13e