[INFO] updating cached repository Beamed/DeprecatedGame00x [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Beamed/DeprecatedGame00x [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Beamed/DeprecatedGame00x" "work/ex/clippy-test-run/sources/stable/gh/Beamed/DeprecatedGame00x"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Beamed/DeprecatedGame00x'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Beamed/DeprecatedGame00x" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Beamed/DeprecatedGame00x"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Beamed/DeprecatedGame00x'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1d3a870670f962028f82cad4c3dd9880fa4c4bf1 [INFO] sha for GitHub repo Beamed/DeprecatedGame00x: 1d3a870670f962028f82cad4c3dd9880fa4c4bf1 [INFO] validating manifest of Beamed/DeprecatedGame00x on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Beamed/DeprecatedGame00x on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Beamed/DeprecatedGame00x [INFO] finished frobbing Beamed/DeprecatedGame00x [INFO] frobbed toml for Beamed/DeprecatedGame00x written to work/ex/clippy-test-run/sources/stable/gh/Beamed/DeprecatedGame00x/Cargo.toml [INFO] started frobbing Beamed/DeprecatedGame00x [INFO] finished frobbing Beamed/DeprecatedGame00x [INFO] frobbed toml for Beamed/DeprecatedGame00x written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Beamed/DeprecatedGame00x/Cargo.toml [INFO] crate Beamed/DeprecatedGame00x has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Beamed/DeprecatedGame00x against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Beamed/DeprecatedGame00x:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d1685015deef7930c8a7f2034be52b60ee00f26f7d08efb892828c2bc61631e6 [INFO] running `"docker" "start" "-a" "d1685015deef7930c8a7f2034be52b60ee00f26f7d08efb892828c2bc61631e6"` [INFO] [stderr] Compiling x11-dl v2.17.1 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking miniz-sys v0.1.10 [INFO] [stderr] Checking serde-value v0.5.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking log4rs v0.7.0 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking piston2d-opengl_graphics v0.50.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking RustyRogue v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/map/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/map/mod.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/map/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/actor/fighter.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/map/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/map/mod.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/map/mod.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | tiles: tiles, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tiles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/model/actor/fighter.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::path; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Debug` [INFO] [stderr] --> src/model/map/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fmt::Debug; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/map/mod.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return new_self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/view/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `OpenGL` [INFO] [stderr] --> src/view/mod.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | use opengl_graphics::{ GlGraphics, OpenGL, GlyphCache, TextureSettings }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Graphics` [INFO] [stderr] --> src/view/mod.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | use graphics::{Graphics, Context}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `OpenGL` [INFO] [stderr] --> src/view/console_view.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | use opengl_graphics::{ GlGraphics, OpenGL, GlyphCache }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/view/map_view/map_tile.rs:41:44 [INFO] [stderr] | [INFO] [stderr] 41 | let font_size : u32 = cmp::min((2 * self.width as u32 / 3), (2 * self.height as u32 / 3)) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/view/map_view/map_tile.rs:41:73 [INFO] [stderr] | [INFO] [stderr] 41 | let font_size : u32 = cmp::min((2 * self.width as u32 / 3), (2 * self.height as u32 / 3)) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `OpenGL` [INFO] [stderr] --> src/view/map_view/mod.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | use opengl_graphics::{ GlGraphics, OpenGL, GlyphCache }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `glutin_window as Window` [INFO] [stderr] --> src/view/map_view/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use glutin_window as Window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/view/map_view/mod.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | let tile_width = ((map_dim.mapw_end - map_dim.mapw_start)/ VIEW_WIDTH); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/view/map_view/mod.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | let tile_height = ((map_dim.maph_end - map_dim.maph_start) / VIEW_HEIGHT); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning[E0170]: pattern binding `Player` is named the same as one of the variants of the type `model::actor::ActorType` [INFO] [stderr] --> src/view/map_view/map_tile.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | Player => '@' [INFO] [stderr] | ^^^^^^ help: to match on the variant, qualify the path: `model::actor::ActorType::Player` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `Player` [INFO] [stderr] --> src/view/map_view/map_tile.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | Player => '@' [INFO] [stderr] | ^^^^^^ help: consider using `_Player` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `done` [INFO] [stderr] --> src/main.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | Ok(done) => info!("Exiting Chi"), [INFO] [stderr] | ^^^^ help: consider using `_done` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `view_error` [INFO] [stderr] --> src/controller/mod.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | Err(view_error) => error!("View notification failed."), [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_view_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `width` [INFO] [stderr] --> src/controller/mod.rs:81:34 [INFO] [stderr] | [INFO] [stderr] 81 | fn window_resized(&mut self, width: u32, height: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_width` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/controller/mod.rs:81:46 [INFO] [stderr] | [INFO] [stderr] 81 | fn window_resized(&mut self, width: u32, height: u32) { [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/model/map/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | for y in 0..self.height { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/model/map/mod.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | for x in 0..self.width { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index` [INFO] [stderr] --> src/model/map/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let index = self.get_index_from_coordinates(x, y).expect("Unable to find index of tile"); [INFO] [stderr] | ^^^^^ help: consider using `_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/view/console_view.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | fn notify(&mut self, m: &Model, glyphs: &mut GlyphCache, ctx: &mut Context, gfx: &mut GlGraphics, res: [u32; 2]) { [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `glyphs` [INFO] [stderr] --> src/view/console_view.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | fn notify(&mut self, m: &Model, glyphs: &mut GlyphCache, ctx: &mut Context, gfx: &mut GlGraphics, res: [u32; 2]) { [INFO] [stderr] | ^^^^^^ help: consider using `_glyphs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_on_tile` [INFO] [stderr] --> src/view/map_view/mod.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | let player_on_tile = row == center_y && col == center_x; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_player_on_tile` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `window` [INFO] [stderr] --> src/view/mod.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn notify(&mut self, m: &Model, window: &mut Window, gfx: &mut GlGraphics, args: RenderArgs) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_window` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/controller/mod.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut window : Window = WindowSettings::new("Chi", [1024, 768]).opengl(opengl).exit_on_esc(true).build().expect("Unable to initialize OpenGL context"); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/controller/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let mut events = Events::new(EventSettings::new().lazy(true)); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/controller/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let mut gfx = GlGraphics::new(opengl); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/model/map/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut tiles : Vec = Vec::with_capacity((width * height) as usize); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_actor` [INFO] [stderr] --> src/model/map/tile.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn set_actor(&mut self, actor: Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `remove_actor` [INFO] [stderr] --> src/model/map/tile.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn remove_actor(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tile_mut` [INFO] [stderr] --> src/model/map/mod.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | fn get_tile_mut(&mut self, x: u32, y: u32) -> Result<&mut Tile, MapError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_tile` [INFO] [stderr] --> src/model/map/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn set_tile(&mut self, x: u32, y: u32, new_tile: Tile) -> Result<&Tile, MapError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tiles` [INFO] [stderr] --> src/model/map/mod.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn get_tiles(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `place_actor_at_location` [INFO] [stderr] --> src/model/map/mod.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn place_actor_at_location(&mut self, x: u32, y: u32, actor: Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Enemy` [INFO] [stderr] --> src/model/actor/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Enemy, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `RustyRogue` should have a snake case name such as `rusty_rogue` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/controller/mod.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | / match self.views.notify(&self.model, &mut window, &mut gfx, args) { [INFO] [stderr] 60 | | Err(view_error) => error!("View notification failed."), [INFO] [stderr] 61 | | _ => ()//no-op if it worked [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Err(view_error) = self.views.notify(&self.model, &mut window, &mut gfx, args) { error!("View notification failed.") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/controller/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match button_enum { [INFO] [stderr] 86 | | Button::Keyboard(button) => self.pushed_key(button), [INFO] [stderr] 87 | | _ => () [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ help: try this: `if let Button::Keyboard(button) = button_enum { self.pushed_key(button) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/console_view.rs:32:47 [INFO] [stderr] | [INFO] [stderr] 32 | let dimensions = rectangle_by_corners((width/4) as f64, (3*(height/4)) as f64, (3 * (width/4)) as f64, (height + 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(width/4)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/console_view.rs:32:65 [INFO] [stderr] | [INFO] [stderr] 32 | let dimensions = rectangle_by_corners((width/4) as f64, (3*(height/4)) as f64, (3 * (width/4)) as f64, (height + 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(3*(height/4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/console_view.rs:32:88 [INFO] [stderr] | [INFO] [stderr] 32 | let dimensions = rectangle_by_corners((width/4) as f64, (3*(height/4)) as f64, (3 * (width/4)) as f64, (height + 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(3 * (width/4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/console_view.rs:32:112 [INFO] [stderr] | [INFO] [stderr] 32 | let dimensions = rectangle_by_corners((width/4) as f64, (3*(height/4)) as f64, (3 * (width/4)) as f64, (height + 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(height + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `Player` should have a snake case name such as `player` [INFO] [stderr] --> src/view/map_view/map_tile.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | Player => '@' [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/view/map_view/map_tile.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / if let &Some(ref actor) = model.get_actor_at_location(self.coord.0, self.coord.1) { [INFO] [stderr] 39 | | debug!("Rendering actor at location: ({}, {})", self.coord.0, self.coord.1); [INFO] [stderr] 40 | | let symbol = fetch_player_symbol(actor.get_actor_type()); [INFO] [stderr] 41 | | let font_size : u32 = cmp::min((2 * self.width as u32 / 3), (2 * self.height as u32 / 3)) + 1; [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(ref actor) = *model.get_actor_at_location(self.coord.0, self.coord.1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/map_tile.rs:48:63 [INFO] [stderr] | [INFO] [stderr] 48 | ctx.transform.trans(self.start_corner_x + font_size as f64 / 3., self.start_corner_y + font_size as f64 / 3.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/map_tile.rs:48:108 [INFO] [stderr] | [INFO] [stderr] 48 | ctx.transform.trans(self.start_corner_x + font_size as f64 / 3., self.start_corner_y + font_size as f64 / 3.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/mod.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | MapDimensions::new((width/4) as f64, (3 * width / 4) as f64 , -1., (3 * height / 4) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(width/4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/mod.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | MapDimensions::new((width/4) as f64, (3 * width / 4) as f64 , -1., (3 * height / 4) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(3 * width / 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/mod.rs:40:72 [INFO] [stderr] | [INFO] [stderr] 40 | MapDimensions::new((width/4) as f64, (3 * width / 4) as f64 , -1., (3 * height / 4) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(3 * height / 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(VIEW_HEIGHT as u32)` [INFO] [stderr] --> src/view/map_view/mod.rs:75:59 [INFO] [stderr] | [INFO] [stderr] 75 | let bottom_bound = get_largest_in_limit(center_y, (VIEW_HEIGHT as u32) + 1 / 2, model.get_map_height()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::env` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use std::env; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use std::path; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Debug` [INFO] [stderr] --> src/model/map/mod.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use std::fmt::Debug; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/model/map/mod.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return new_self; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::collections::HashMap` [INFO] [stderr] --> src/view/mod.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::collections::HashMap; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `OpenGL` [INFO] [stderr] --> src/view/mod.rs:4:36 [INFO] [stderr] | [INFO] [stderr] 4 | use opengl_graphics::{ GlGraphics, OpenGL, GlyphCache, TextureSettings }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Graphics` [INFO] [stderr] --> src/view/mod.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | use graphics::{Graphics, Context}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `OpenGL` [INFO] [stderr] --> src/view/console_view.rs:3:36 [INFO] [stderr] | [INFO] [stderr] 3 | use opengl_graphics::{ GlGraphics, OpenGL, GlyphCache }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/view/map_view/map_tile.rs:41:44 [INFO] [stderr] | [INFO] [stderr] 41 | let font_size : u32 = cmp::min((2 * self.width as u32 / 3), (2 * self.height as u32 / 3)) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/view/map_view/map_tile.rs:41:73 [INFO] [stderr] | [INFO] [stderr] 41 | let font_size : u32 = cmp::min((2 * self.width as u32 / 3), (2 * self.height as u32 / 3)) + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `OpenGL` [INFO] [stderr] --> src/view/map_view/mod.rs:5:36 [INFO] [stderr] | [INFO] [stderr] 5 | use opengl_graphics::{ GlGraphics, OpenGL, GlyphCache }; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `glutin_window as Window` [INFO] [stderr] --> src/view/map_view/mod.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use glutin_window as Window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/view/map_view/mod.rs:79:27 [INFO] [stderr] | [INFO] [stderr] 79 | let tile_width = ((map_dim.mapw_end - map_dim.mapw_start)/ VIEW_WIDTH); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/view/map_view/mod.rs:80:28 [INFO] [stderr] | [INFO] [stderr] 80 | let tile_height = ((map_dim.maph_end - map_dim.maph_start) / VIEW_HEIGHT); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning[E0170]: pattern binding `Player` is named the same as one of the variants of the type `model::actor::ActorType` [INFO] [stderr] --> src/view/map_view/map_tile.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | Player => '@' [INFO] [stderr] | ^^^^^^ help: to match on the variant, qualify the path: `model::actor::ActorType::Player` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `Player` [INFO] [stderr] --> src/view/map_view/map_tile.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | Player => '@' [INFO] [stderr] | ^^^^^^ help: consider using `_Player` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `done` [INFO] [stderr] --> src/main.rs:24:12 [INFO] [stderr] | [INFO] [stderr] 24 | Ok(done) => info!("Exiting Chi"), [INFO] [stderr] | ^^^^ help: consider using `_done` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `view_error` [INFO] [stderr] --> src/controller/mod.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | Err(view_error) => error!("View notification failed."), [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_view_error` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `width` [INFO] [stderr] --> src/controller/mod.rs:81:34 [INFO] [stderr] | [INFO] [stderr] 81 | fn window_resized(&mut self, width: u32, height: u32) { [INFO] [stderr] | ^^^^^ help: consider using `_width` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/controller/mod.rs:81:46 [INFO] [stderr] | [INFO] [stderr] 81 | fn window_resized(&mut self, width: u32, height: u32) { [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `y` [INFO] [stderr] --> src/model/map/mod.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | for y in 0..self.height { [INFO] [stderr] | ^ help: consider using `_y` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/model/map/mod.rs:62:17 [INFO] [stderr] | [INFO] [stderr] 62 | for x in 0..self.width { [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `index` [INFO] [stderr] --> src/model/map/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | let index = self.get_index_from_coordinates(x, y).expect("Unable to find index of tile"); [INFO] [stderr] | ^^^^^ help: consider using `_index` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `m` [INFO] [stderr] --> src/view/console_view.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | fn notify(&mut self, m: &Model, glyphs: &mut GlyphCache, ctx: &mut Context, gfx: &mut GlGraphics, res: [u32; 2]) { [INFO] [stderr] | ^ help: consider using `_m` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `glyphs` [INFO] [stderr] --> src/view/console_view.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | fn notify(&mut self, m: &Model, glyphs: &mut GlyphCache, ctx: &mut Context, gfx: &mut GlGraphics, res: [u32; 2]) { [INFO] [stderr] | ^^^^^^ help: consider using `_glyphs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player_on_tile` [INFO] [stderr] --> src/view/map_view/mod.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | let player_on_tile = row == center_y && col == center_x; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_player_on_tile` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `window` [INFO] [stderr] --> src/view/mod.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn notify(&mut self, m: &Model, window: &mut Window, gfx: &mut GlGraphics, args: RenderArgs) -> Result { [INFO] [stderr] | ^^^^^^ help: consider using `_window` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/controller/mod.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut window : Window = WindowSettings::new("Chi", [1024, 768]).opengl(opengl).exit_on_esc(true).build().expect("Unable to initialize OpenGL context"); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/controller/mod.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | let mut events = Events::new(EventSettings::new().lazy(true)); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/controller/mod.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let mut gfx = GlGraphics::new(opengl); [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/model/map/mod.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let mut tiles : Vec = Vec::with_capacity((width * height) as usize); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_actor` [INFO] [stderr] --> src/model/map/tile.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn set_actor(&mut self, actor: Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `remove_actor` [INFO] [stderr] --> src/model/map/tile.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn remove_actor(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tile_mut` [INFO] [stderr] --> src/model/map/mod.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | fn get_tile_mut(&mut self, x: u32, y: u32) -> Result<&mut Tile, MapError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_tile` [INFO] [stderr] --> src/model/map/mod.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn set_tile(&mut self, x: u32, y: u32, new_tile: Tile) -> Result<&Tile, MapError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `get_tiles` [INFO] [stderr] --> src/model/map/mod.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn get_tiles(&self) -> &Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `place_actor_at_location` [INFO] [stderr] --> src/model/map/mod.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn place_actor_at_location(&mut self, x: u32, y: u32, actor: Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Enemy` [INFO] [stderr] --> src/model/actor/mod.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | Enemy, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: crate `RustyRogue` should have a snake case name such as `rusty_rogue` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/controller/mod.rs:59:21 [INFO] [stderr] | [INFO] [stderr] 59 | / match self.views.notify(&self.model, &mut window, &mut gfx, args) { [INFO] [stderr] 60 | | Err(view_error) => error!("View notification failed."), [INFO] [stderr] 61 | | _ => ()//no-op if it worked [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Err(view_error) = self.views.notify(&self.model, &mut window, &mut gfx, args) { error!("View notification failed.") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/controller/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match button_enum { [INFO] [stderr] 86 | | Button::Keyboard(button) => self.pushed_key(button), [INFO] [stderr] 87 | | _ => () [INFO] [stderr] 88 | | } [INFO] [stderr] | |_________^ help: try this: `if let Button::Keyboard(button) = button_enum { self.pushed_key(button) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/console_view.rs:32:47 [INFO] [stderr] | [INFO] [stderr] 32 | let dimensions = rectangle_by_corners((width/4) as f64, (3*(height/4)) as f64, (3 * (width/4)) as f64, (height + 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(width/4)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/console_view.rs:32:65 [INFO] [stderr] | [INFO] [stderr] 32 | let dimensions = rectangle_by_corners((width/4) as f64, (3*(height/4)) as f64, (3 * (width/4)) as f64, (height + 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(3*(height/4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/console_view.rs:32:88 [INFO] [stderr] | [INFO] [stderr] 32 | let dimensions = rectangle_by_corners((width/4) as f64, (3*(height/4)) as f64, (3 * (width/4)) as f64, (height + 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(3 * (width/4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/console_view.rs:32:112 [INFO] [stderr] | [INFO] [stderr] 32 | let dimensions = rectangle_by_corners((width/4) as f64, (3*(height/4)) as f64, (3 * (width/4)) as f64, (height + 1) as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(height + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: variable `Player` should have a snake case name such as `player` [INFO] [stderr] --> src/view/map_view/map_tile.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | Player => '@' [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/view/map_view/map_tile.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / if let &Some(ref actor) = model.get_actor_at_location(self.coord.0, self.coord.1) { [INFO] [stderr] 39 | | debug!("Rendering actor at location: ({}, {})", self.coord.0, self.coord.1); [INFO] [stderr] 40 | | let symbol = fetch_player_symbol(actor.get_actor_type()); [INFO] [stderr] 41 | | let font_size : u32 = cmp::min((2 * self.width as u32 / 3), (2 * self.height as u32 / 3)) + 1; [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(ref actor) = *model.get_actor_at_location(self.coord.0, self.coord.1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/map_tile.rs:48:63 [INFO] [stderr] | [INFO] [stderr] 48 | ctx.transform.trans(self.start_corner_x + font_size as f64 / 3., self.start_corner_y + font_size as f64 / 3.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/map_tile.rs:48:108 [INFO] [stderr] | [INFO] [stderr] 48 | ctx.transform.trans(self.start_corner_x + font_size as f64 / 3., self.start_corner_y + font_size as f64 / 3.), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(font_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/mod.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | MapDimensions::new((width/4) as f64, (3 * width / 4) as f64 , -1., (3 * height / 4) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(width/4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/mod.rs:40:42 [INFO] [stderr] | [INFO] [stderr] 40 | MapDimensions::new((width/4) as f64, (3 * width / 4) as f64 , -1., (3 * height / 4) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(3 * width / 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/view/map_view/mod.rs:40:72 [INFO] [stderr] | [INFO] [stderr] 40 | MapDimensions::new((width/4) as f64, (3 * width / 4) as f64 , -1., (3 * height / 4) as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(3 * height / 4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(VIEW_HEIGHT as u32)` [INFO] [stderr] --> src/view/map_view/mod.rs:75:59 [INFO] [stderr] | [INFO] [stderr] 75 | let bottom_bound = get_largest_in_limit(center_y, (VIEW_HEIGHT as u32) + 1 / 2, model.get_map_height()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "d1685015deef7930c8a7f2034be52b60ee00f26f7d08efb892828c2bc61631e6"` [INFO] running `"docker" "rm" "-f" "d1685015deef7930c8a7f2034be52b60ee00f26f7d08efb892828c2bc61631e6"` [INFO] [stdout] d1685015deef7930c8a7f2034be52b60ee00f26f7d08efb892828c2bc61631e6