[INFO] updating cached repository Basti110/ray-tracing [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Basti110/ray-tracing [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Basti110/ray-tracing" "work/ex/clippy-test-run/sources/stable/gh/Basti110/ray-tracing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Basti110/ray-tracing'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Basti110/ray-tracing" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Basti110/ray-tracing"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Basti110/ray-tracing'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8c78e70e563ff8022d54f50e53c92a750561d9ab [INFO] sha for GitHub repo Basti110/ray-tracing: 8c78e70e563ff8022d54f50e53c92a750561d9ab [INFO] validating manifest of Basti110/ray-tracing on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Basti110/ray-tracing on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Basti110/ray-tracing [INFO] finished frobbing Basti110/ray-tracing [INFO] frobbed toml for Basti110/ray-tracing written to work/ex/clippy-test-run/sources/stable/gh/Basti110/ray-tracing/Cargo.toml [INFO] started frobbing Basti110/ray-tracing [INFO] finished frobbing Basti110/ray-tracing [INFO] frobbed toml for Basti110/ray-tracing written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Basti110/ray-tracing/Cargo.toml [INFO] crate Basti110/ray-tracing has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Basti110/ray-tracing against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Basti110/ray-tracing:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8029ba38c58cb463eb0daa88488688a75cbf1790683e6e4cfcf406de33b260d0 [INFO] running `"docker" "start" "-a" "8029ba38c58cb463eb0daa88488688a75cbf1790683e6e4cfcf406de33b260d0"` [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking ray-tracing v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere_node.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere_node.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere_node.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera_node.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node_3d.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | intensity: intensity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere_node.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere_node.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | radius: radius, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sphere_node.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera_node.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node_3d.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | direction: direction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `direction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/light.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | intensity: intensity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | normal: normal, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/plane.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere_node.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere_node.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere_node.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere_node.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.color.copy(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.color.copy()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Node3D` [INFO] [stderr] --> src/camera_node.rs:1:13 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::{Node3D, Node, Ray, Color}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return Color::new(0.0, 0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Color::new(0.0, 0.0, 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return Color::new(0.0, 0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Color::new(0.0, 0.0, 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return Rc::clone(&self.renderer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rc::clone(&self.renderer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene_items.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return Color::new(self.red, self.green, self.blue); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Color::new(self.red, self.green, self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene_items.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return (self.red * 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.red * 255.0) as u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene_items.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return (self.green * 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.green * 255.0) as u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene_items.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return (self.blue * 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.blue * 255.0) as u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Light` [INFO] [stderr] --> src/render_system.rs:1:50 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::{Scene, CameraNode, Node, Ray, Color, Light}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render_system.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return cur_obj; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `cur_obj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/render_system.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | let light_power = (intersection.normal.dot(direction_to_light) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/render_system.rs:107:36 [INFO] [stderr] | [INFO] [stderr] 107 | let light_reflected = 1.0; /// std::f32::consts::PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return self.color.copy(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.color.copy()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plane.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plane.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plane.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plane.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return self.color.copy(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.color.copy()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Weak` [INFO] [stderr] --> src/main.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | use std::rc::{Weak, Rc}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere_node.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere_node.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere_node.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere_node.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return self.color.copy(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.color.copy()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Node3D` [INFO] [stderr] --> src/camera_node.rs:1:13 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::{Node3D, Node, Ray, Color}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/camera_node.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | return Color::new(0.0, 0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Color::new(0.0, 0.0, 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/node_3d.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | return Color::new(0.0, 0.0, 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Color::new(0.0, 0.0, 0.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return Rc::clone(&self.renderer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rc::clone(&self.renderer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene_items.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return Color::new(self.red, self.green, self.blue); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Color::new(self.red, self.green, self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene_items.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return (self.red * 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.red * 255.0) as u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene_items.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return (self.green * 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.green * 255.0) as u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/scene_items.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return (self.blue * 255.0) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.blue * 255.0) as u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Light` [INFO] [stderr] --> src/render_system.rs:1:50 [INFO] [stderr] | [INFO] [stderr] 1 | use crate::{Scene, CameraNode, Node, Ray, Color, Light}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render_system.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return cur_obj; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `cur_obj` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/render_system.rs:100:27 [INFO] [stderr] | [INFO] [stderr] 100 | let light_power = (intersection.normal.dot(direction_to_light) as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/render_system.rs:107:36 [INFO] [stderr] | [INFO] [stderr] 107 | let light_reflected = 1.0; /// std::f32::consts::PI; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/light.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return self.color.copy(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.color.copy()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plane.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | return Some(Rc::clone(&(*strong))); //Some(Rc::clone(&(*(&self.parent)))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(*strong)))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plane.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return Some(Rc::clone(&(self.childs[index]))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Rc::clone(&(self.childs[index])))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plane.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return self.size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/plane.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | return self.color.copy(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.color.copy()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Weak` [INFO] [stderr] --> src/main.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | use std::rc::{Weak, Rc}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ray` [INFO] [stderr] --> src/camera_node.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | fn intersect(&self, ray: &Ray) -> Option<(f64, Vector3)> { [INFO] [stderr] | ^^^ help: consider using `_ray` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ray` [INFO] [stderr] --> src/node_3d.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | fn intersect(&self, ray: &Ray) -> Option<(f64, Vector3)> { [INFO] [stderr] | ^^^ help: consider using `_ray` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `camera` [INFO] [stderr] --> src/scene.rs:22:55 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new(name: String, root: Rc>, camera: Rc>) -> Scene { [INFO] [stderr] | ^^^^^^ help: consider using `_camera` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ray` [INFO] [stderr] --> src/light.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | fn intersect(&self, ray: &Ray) -> Option<(f64, Vector3)> { [INFO] [stderr] | ^^^ help: consider using `_ray` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ray` [INFO] [stderr] --> src/camera_node.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | fn intersect(&self, ray: &Ray) -> Option<(f64, Vector3)> { [INFO] [stderr] | ^^^ help: consider using `_ray` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ray` [INFO] [stderr] --> src/node_3d.rs:62:25 [INFO] [stderr] | [INFO] [stderr] 62 | fn intersect(&self, ray: &Ray) -> Option<(f64, Vector3)> { [INFO] [stderr] | ^^^ help: consider using `_ray` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `camera` [INFO] [stderr] --> src/scene.rs:22:55 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new(name: String, root: Rc>, camera: Rc>) -> Scene { [INFO] [stderr] | ^^^^^^ help: consider using `_camera` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `ray` [INFO] [stderr] --> src/light.rs:71:25 [INFO] [stderr] | [INFO] [stderr] 71 | fn intersect(&self, ray: &Ray) -> Option<(f64, Vector3)> { [INFO] [stderr] | ^^^ help: consider using `_ray` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `plane_with` [INFO] [stderr] --> src/camera_node.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | plane_with: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `plane_height` [INFO] [stderr] --> src/camera_node.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | plane_height: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | red: (r as f32) / 255.0, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | green: (g as f32) / 255.0, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | blue: (b as f32) / 255.0, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | let aspect_ratio = (width as f64) / (height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | let aspect_ratio = (width as f64) / (height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | let sensor_x = ((((x as f64 + 0.5) / width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:94:42 [INFO] [stderr] | [INFO] [stderr] 94 | let sensor_x = ((((x as f64 + 0.5) / width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | let sensor_y = (1.0 - ((y as f64 + 0.5) / height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:95:47 [INFO] [stderr] | [INFO] [stderr] 95 | let sensor_y = (1.0 - ((y as f64 + 0.5) / height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: field is never used: `plane_with` [INFO] [stderr] --> src/camera_node.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | plane_with: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `plane_height` [INFO] [stderr] --> src/camera_node.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | plane_height: f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | red: (r as f32) / 255.0, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | green: (g as f32) / 255.0, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:24:19 [INFO] [stderr] | [INFO] [stderr] 24 | blue: (b as f32) / 255.0, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | let aspect_ratio = (width as f64) / (height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:93:41 [INFO] [stderr] | [INFO] [stderr] 93 | let aspect_ratio = (width as f64) / (height as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:94:24 [INFO] [stderr] | [INFO] [stderr] 94 | let sensor_x = ((((x as f64 + 0.5) / width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:94:42 [INFO] [stderr] | [INFO] [stderr] 94 | let sensor_x = ((((x as f64 + 0.5) / width as f64) * 2.0 - 1.0) * aspect_ratio) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:95:29 [INFO] [stderr] | [INFO] [stderr] 95 | let sensor_y = (1.0 - ((y as f64 + 0.5) / height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/scene_items.rs:95:47 [INFO] [stderr] | [INFO] [stderr] 95 | let sensor_y = (1.0 - ((y as f64 + 0.5) / height as f64) * 2.0) * fov_adjustment; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.97s [INFO] running `"docker" "inspect" "8029ba38c58cb463eb0daa88488688a75cbf1790683e6e4cfcf406de33b260d0"` [INFO] running `"docker" "rm" "-f" "8029ba38c58cb463eb0daa88488688a75cbf1790683e6e4cfcf406de33b260d0"` [INFO] [stdout] 8029ba38c58cb463eb0daa88488688a75cbf1790683e6e4cfcf406de33b260d0