[INFO] updating cached repository Baelyk/minesweeper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Baelyk/minesweeper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Baelyk/minesweeper" "work/ex/clippy-test-run/sources/stable/gh/Baelyk/minesweeper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Baelyk/minesweeper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Baelyk/minesweeper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Baelyk/minesweeper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Baelyk/minesweeper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 93510b63b0e80f5df69cd76046a28ddc6e198fb2 [INFO] sha for GitHub repo Baelyk/minesweeper: 93510b63b0e80f5df69cd76046a28ddc6e198fb2 [INFO] validating manifest of Baelyk/minesweeper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Baelyk/minesweeper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Baelyk/minesweeper [INFO] finished frobbing Baelyk/minesweeper [INFO] frobbed toml for Baelyk/minesweeper written to work/ex/clippy-test-run/sources/stable/gh/Baelyk/minesweeper/Cargo.toml [INFO] started frobbing Baelyk/minesweeper [INFO] finished frobbing Baelyk/minesweeper [INFO] frobbed toml for Baelyk/minesweeper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Baelyk/minesweeper/Cargo.toml [INFO] crate Baelyk/minesweeper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Baelyk/minesweeper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Baelyk/minesweeper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fb0ce89b1ee4d64c2f198f29cf535f2184601c6a14b91798bd61f432e5fa1b66 [INFO] running `"docker" "start" "-a" "fb0ce89b1ee4d64c2f198f29cf535f2184601c6a14b91798bd61f432e5fa1b66"` [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling syn v0.13.3 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Compiling gl_generator v0.6.1 [INFO] [stderr] Compiling gl_generator v0.7.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Compiling gfx_gl v0.4.0 [INFO] [stderr] Compiling gl v0.6.5 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Compiling serde_derive v1.0.43 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.1 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Checking piston-gfx_texture v0.26.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.43.0 [INFO] [stderr] Checking piston_window v0.70.0 [INFO] [stderr] Checking minesweeper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | board: board, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | mines: mines, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | cell_width: cell_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | cell_height: cell_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | line_radius: line_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | line_color: line_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | background_color: background_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | x_off: x_off, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `x_off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | y_off: y_off, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | line_radius: line_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | line_color: line_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | background_color: background_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | board: board, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `board` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | mines: mines, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | cell_width: cell_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | cell_height: cell_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cell_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | line_radius: line_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | line_color: line_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | background_color: background_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | x_off: x_off, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `x_off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | y_off: y_off, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `y_off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | line_radius: line_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | line_color: line_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | background_color: background_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `background_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:183:13 [INFO] [stderr] | [INFO] [stderr] 183 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:184:13 [INFO] [stderr] | [INFO] [stderr] 184 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | / if !(neighbor.x == tile.x && neighbor.y == tile.y) { [INFO] [stderr] 125 | | if !self.board[neighbor.x][neighbor.y].revealed [INFO] [stderr] 126 | | && !self.board[neighbor.x][neighbor.y].flagged [INFO] [stderr] 127 | | { [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | if !(neighbor.x == tile.x && neighbor.y == tile.y) && !self.board[neighbor.x][neighbor.y].revealed [INFO] [stderr] 125 | && !self.board[neighbor.x][neighbor.y].flagged { [INFO] [stderr] 126 | // use self.board[x][y] to ensure that the tile hasn't been updated "elsewhere" (previously in recursions) [INFO] [stderr] 127 | // println!("hi"); [INFO] [stderr] 128 | // If neighbor is an empty tile [INFO] [stderr] 129 | match neighbor.tile { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | let mut update = true; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/game.rs:124:17 [INFO] [stderr] | [INFO] [stderr] 124 | / if !(neighbor.x == tile.x && neighbor.y == tile.y) { [INFO] [stderr] 125 | | if !self.board[neighbor.x][neighbor.y].revealed [INFO] [stderr] 126 | | && !self.board[neighbor.x][neighbor.y].flagged [INFO] [stderr] 127 | | { [INFO] [stderr] ... | [INFO] [stderr] 145 | | } [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 124 | if !(neighbor.x == tile.x && neighbor.y == tile.y) && !self.board[neighbor.x][neighbor.y].revealed [INFO] [stderr] 125 | && !self.board[neighbor.x][neighbor.y].flagged { [INFO] [stderr] 126 | // use self.board[x][y] to ensure that the tile hasn't been updated "elsewhere" (previously in recursions) [INFO] [stderr] 127 | // println!("hi"); [INFO] [stderr] 128 | // If neighbor is an empty tile [INFO] [stderr] 129 | match neighbor.tile { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `mine_array`. [INFO] [stderr] --> src/game.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..mines { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in mine_array.iter_mut().take(mines) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `board` [INFO] [stderr] --> src/game.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for x in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for (x, ) in board.iter_mut().enumerate().take(width) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/game.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut tiletype = TileType::Empty(0); [INFO] [stderr] 57 | | if mine_array.contains(&(x, y)) { [INFO] [stderr] 58 | | tiletype = TileType::Mine; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let tiletype = if mine_array.contains(&(x, y)) { TileType::Mine } else { TileType::Empty(0) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/grid.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn new( [INFO] [stderr] 90 | | width: usize, [INFO] [stderr] 91 | | height: usize, [INFO] [stderr] 92 | | cell_width: usize, [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/grid.rs:149:18 [INFO] [stderr] | [INFO] [stderr] 149 | for x in 0..self.width + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=self.width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/grid.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | for y in 0..self.height + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=self.height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let ref font = assets.join("Menlo.ttf"); [INFO] [stderr] | ----^^^^^^^^---------------------------- help: try: `let font = &assets.join("Menlo.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | / match game.state { [INFO] [stderr] 196 | | 0 => window.set_should_close(true), [INFO] [stderr] 197 | | _ => {} [INFO] [stderr] 198 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let 0 = game.state { window.set_should_close(true) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | let mut update = true; [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `mine_array`. [INFO] [stderr] --> src/game.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..mines { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in mine_array.iter_mut().take(mines) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `board` [INFO] [stderr] --> src/game.rs:54:18 [INFO] [stderr] | [INFO] [stderr] 54 | for x in 0..width { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 54 | for (x, ) in board.iter_mut().enumerate().take(width) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/game.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | / let mut tiletype = TileType::Empty(0); [INFO] [stderr] 57 | | if mine_array.contains(&(x, y)) { [INFO] [stderr] 58 | | tiletype = TileType::Mine; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let tiletype = if mine_array.contains(&(x, y)) { TileType::Mine } else { TileType::Empty(0) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/grid.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / pub fn new( [INFO] [stderr] 90 | | width: usize, [INFO] [stderr] 91 | | height: usize, [INFO] [stderr] 92 | | cell_width: usize, [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/grid.rs:149:18 [INFO] [stderr] | [INFO] [stderr] 149 | for x in 0..self.width + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=self.width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/grid.rs:162:18 [INFO] [stderr] | [INFO] [stderr] 162 | for y in 0..self.height + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `0..=self.height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let ref font = assets.join("Menlo.ttf"); [INFO] [stderr] | ----^^^^^^^^---------------------------- help: try: `let font = &assets.join("Menlo.ttf");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:195:17 [INFO] [stderr] | [INFO] [stderr] 195 | / match game.state { [INFO] [stderr] 196 | | 0 => window.set_should_close(true), [INFO] [stderr] 197 | | _ => {} [INFO] [stderr] 198 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let 0 = game.state { window.set_should_close(true) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 44s [INFO] running `"docker" "inspect" "fb0ce89b1ee4d64c2f198f29cf535f2184601c6a14b91798bd61f432e5fa1b66"` [INFO] running `"docker" "rm" "-f" "fb0ce89b1ee4d64c2f198f29cf535f2184601c6a14b91798bd61f432e5fa1b66"` [INFO] [stdout] fb0ce89b1ee4d64c2f198f29cf535f2184601c6a14b91798bd61f432e5fa1b66