[INFO] updating cached repository Baelyk/game_of_life [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Baelyk/game_of_life [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Baelyk/game_of_life" "work/ex/clippy-test-run/sources/stable/gh/Baelyk/game_of_life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Baelyk/game_of_life'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Baelyk/game_of_life" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Baelyk/game_of_life"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Baelyk/game_of_life'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2ec4b3ac890ddac9bd1f98764419c5752a5b24d5 [INFO] sha for GitHub repo Baelyk/game_of_life: 2ec4b3ac890ddac9bd1f98764419c5752a5b24d5 [INFO] validating manifest of Baelyk/game_of_life on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Baelyk/game_of_life on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Baelyk/game_of_life [INFO] finished frobbing Baelyk/game_of_life [INFO] frobbed toml for Baelyk/game_of_life written to work/ex/clippy-test-run/sources/stable/gh/Baelyk/game_of_life/Cargo.toml [INFO] started frobbing Baelyk/game_of_life [INFO] finished frobbing Baelyk/game_of_life [INFO] frobbed toml for Baelyk/game_of_life written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Baelyk/game_of_life/Cargo.toml [INFO] crate Baelyk/game_of_life has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Baelyk/game_of_life against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Baelyk/game_of_life:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a5fe3b051b32cbe283b84222278032b3ffa25373abeb86bb8ba1a15fb86616a [INFO] running `"docker" "start" "-a" "1a5fe3b051b32cbe283b84222278032b3ffa25373abeb86bb8ba1a15fb86616a"` [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Checking png v0.9.0 [INFO] [stderr] Checking gfx_core v0.7.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking image v0.15.0 [INFO] [stderr] Checking pistoncore-window v0.28.0 [INFO] [stderr] Checking pistoncore-event_loop v0.33.0 [INFO] [stderr] Checking piston v0.33.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking glutin v0.9.2 [INFO] [stderr] Checking gfx v0.16.3 [INFO] [stderr] Checking gfx_device_gl v0.14.6 [INFO] [stderr] Checking pistoncore-glutin_window v0.39.1 [INFO] [stderr] Checking piston-gfx_texture v0.26.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.43.0 [INFO] [stderr] Checking piston_window v0.70.0 [INFO] [stderr] Checking game_of_life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return neighbours [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `neighbours` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | return neighbours [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `neighbours` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / let mut alive = "Dead"; [INFO] [stderr] 29 | | if self.alive { [INFO] [stderr] 30 | | alive = "Live"; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let alive = if self.alive { "Live" } else { "Dead" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:88:49 [INFO] [stderr] | [INFO] [stderr] 88 | } else if living_neighbours > 3 { // Overpopulation [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 89 | | // println!("Over {:?}", cell); [INFO] [stderr] 90 | | cell.alive = false; [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:85:42 [INFO] [stderr] | [INFO] [stderr] 85 | if living_neighbours < 2 { // Underpopulation [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 86 | | // println!("Under {:?}", cell); [INFO] [stderr] 87 | | cell.alive = false; [INFO] [stderr] 88 | | } else if living_neighbours > 3 { // Overpopulation [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `array` [INFO] [stderr] --> src/main.rs:108:14 [INFO] [stderr] | [INFO] [stderr] 108 | for x in 0..GRID_SIZE as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 108 | for (x, ) in array.iter_mut().enumerate().take(GRID_SIZE as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | units: CELL_SIZE as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cells` [INFO] [stderr] --> src/main.rs:144:22 [INFO] [stderr] | [INFO] [stderr] 144 | for x in 0..GRID_SIZE as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 144 | for (x, ) in cells.iter().enumerate().take(GRID_SIZE as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:170 [INFO] [stderr] | [INFO] [stderr] 147 | rectangle([0.0, 0.0, 0.0, 1.0], [(x * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, (y * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, CELL_SIZE as f64 - CELL_OFFSET, CELL_SIZE as f64 - CELL_OFFSET], c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:202 [INFO] [stderr] | [INFO] [stderr] 147 | rectangle([0.0, 0.0, 0.0, 1.0], [(x * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, (y * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, CELL_SIZE as f64 - CELL_OFFSET, CELL_SIZE as f64 - CELL_OFFSET], c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cells` [INFO] [stderr] --> src/main.rs:186:30 [INFO] [stderr] | [INFO] [stderr] 186 | for x in 0..GRID_SIZE as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 186 | for (x, ) in cells.iter().enumerate().take(GRID_SIZE as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:189:178 [INFO] [stderr] | [INFO] [stderr] 189 | rectangle([0.0, 0.0, 0.0, 1.0], [(x * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, (y * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, CELL_SIZE as f64 - CELL_OFFSET, CELL_SIZE as f64 - CELL_OFFSET], c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:189:210 [INFO] [stderr] | [INFO] [stderr] 189 | rectangle([0.0, 0.0, 0.0, 1.0], [(x * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, (y * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, CELL_SIZE as f64 - CELL_OFFSET, CELL_SIZE as f64 - CELL_OFFSET], c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:198:16 [INFO] [stderr] | [INFO] [stderr] 198 | if x > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 && y > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 198 | if x > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 && y > 0.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 198 | if !(!y > 0.0 || !x < (GRID_SIZE * CELL_SIZE) as f64 || !x > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:31 [INFO] [stderr] | [INFO] [stderr] 198 | if x > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 && y > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(GRID_SIZE * CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:80 [INFO] [stderr] | [INFO] [stderr] 198 | if x > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 && y > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(GRID_SIZE * CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `game_of_life`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | / let mut alive = "Dead"; [INFO] [stderr] 29 | | if self.alive { [INFO] [stderr] 30 | | alive = "Live"; [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let alive = if self.alive { "Live" } else { "Dead" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:88:49 [INFO] [stderr] | [INFO] [stderr] 88 | } else if living_neighbours > 3 { // Overpopulation [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 89 | | // println!("Over {:?}", cell); [INFO] [stderr] 90 | | cell.alive = false; [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:85:42 [INFO] [stderr] | [INFO] [stderr] 85 | if living_neighbours < 2 { // Underpopulation [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 86 | | // println!("Under {:?}", cell); [INFO] [stderr] 87 | | cell.alive = false; [INFO] [stderr] 88 | | } else if living_neighbours > 3 { // Overpopulation [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `array` [INFO] [stderr] --> src/main.rs:108:14 [INFO] [stderr] | [INFO] [stderr] 108 | for x in 0..GRID_SIZE as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 108 | for (x, ) in array.iter_mut().enumerate().take(GRID_SIZE as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:128:16 [INFO] [stderr] | [INFO] [stderr] 128 | units: CELL_SIZE as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cells` [INFO] [stderr] --> src/main.rs:144:22 [INFO] [stderr] | [INFO] [stderr] 144 | for x in 0..GRID_SIZE as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 144 | for (x, ) in cells.iter().enumerate().take(GRID_SIZE as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:170 [INFO] [stderr] | [INFO] [stderr] 147 | rectangle([0.0, 0.0, 0.0, 1.0], [(x * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, (y * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, CELL_SIZE as f64 - CELL_OFFSET, CELL_SIZE as f64 - CELL_OFFSET], c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:147:202 [INFO] [stderr] | [INFO] [stderr] 147 | rectangle([0.0, 0.0, 0.0, 1.0], [(x * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, (y * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, CELL_SIZE as f64 - CELL_OFFSET, CELL_SIZE as f64 - CELL_OFFSET], c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `x` is used to index `cells` [INFO] [stderr] --> src/main.rs:186:30 [INFO] [stderr] | [INFO] [stderr] 186 | for x in 0..GRID_SIZE as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 186 | for (x, ) in cells.iter().enumerate().take(GRID_SIZE as usize) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:189:178 [INFO] [stderr] | [INFO] [stderr] 189 | rectangle([0.0, 0.0, 0.0, 1.0], [(x * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, (y * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, CELL_SIZE as f64 - CELL_OFFSET, CELL_SIZE as f64 - CELL_OFFSET], c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:189:210 [INFO] [stderr] | [INFO] [stderr] 189 | rectangle([0.0, 0.0, 0.0, 1.0], [(x * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, (y * CELL_SIZE as usize + CELL_OFFSET as usize) as f64, CELL_SIZE as f64 - CELL_OFFSET, CELL_SIZE as f64 - CELL_OFFSET], c.transform, g); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:198:16 [INFO] [stderr] | [INFO] [stderr] 198 | if x > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 && y > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 198 | if x > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 && y > 0.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] 198 | if !(!y > 0.0 || !x < (GRID_SIZE * CELL_SIZE) as f64 || !x > 0.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:31 [INFO] [stderr] | [INFO] [stderr] 198 | if x > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 && y > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(GRID_SIZE * CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:198:80 [INFO] [stderr] | [INFO] [stderr] 198 | if x > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 && y > 0.0 && x < (GRID_SIZE * CELL_SIZE) as f64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(GRID_SIZE * CELL_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `game_of_life`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1a5fe3b051b32cbe283b84222278032b3ffa25373abeb86bb8ba1a15fb86616a"` [INFO] running `"docker" "rm" "-f" "1a5fe3b051b32cbe283b84222278032b3ffa25373abeb86bb8ba1a15fb86616a"` [INFO] [stdout] 1a5fe3b051b32cbe283b84222278032b3ffa25373abeb86bb8ba1a15fb86616a