[INFO] updating cached repository Badel2/ent [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Badel2/ent [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Badel2/ent" "work/ex/clippy-test-run/sources/stable/gh/Badel2/ent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Badel2/ent'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Badel2/ent" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Badel2/ent"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Badel2/ent'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 048b4f0ba3ec157eb9cc804203c9028e91c1b6c1 [INFO] sha for GitHub repo Badel2/ent: 048b4f0ba3ec157eb9cc804203c9028e91c1b6c1 [INFO] validating manifest of Badel2/ent on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Badel2/ent on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Badel2/ent [INFO] finished frobbing Badel2/ent [INFO] frobbed toml for Badel2/ent written to work/ex/clippy-test-run/sources/stable/gh/Badel2/ent/Cargo.toml [INFO] started frobbing Badel2/ent [INFO] finished frobbing Badel2/ent [INFO] frobbed toml for Badel2/ent written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Badel2/ent/Cargo.toml [INFO] crate Badel2/ent has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Badel2/ent against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Badel2/ent:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b28ffe6b584ed59bf5716468f0dfa43bb5a856c1ad54bb399d7c0a0f7698955a [INFO] running `"docker" "start" "-a" "b28ffe6b584ed59bf5716468f0dfa43bb5a856c1ad54bb399d7c0a0f7698955a"` [INFO] [stderr] Checking ent v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/main.rs:185:9 [INFO] [stderr] | [INFO] [stderr] 185 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/shannon/mod.rs:189:30 [INFO] [stderr] | [INFO] [stderr] 189 | assert_eq!(t2.entropy(), 7.982743005032543); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `7.982_743_005_032_543` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: field is never used: `chunk_size` [INFO] [stderr] --> src/shannon/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | chunk_size: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shannon/mod.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | let denom = (256 - 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(256 - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/shannon/mod.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | start += (ones as i64 - 4) * 2 * x as i64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(ones)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shannon/mod.rs:172:33 [INFO] [stderr] | [INFO] [stderr] 172 | let temp: f64 = c as f64 / filesize as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shannon/mod.rs:172:44 [INFO] [stderr] | [INFO] [stderr] 172 | let temp: f64 = c as f64 / filesize as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(filesize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match i % 64 { [INFO] [stderr] 75 | | 63 => s.push_str(&format!("\n {:04} ", 1 + i / 64)), [INFO] [stderr] 76 | | _ => {} [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: try this: `if let 63 = i % 64 { s.push_str(&format!("\n {:04} ", 1 + i / 64)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: field is never used: `chunk_size` [INFO] [stderr] --> src/shannon/mod.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | chunk_size: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shannon/mod.rs:122:21 [INFO] [stderr] | [INFO] [stderr] 122 | let denom = (256 - 1) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(256 - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/shannon/mod.rs:143:23 [INFO] [stderr] | [INFO] [stderr] 143 | start += (ones as i64 - 4) * 2 * x as i64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i64::from(ones)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shannon/mod.rs:172:33 [INFO] [stderr] | [INFO] [stderr] 172 | let temp: f64 = c as f64 / filesize as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/shannon/mod.rs:172:44 [INFO] [stderr] | [INFO] [stderr] 172 | let temp: f64 = c as f64 / filesize as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(filesize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/shannon/mod.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(Shannon::open("test0").unwrap().entropy(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/shannon/mod.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | assert_eq!(Shannon::open("test0").unwrap().entropy(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/shannon/mod.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(Shannon::open("test1").unwrap().entropy(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/shannon/mod.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | assert_eq!(Shannon::open("test1").unwrap().entropy(), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/shannon/mod.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | assert_eq!(t2.entropy(), 7.982743005032543); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/shannon/mod.rs:189:5 [INFO] [stderr] | [INFO] [stderr] 189 | assert_eq!(t2.entropy(), 7.982743005032543); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match i % 64 { [INFO] [stderr] 75 | | 63 => s.push_str(&format!("\n {:04} ", 1 + i / 64)), [INFO] [stderr] 76 | | _ => {} [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: try this: `if let 63 = i % 64 { s.push_str(&format!("\n {:04} ", 1 + i / 64)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ent`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "b28ffe6b584ed59bf5716468f0dfa43bb5a856c1ad54bb399d7c0a0f7698955a"` [INFO] running `"docker" "rm" "-f" "b28ffe6b584ed59bf5716468f0dfa43bb5a856c1ad54bb399d7c0a0f7698955a"` [INFO] [stdout] b28ffe6b584ed59bf5716468f0dfa43bb5a856c1ad54bb399d7c0a0f7698955a