[INFO] updating cached repository BaconSoap/branch-destroyer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/BaconSoap/branch-destroyer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/BaconSoap/branch-destroyer" "work/ex/clippy-test-run/sources/stable/gh/BaconSoap/branch-destroyer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BaconSoap/branch-destroyer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/BaconSoap/branch-destroyer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BaconSoap/branch-destroyer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BaconSoap/branch-destroyer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8d165bc9076d32b14a2e7971b39a7afd74df75c3 [INFO] sha for GitHub repo BaconSoap/branch-destroyer: 8d165bc9076d32b14a2e7971b39a7afd74df75c3 [INFO] validating manifest of BaconSoap/branch-destroyer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of BaconSoap/branch-destroyer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing BaconSoap/branch-destroyer [INFO] finished frobbing BaconSoap/branch-destroyer [INFO] frobbed toml for BaconSoap/branch-destroyer written to work/ex/clippy-test-run/sources/stable/gh/BaconSoap/branch-destroyer/Cargo.toml [INFO] started frobbing BaconSoap/branch-destroyer [INFO] finished frobbing BaconSoap/branch-destroyer [INFO] frobbed toml for BaconSoap/branch-destroyer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BaconSoap/branch-destroyer/Cargo.toml [INFO] crate BaconSoap/branch-destroyer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting BaconSoap/branch-destroyer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BaconSoap/branch-destroyer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2b7fddb4819cf1bff33ecdcfce21b9517abbe21f18146f7f58ecb0ce85e25d9e [INFO] running `"docker" "start" "-a" "2b7fddb4819cf1bff33ecdcfce21b9517abbe21f18146f7f58ecb0ce85e25d9e"` [INFO] [stderr] Checking serde_json v1.0.3 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking branch-destroyer v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | let res = match request.send() { [INFO] [stderr] | _______________^ [INFO] [stderr] 65 | | Ok(res) => { [INFO] [stderr] 66 | | if !res.status.is_success() { [INFO] [stderr] 67 | | println!("{}", res.status); [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | req [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:89:15 [INFO] [stderr] | [INFO] [stderr] 89 | let req = client [INFO] [stderr] | _______________^ [INFO] [stderr] 90 | | .request(method, url) [INFO] [stderr] 91 | | .header(UserAgent("branch-destroyer 1.0".to_string())) [INFO] [stderr] 92 | | .header(Authorization(auth)); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:78:5 [INFO] [stderr] | [INFO] [stderr] 78 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:64:15 [INFO] [stderr] | [INFO] [stderr] 64 | let res = match request.send() { [INFO] [stderr] | _______________^ [INFO] [stderr] 65 | | Ok(res) => { [INFO] [stderr] 66 | | if !res.status.is_success() { [INFO] [stderr] 67 | | println!("{}", res.status); [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | req [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:89:15 [INFO] [stderr] | [INFO] [stderr] 89 | let req = client [INFO] [stderr] | _______________^ [INFO] [stderr] 90 | | .request(method, url) [INFO] [stderr] 91 | | .header(UserAgent("branch-destroyer 1.0".to_string())) [INFO] [stderr] 92 | | .header(Authorization(auth)); [INFO] [stderr] | |____________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:23:41 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn print_branch_info(branches_info: &Vec, ctx: &Context) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[BranchInfo]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:87:36 [INFO] [stderr] | [INFO] [stderr] 87 | let auth = format!("token {}", token.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 87 | let auth = format!("token {}", &(*token).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 87 | let auth = format!("token {}", &str::clone(token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:175:19 [INFO] [stderr] | [INFO] [stderr] 175 | fn get_link_value<'a>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | let a = x.values() [INFO] [stderr] | _________________^ [INFO] [stderr] 186 | | .into_iter() [INFO] [stderr] 187 | | .filter(|x| match x.rel() { [INFO] [stderr] 188 | | Some(x) => match x[0] { [INFO] [stderr] ... | [INFO] [stderr] 193 | | }) [INFO] [stderr] 194 | | .next(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:186:14 [INFO] [stderr] | [INFO] [stderr] 186 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / let mut latest_commit = &compare_result.merge_base_commit; [INFO] [stderr] 225 | | [INFO] [stderr] 226 | | if compare_result.commits.len() > 0 { [INFO] [stderr] 227 | | let i = compare_result.commits.len(); [INFO] [stderr] 228 | | latest_commit = &compare_result.commits[i - 1]; [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let latest_commit = if compare_result.commits.len() > 0 { ..; &compare_result.commits[i - 1] } else { &compare_result.merge_base_commit };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:226:8 [INFO] [stderr] | [INFO] [stderr] 226 | if compare_result.commits.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!compare_result.commits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `branch-destroyer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:23:41 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn print_branch_info(branches_info: &Vec, ctx: &Context) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[BranchInfo]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:87:36 [INFO] [stderr] | [INFO] [stderr] 87 | let auth = format!("token {}", token.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 87 | let auth = format!("token {}", &(*token).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 87 | let auth = format!("token {}", &str::clone(token)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:175:19 [INFO] [stderr] | [INFO] [stderr] 175 | fn get_link_value<'a>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/lib.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | let a = x.values() [INFO] [stderr] | _________________^ [INFO] [stderr] 186 | | .into_iter() [INFO] [stderr] 187 | | .filter(|x| match x.rel() { [INFO] [stderr] 188 | | Some(x) => match x[0] { [INFO] [stderr] ... | [INFO] [stderr] 193 | | }) [INFO] [stderr] 194 | | .next(); [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:186:14 [INFO] [stderr] | [INFO] [stderr] 186 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:224:5 [INFO] [stderr] | [INFO] [stderr] 224 | / let mut latest_commit = &compare_result.merge_base_commit; [INFO] [stderr] 225 | | [INFO] [stderr] 226 | | if compare_result.commits.len() > 0 { [INFO] [stderr] 227 | | let i = compare_result.commits.len(); [INFO] [stderr] 228 | | latest_commit = &compare_result.commits[i - 1]; [INFO] [stderr] 229 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let latest_commit = if compare_result.commits.len() > 0 { ..; &compare_result.commits[i - 1] } else { &compare_result.merge_base_commit };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:226:8 [INFO] [stderr] | [INFO] [stderr] 226 | if compare_result.commits.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!compare_result.commits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `branch-destroyer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2b7fddb4819cf1bff33ecdcfce21b9517abbe21f18146f7f58ecb0ce85e25d9e"` [INFO] running `"docker" "rm" "-f" "2b7fddb4819cf1bff33ecdcfce21b9517abbe21f18146f7f58ecb0ce85e25d9e"` [INFO] [stdout] 2b7fddb4819cf1bff33ecdcfce21b9517abbe21f18146f7f58ecb0ce85e25d9e