[INFO] updating cached repository BProg/z-files
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/BProg/z-files
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/BProg/z-files" "work/ex/clippy-test-run/sources/stable/gh/BProg/z-files"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/BProg/z-files'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/BProg/z-files" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BProg/z-files"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BProg/z-files'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3c3c86e1c4e85eec000c1a0472802c8108dc5290
[INFO] sha for GitHub repo BProg/z-files: 3c3c86e1c4e85eec000c1a0472802c8108dc5290
[INFO] validating manifest of BProg/z-files on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of BProg/z-files on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing BProg/z-files
[INFO] finished frobbing BProg/z-files
[INFO] frobbed toml for BProg/z-files written to work/ex/clippy-test-run/sources/stable/gh/BProg/z-files/Cargo.toml
[INFO] started frobbing BProg/z-files
[INFO] finished frobbing BProg/z-files
[INFO] frobbed toml for BProg/z-files written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/BProg/z-files/Cargo.toml
[INFO] crate BProg/z-files has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting BProg/z-files against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/BProg/z-files:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d83b57744c9d7474eb3591b0464b22ab04355ac76f2a62134a412ff3a2263fa0
[INFO] running `"docker" "start" "-a" "d83b57744c9d7474eb3591b0464b22ab04355ac76f2a62134a412ff3a2263fa0"`
[INFO] [stderr]     Checking csv v0.14.7
[INFO] [stderr]     Checking z-files v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/password_printer.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     format!("{}", record.name)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `record.name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     match matches.subcommand() {
[INFO] [stderr] 13 | |         ("show", Some(show_cmd)) => {
[INFO] [stderr] 14 | |             if show_cmd.is_present("names") && show_cmd.is_present("passwords") {
[INFO] [stderr] 15 | |                 let records = read_records();
[INFO] [stderr] ...  |
[INFO] [stderr] 25 | |         _ => {},
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 |     if let ("show", Some(show_cmd)) = matches.subcommand() {
[INFO] [stderr] 13 |     if show_cmd.is_present("names") && show_cmd.is_present("passwords") {
[INFO] [stderr] 14 |         let records = read_records();
[INFO] [stderr] 15 |         password_printer::print_password_records_names_passwords(records);
[INFO] [stderr] 16 |     } else if show_cmd.is_present("passwords") {
[INFO] [stderr] 17 |         let records = read_records();
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/password_printer.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     format!("{}", record.name)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `record.name.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | /     match matches.subcommand() {
[INFO] [stderr] 13 | |         ("show", Some(show_cmd)) => {
[INFO] [stderr] 14 | |             if show_cmd.is_present("names") && show_cmd.is_present("passwords") {
[INFO] [stderr] 15 | |                 let records = read_records();
[INFO] [stderr] ...  |
[INFO] [stderr] 25 | |         _ => {},
[INFO] [stderr] 26 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 |     if let ("show", Some(show_cmd)) = matches.subcommand() {
[INFO] [stderr] 13 |     if show_cmd.is_present("names") && show_cmd.is_present("passwords") {
[INFO] [stderr] 14 |         let records = read_records();
[INFO] [stderr] 15 |         password_printer::print_password_records_names_passwords(records);
[INFO] [stderr] 16 |     } else if show_cmd.is_present("passwords") {
[INFO] [stderr] 17 |         let records = read_records();
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.56s
[INFO] running `"docker" "inspect" "d83b57744c9d7474eb3591b0464b22ab04355ac76f2a62134a412ff3a2263fa0"`
[INFO] running `"docker" "rm" "-f" "d83b57744c9d7474eb3591b0464b22ab04355ac76f2a62134a412ff3a2263fa0"`
[INFO] [stdout] d83b57744c9d7474eb3591b0464b22ab04355ac76f2a62134a412ff3a2263fa0