[INFO] updating cached repository AzenForze/RankedPairs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AzenForze/RankedPairs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AzenForze/RankedPairs" "work/ex/clippy-test-run/sources/stable/gh/AzenForze/RankedPairs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AzenForze/RankedPairs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AzenForze/RankedPairs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AzenForze/RankedPairs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AzenForze/RankedPairs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 740b4c8508d02a8238a64e8c1ce77c7ab22c5723 [INFO] sha for GitHub repo AzenForze/RankedPairs: 740b4c8508d02a8238a64e8c1ce77c7ab22c5723 [INFO] validating manifest of AzenForze/RankedPairs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AzenForze/RankedPairs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AzenForze/RankedPairs [INFO] finished frobbing AzenForze/RankedPairs [INFO] frobbed toml for AzenForze/RankedPairs written to work/ex/clippy-test-run/sources/stable/gh/AzenForze/RankedPairs/Cargo.toml [INFO] started frobbing AzenForze/RankedPairs [INFO] finished frobbing AzenForze/RankedPairs [INFO] frobbed toml for AzenForze/RankedPairs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AzenForze/RankedPairs/Cargo.toml [INFO] crate AzenForze/RankedPairs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AzenForze/RankedPairs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AzenForze/RankedPairs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13e716e7e6ec999228cc916fa392489468f5c89f77674817217f57beb2e47f21 [INFO] running `"docker" "start" "-a" "13e716e7e6ec999228cc916fa392489468f5c89f77674817217f57beb2e47f21"` [INFO] [stderr] Checking ranked_pairs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranked_pairs.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | RankedPairs{ sum_matrix: sum_matrix, strength_type: strength_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_matrix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranked_pairs.rs:24:46 [INFO] [stderr] | [INFO] [stderr] 24 | RankedPairs{ sum_matrix: sum_matrix, strength_type: strength_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `strength_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | Matchup { first: first, second: second, first_wins: 0, second_wins: 0 } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup.rs:20:33 [INFO] [stderr] | [INFO] [stderr] 20 | Matchup { first: first, second: second, first_wins: 0, second_wins: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup.rs:67:23 [INFO] [stderr] | [INFO] [stderr] 67 | MatchupError{ description: description } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `winner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:54 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `wins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:66 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `loses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:80 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_margin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | EmptyGraphError { description: description } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:117:62 [INFO] [stderr] | [INFO] [stderr] 117 | TableEntry::Occupied( OccupiedEntry { map: self, row: row, column: column } ) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:117:72 [INFO] [stderr] | [INFO] [stderr] 117 | TableEntry::Occupied( OccupiedEntry { map: self, row: row, column: column } ) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:120:58 [INFO] [stderr] | [INFO] [stderr] 120 | TableEntry::Vacant( VacantEntry { map: self, row: row, column: column } ) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:120:68 [INFO] [stderr] | [INFO] [stderr] 120 | TableEntry::Vacant( VacantEntry { map: self, row: row, column: column } ) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranked_pairs.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | RankedPairs{ sum_matrix: sum_matrix, strength_type: strength_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_matrix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ranked_pairs.rs:24:46 [INFO] [stderr] | [INFO] [stderr] 24 | RankedPairs{ sum_matrix: sum_matrix, strength_type: strength_type } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `strength_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | Matchup { first: first, second: second, first_wins: 0, second_wins: 0 } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup.rs:20:33 [INFO] [stderr] | [INFO] [stderr] 20 | Matchup { first: first, second: second, first_wins: 0, second_wins: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `second` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup.rs:67:23 [INFO] [stderr] | [INFO] [stderr] 67 | MatchupError{ description: description } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:24 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `winner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:40 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `loser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:54 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `wins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:66 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `loses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchup_result.rs:68:80 [INFO] [stderr] | [INFO] [stderr] 68 | MatchupResult{ winner: winner, loser: loser, wins: wins, loses: loses, use_margin: use_margin } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `use_margin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | EmptyGraphError { description: description } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:117:62 [INFO] [stderr] | [INFO] [stderr] 117 | TableEntry::Occupied( OccupiedEntry { map: self, row: row, column: column } ) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:117:72 [INFO] [stderr] | [INFO] [stderr] 117 | TableEntry::Occupied( OccupiedEntry { map: self, row: row, column: column } ) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:120:58 [INFO] [stderr] | [INFO] [stderr] 120 | TableEntry::Vacant( VacantEntry { map: self, row: row, column: column } ) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `row` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/table.rs:120:68 [INFO] [stderr] | [INFO] [stderr] 120 | TableEntry::Vacant( VacantEntry { map: self, row: row, column: column } ) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `column` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/election.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return &self.ballots[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.ballots[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/election.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sum_matrix.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return sum_matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum_matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ranked_pairs.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return ranked_pairs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ranked_pairs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return Err(MatchupError::new("Winner wasn't in matchup".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MatchupError::new("Winner wasn't in matchup".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return &self.description; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | return Some(Ordering::Less); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Less)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | return Some(Ordering::Greater); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Greater)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Some(Ordering::Equal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Equal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | return Some(Ordering::Less); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Less)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | return Some(Ordering::Greater); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Greater)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | return Some(Ordering::Equal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Equal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/matchup_result.rs:47:14 [INFO] [stderr] | [INFO] [stderr] 47 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 48 | | if self.wins < other.wins [INFO] [stderr] 49 | | { [INFO] [stderr] 50 | | return Some(Ordering::Less); [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | else if self.wins < other.wins [INFO] [stderr] 48 | { [INFO] [stderr] 49 | return Some(Ordering::Less); [INFO] [stderr] 50 | } [INFO] [stderr] 51 | else if self.wins > other.wins [INFO] [stderr] 52 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Graph(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Graph(HashMap::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(any.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(any.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / return match map.get(node) [INFO] [stderr] 83 | | { [INFO] [stderr] 84 | | Some(neighbors) => neighbors.iter(), [INFO] [stderr] 85 | | None => [].iter() [INFO] [stderr] 86 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | match map.get(node) [INFO] [stderr] 83 | { [INFO] [stderr] 84 | Some(neighbors) => neighbors.iter(), [INFO] [stderr] 85 | None => [].iter() [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return &self.description; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dfs/mod.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return Some(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/election.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return &self.ballots[..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.ballots[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/election.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sum_matrix.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return sum_matrix; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum_matrix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ranked_pairs.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | return ranked_pairs; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ranked_pairs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | return Err(MatchupError::new("Winner wasn't in matchup".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MatchupError::new("Winner wasn't in matchup".to_owned()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return &self.description; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:37:17 [INFO] [stderr] | [INFO] [stderr] 37 | return Some(Ordering::Less); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Less)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | return Some(Ordering::Greater); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Greater)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | return Some(Ordering::Equal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Equal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | return Some(Ordering::Less); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Less)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | return Some(Ordering::Greater); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Greater)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | return Some(Ordering::Equal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(Ordering::Equal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/matchup_result.rs:47:14 [INFO] [stderr] | [INFO] [stderr] 47 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 48 | | if self.wins < other.wins [INFO] [stderr] 49 | | { [INFO] [stderr] 50 | | return Some(Ordering::Less); [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 47 | else if self.wins < other.wins [INFO] [stderr] 48 | { [INFO] [stderr] 49 | return Some(Ordering::Less); [INFO] [stderr] 50 | } [INFO] [stderr] 51 | else if self.wins > other.wins [INFO] [stderr] 52 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/matchup_result.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return Graph(HashMap::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Graph(HashMap::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return Ok(any.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(any.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:69:9 [INFO] [stderr] | [INFO] [stderr] 69 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:82:9 [INFO] [stderr] | [INFO] [stderr] 82 | / return match map.get(node) [INFO] [stderr] 83 | | { [INFO] [stderr] 84 | | Some(neighbors) => neighbors.iter(), [INFO] [stderr] 85 | | None => [].iter() [INFO] [stderr] 86 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 82 | match map.get(node) [INFO] [stderr] 83 | { [INFO] [stderr] 84 | Some(neighbors) => neighbors.iter(), [INFO] [stderr] 85 | None => [].iter() [INFO] [stderr] 86 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph.rs:151:9 [INFO] [stderr] | [INFO] [stderr] 151 | return &self.description; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dfs/mod.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | return Some(n); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `or_insert` [INFO] [stderr] --> src/table.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / pub fn or_insert(self, val: V) -> &'a mut V [INFO] [stderr] 164 | | where [INFO] [stderr] 165 | | R: Borrow, [INFO] [stderr] 166 | | C: Borrow, [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/election.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | if amount_str.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `amount_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/election.rs:68:20 [INFO] [stderr] | [INFO] [stderr] 68 | if let Some(_) = parts.next() [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 69 | | { [INFO] [stderr] 70 | | return Err(ElectionParseError::ExcessDataError); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________- help: try this: `if parts.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sum_matrix.rs:28:38 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn add_vote(&mut self, vote: &Vec>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `vote`. [INFO] [stderr] --> src/sum_matrix.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | for j in (i+1)..vote.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 34 | for in vote.iter().skip((i+1)) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sum_matrix.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | fn add_win(&mut self, for_cand: &String, against_cand: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sum_matrix.rs:45:60 [INFO] [stderr] | [INFO] [stderr] 45 | fn add_win(&mut self, for_cand: &String, against_cand: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: module `RankedPairsTests` should have a snake case name such as `ranked_pairs_tests` [INFO] [stderr] --> src/ranked_pairs.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / mod RankedPairsTests [INFO] [stderr] 111 | | { [INFO] [stderr] 112 | | use super::*; [INFO] [stderr] 113 | | [INFO] [stderr] ... | [INFO] [stderr] 180 | | } [INFO] [stderr] 181 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/graph.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | map.entry(from).or_insert(Vec::new()).push(to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/graph.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let ref neighbors = graph[any]; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let neighbors = &graph[any];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/graph.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if map.len() <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using map.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ranked_pairs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `or_insert` [INFO] [stderr] --> src/table.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / pub fn or_insert(self, val: V) -> &'a mut V [INFO] [stderr] 164 | | where [INFO] [stderr] 165 | | R: Borrow, [INFO] [stderr] 166 | | C: Borrow, [INFO] [stderr] ... | [INFO] [stderr] 174 | | } [INFO] [stderr] 175 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/election.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | if amount_str.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `amount_str.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/election.rs:68:20 [INFO] [stderr] | [INFO] [stderr] 68 | if let Some(_) = parts.next() [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 69 | | { [INFO] [stderr] 70 | | return Err(ElectionParseError::ExcessDataError); [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________- help: try this: `if parts.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sum_matrix.rs:28:38 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn add_vote(&mut self, vote: &Vec>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `vote`. [INFO] [stderr] --> src/sum_matrix.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | for j in (i+1)..vote.len() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 34 | for in vote.iter().skip((i+1)) [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sum_matrix.rs:45:37 [INFO] [stderr] | [INFO] [stderr] 45 | fn add_win(&mut self, for_cand: &String, against_cand: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/sum_matrix.rs:45:60 [INFO] [stderr] | [INFO] [stderr] 45 | fn add_win(&mut self, for_cand: &String, against_cand: &String) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/graph.rs:25:25 [INFO] [stderr] | [INFO] [stderr] 25 | map.entry(from).or_insert(Vec::new()).push(to); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/graph.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | let ref neighbors = graph[any]; [INFO] [stderr] | ----^^^^^^^^^^^^^-------------- help: try: `let neighbors = &graph[any];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/graph.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | if map.len() <= 0 [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using map.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ranked_pairs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "13e716e7e6ec999228cc916fa392489468f5c89f77674817217f57beb2e47f21"` [INFO] running `"docker" "rm" "-f" "13e716e7e6ec999228cc916fa392489468f5c89f77674817217f57beb2e47f21"` [INFO] [stdout] 13e716e7e6ec999228cc916fa392489468f5c89f77674817217f57beb2e47f21