[INFO] updating cached repository AzMoo/dadsay [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AzMoo/dadsay [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AzMoo/dadsay" "work/ex/clippy-test-run/sources/stable/gh/AzMoo/dadsay"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AzMoo/dadsay'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AzMoo/dadsay" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AzMoo/dadsay"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AzMoo/dadsay'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a9e0c98039ebf6b1f15baae934a263ed51f6ae1 [INFO] sha for GitHub repo AzMoo/dadsay: 6a9e0c98039ebf6b1f15baae934a263ed51f6ae1 [INFO] validating manifest of AzMoo/dadsay on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AzMoo/dadsay on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AzMoo/dadsay [INFO] finished frobbing AzMoo/dadsay [INFO] frobbed toml for AzMoo/dadsay written to work/ex/clippy-test-run/sources/stable/gh/AzMoo/dadsay/Cargo.toml [INFO] started frobbing AzMoo/dadsay [INFO] finished frobbing AzMoo/dadsay [INFO] frobbed toml for AzMoo/dadsay written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AzMoo/dadsay/Cargo.toml [INFO] crate AzMoo/dadsay has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AzMoo/dadsay against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AzMoo/dadsay:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d61459c19e97247d9d886ba3d12851da2086ad6a3256ef35ecba21c5f502464c [INFO] running `"docker" "start" "-a" "d61459c19e97247d9d886ba3d12851da2086ad6a3256ef35ecba21c5f502464c"` [INFO] [stderr] Checking openssl-sys v0.9.15 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking openssl v0.9.15 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking dadsay v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | fn get_max_line_length(lines: &Vec<&str>) -> usize { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | for word in line.split(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `dadface` [INFO] [stderr] --> src/main.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | for idx in 0..dadface.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for (idx, ) in dadface.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / let mut jokestring = ""; [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | if idx > text_bottom - joke.len() && idx <= text_bottom { [INFO] [stderr] 68 | | let joke_idx = idx as i32 - text_bottom as i32 + joke.len() as i32 - 1; [INFO] [stderr] 69 | | jokestring = &joke[joke_idx as usize]; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let jokestring = if idx > text_bottom - joke.len() && idx <= text_bottom { ..; &joke[joke_idx as usize] } else { "" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | Err(_) => panic!("Couldn't start event loop!") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => panic!("Couldn't create https connector, is TLS b0rked?!") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:17:31 [INFO] [stderr] | [INFO] [stderr] 17 | fn get_max_line_length(lines: &Vec<&str>) -> usize { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | for word in line.split(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is used to index `dadface` [INFO] [stderr] --> src/main.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | for idx in 0..dadface.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 64 | for (idx, ) in dadface.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / let mut jokestring = ""; [INFO] [stderr] 66 | | [INFO] [stderr] 67 | | if idx > text_bottom - joke.len() && idx <= text_bottom { [INFO] [stderr] 68 | | let joke_idx = idx as i32 - text_bottom as i32 + joke.len() as i32 - 1; [INFO] [stderr] 69 | | jokestring = &joke[joke_idx as usize]; [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let jokestring = if idx > text_bottom - joke.len() && idx <= text_bottom { ..; &joke[joke_idx as usize] } else { "" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | Err(_) => panic!("Couldn't start event loop!") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | Err(_) => panic!("Couldn't create https connector, is TLS b0rked?!") [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.32s [INFO] running `"docker" "inspect" "d61459c19e97247d9d886ba3d12851da2086ad6a3256ef35ecba21c5f502464c"` [INFO] running `"docker" "rm" "-f" "d61459c19e97247d9d886ba3d12851da2086ad6a3256ef35ecba21c5f502464c"` [INFO] [stdout] d61459c19e97247d9d886ba3d12851da2086ad6a3256ef35ecba21c5f502464c