[INFO] updating cached repository AustinWells/rush [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AustinWells/rush [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AustinWells/rush" "work/ex/clippy-test-run/sources/stable/gh/AustinWells/rush"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AustinWells/rush'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AustinWells/rush" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinWells/rush"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinWells/rush'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 11312a378514c5e90ce03948b8a1057826eabd30 [INFO] sha for GitHub repo AustinWells/rush: 11312a378514c5e90ce03948b8a1057826eabd30 [INFO] validating manifest of AustinWells/rush on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AustinWells/rush on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AustinWells/rush [INFO] finished frobbing AustinWells/rush [INFO] frobbed toml for AustinWells/rush written to work/ex/clippy-test-run/sources/stable/gh/AustinWells/rush/Cargo.toml [INFO] started frobbing AustinWells/rush [INFO] finished frobbing AustinWells/rush [INFO] frobbed toml for AustinWells/rush written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinWells/rush/Cargo.toml [INFO] crate AustinWells/rush has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AustinWells/rush against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AustinWells/rush:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a3b7790d9cb3755df64c52ebaba5a9449f4886c7d4cec0294e1bfb708c787af [INFO] running `"docker" "start" "-a" "9a3b7790d9cb3755df64c52ebaba5a9449f4886c7d4cec0294e1bfb708c787af"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking rsh v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return curline; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `curline` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | None => return EOL, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `EOL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `parse::*` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use parse::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | if let Err(_) = rl.load_history("~/.rsh.hist") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 13 | | println!("No previous history"); [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____- help: try this: `if rl.load_history("~/.rsh.hist").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:86:5 [INFO] [stderr] | [INFO] [stderr] 86 | return curline; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `curline` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parse.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | None => return EOL, [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `EOL` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `parse::*` [INFO] [stderr] --> src/main.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use parse::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:12:12 [INFO] [stderr] | [INFO] [stderr] 12 | if let Err(_) = rl.load_history("~/.rsh.hist") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 13 | | println!("No previous history"); [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____- help: try this: `if rl.load_history("~/.rsh.hist").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.25s [INFO] running `"docker" "inspect" "9a3b7790d9cb3755df64c52ebaba5a9449f4886c7d4cec0294e1bfb708c787af"` [INFO] running `"docker" "rm" "-f" "9a3b7790d9cb3755df64c52ebaba5a9449f4886c7d4cec0294e1bfb708c787af"` [INFO] [stdout] 9a3b7790d9cb3755df64c52ebaba5a9449f4886c7d4cec0294e1bfb708c787af