[INFO] updating cached repository AustinRF2918/Tiny-Tags [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/AustinRF2918/Tiny-Tags [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/AustinRF2918/Tiny-Tags" "work/ex/clippy-test-run/sources/stable/gh/AustinRF2918/Tiny-Tags"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/AustinRF2918/Tiny-Tags'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/AustinRF2918/Tiny-Tags" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinRF2918/Tiny-Tags"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinRF2918/Tiny-Tags'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f6d5dfe748f613beedf242de0a2d48ce1228344d [INFO] sha for GitHub repo AustinRF2918/Tiny-Tags: f6d5dfe748f613beedf242de0a2d48ce1228344d [INFO] validating manifest of AustinRF2918/Tiny-Tags on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of AustinRF2918/Tiny-Tags on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing AustinRF2918/Tiny-Tags [INFO] finished frobbing AustinRF2918/Tiny-Tags [INFO] frobbed toml for AustinRF2918/Tiny-Tags written to work/ex/clippy-test-run/sources/stable/gh/AustinRF2918/Tiny-Tags/Cargo.toml [INFO] started frobbing AustinRF2918/Tiny-Tags [INFO] finished frobbing AustinRF2918/Tiny-Tags [INFO] frobbed toml for AustinRF2918/Tiny-Tags written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/AustinRF2918/Tiny-Tags/Cargo.toml [INFO] crate AustinRF2918/Tiny-Tags has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting AustinRF2918/Tiny-Tags against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/AustinRF2918/Tiny-Tags:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bcffccdc8c2c850d98475aa5829c06d22817568c1dcbd8aaf802be66f2d4bbde [INFO] running `"docker" "start" "-a" "bcffccdc8c2c850d98475aa5829c06d22817568c1dcbd8aaf802be66f2d4bbde"` [INFO] [stderr] Checking fsa v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | fn execute_logic(stack: &Vec, current: &String) -> Option [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:76:48 [INFO] [stderr] | [INFO] [stderr] 76 | fn execute_logic(stack: &Vec, current: &String) -> Option [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 76 | fn execute_logic(stack: &Vec, current: &str) -> Option [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `current.as_str()` to [INFO] [stderr] | [INFO] [stderr] 82 | match current [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] help: change `current.as_str()` to [INFO] [stderr] | [INFO] [stderr] 104| match current [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:223:29 [INFO] [stderr] | [INFO] [stderr] 223 | / match (execute_logic(&push_down, &string), &mode) [INFO] [stderr] 224 | | { [INFO] [stderr] 225 | | (Some(state), &XMLStateType::Open) => [INFO] [stderr] 226 | | { [INFO] [stderr] ... | [INFO] [stderr] 243 | | [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 223 | if let (Some(state), &XMLStateType::Open) = (execute_logic(&push_down, &string), &mode) { [INFO] [stderr] 224 | println!("{}", state); [INFO] [stderr] 225 | if string.as_str() != "" [INFO] [stderr] 226 | { [INFO] [stderr] 227 | match state.as_str() [INFO] [stderr] 228 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | fn execute_logic(stack: &Vec, current: &String) -> Option [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:76:48 [INFO] [stderr] | [INFO] [stderr] 76 | fn execute_logic(stack: &Vec, current: &String) -> Option [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 76 | fn execute_logic(stack: &Vec, current: &str) -> Option [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `current.as_str()` to [INFO] [stderr] | [INFO] [stderr] 82 | match current [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] help: change `current.as_str()` to [INFO] [stderr] | [INFO] [stderr] 104| match current [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:223:29 [INFO] [stderr] | [INFO] [stderr] 223 | / match (execute_logic(&push_down, &string), &mode) [INFO] [stderr] 224 | | { [INFO] [stderr] 225 | | (Some(state), &XMLStateType::Open) => [INFO] [stderr] 226 | | { [INFO] [stderr] ... | [INFO] [stderr] 243 | | [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 223 | if let (Some(state), &XMLStateType::Open) = (execute_logic(&push_down, &string), &mode) { [INFO] [stderr] 224 | println!("{}", state); [INFO] [stderr] 225 | if string.as_str() != "" [INFO] [stderr] 226 | { [INFO] [stderr] 227 | match state.as_str() [INFO] [stderr] 228 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.73s [INFO] running `"docker" "inspect" "bcffccdc8c2c850d98475aa5829c06d22817568c1dcbd8aaf802be66f2d4bbde"` [INFO] running `"docker" "rm" "-f" "bcffccdc8c2c850d98475aa5829c06d22817568c1dcbd8aaf802be66f2d4bbde"` [INFO] [stdout] bcffccdc8c2c850d98475aa5829c06d22817568c1dcbd8aaf802be66f2d4bbde