[INFO] updating cached repository Arekkusuva/web-sample [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/Arekkusuva/web-sample [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/Arekkusuva/web-sample" "work/ex/clippy-test-run/sources/stable/gh/Arekkusuva/web-sample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/Arekkusuva/web-sample'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/Arekkusuva/web-sample" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Arekkusuva/web-sample"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Arekkusuva/web-sample'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b7d79176873348c13a2ed613cf984304df4794bd [INFO] sha for GitHub repo Arekkusuva/web-sample: b7d79176873348c13a2ed613cf984304df4794bd [INFO] validating manifest of Arekkusuva/web-sample on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of Arekkusuva/web-sample on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing Arekkusuva/web-sample [INFO] finished frobbing Arekkusuva/web-sample [INFO] frobbed toml for Arekkusuva/web-sample written to work/ex/clippy-test-run/sources/stable/gh/Arekkusuva/web-sample/Cargo.toml [INFO] started frobbing Arekkusuva/web-sample [INFO] finished frobbing Arekkusuva/web-sample [INFO] frobbed toml for Arekkusuva/web-sample written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/Arekkusuva/web-sample/Cargo.toml [INFO] crate Arekkusuva/web-sample has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting Arekkusuva/web-sample against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/Arekkusuva/web-sample:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c3ee944e02501b86475a493d1c21edafbd3627208142c71b88b043f3b7ef2d5d [INFO] running `"docker" "start" "-a" "c3ee944e02501b86475a493d1c21edafbd3627208142c71b88b043f3b7ef2d5d"` [INFO] [stderr] warning: unused manifest key: dependencies.diesel.dotenv [INFO] [stderr] Checking crossbeam-utils v0.6.1 [INFO] [stderr] Compiling ring v0.13.5 [INFO] [stderr] Checking bytes v0.4.11 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Compiling serde_json v1.0.33 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking combine v3.6.3 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking diesel v1.3.3 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking regex v1.0.6 [INFO] [stderr] Checking slog-json v2.3.0 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking validator v0.8.0 [INFO] [stderr] Checking persistent v0.4.0 [INFO] [stderr] Checking iron-json-response v0.6.0 [INFO] [stderr] Checking jsonwebtoken v5.0.1 [INFO] [stderr] Checking bodyparser v0.8.0 [INFO] [stderr] Compiling validator_derive v0.8.0 [INFO] [stderr] Checking redis v0.9.1 [INFO] [stderr] Checking r2d2_redis v0.8.0 [INFO] [stderr] Checking web_sample v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/middlewares/response_time_logger.rs:22:124 [INFO] [stderr] | [INFO] [stderr] 22 | info!(logger, "Request with response status: {}, took: {}", res.status.unwrap_or(status::NotFound), delta as f64 / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/middlewares/sessions/backends/bearer_jwt_redis.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const DEFAULT_SECRET: &'static str = "%4r6gfd453dfSDfdf34!!^63431!33"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `id` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `name` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/api/middlewares/response_time_logger.rs:22:124 [INFO] [stderr] | [INFO] [stderr] 22 | info!(logger, "Request with response status: {}, took: {}", res.status.unwrap_or(status::NotFound), delta as f64 / 1000000.0); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api/middlewares/sessions/backends/bearer_jwt_redis.rs:12:24 [INFO] [stderr] | [INFO] [stderr] 12 | const DEFAULT_SECRET: &'static str = "%4r6gfd453dfSDfdf34!!^63431!33"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `table` in this scope [INFO] [stderr] --> <::diesel::macros::table_body macros>:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | derive ( Debug , Clone , Copy , QueryId ) ] /// The actual table struct [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `id` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `name` in this scope [INFO] [stderr] --> <::diesel::macros::__diesel_column macros>:5:33 [INFO] [stderr] | [INFO] [stderr] 5 | derive ( Debug , Clone , Copy , QueryId , Default ) ] pub struct $ column_name [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/api/middlewares/sessions/backends/bearer_jwt_redis.rs:67:55 [INFO] [stderr] | [INFO] [stderr] 67 | let key_from_token: String = token.rsplitn(2, ".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/api/middlewares/sessions/stores/redis.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let _: () = conn.hset(&self.session_id, key, value).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/api/middlewares/sessions/backends/bearer_jwt_redis.rs:67:55 [INFO] [stderr] | [INFO] [stderr] 67 | let key_from_token: String = token.rsplitn(2, ".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/api/middlewares/sessions/stores/redis.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let _: () = conn.hset(&self.session_id, key, value).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 26s [INFO] running `"docker" "inspect" "c3ee944e02501b86475a493d1c21edafbd3627208142c71b88b043f3b7ef2d5d"` [INFO] running `"docker" "rm" "-f" "c3ee944e02501b86475a493d1c21edafbd3627208142c71b88b043f3b7ef2d5d"` [INFO] [stdout] c3ee944e02501b86475a493d1c21edafbd3627208142c71b88b043f3b7ef2d5d